From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8BC72211BA46B for ; Thu, 31 Jan 2019 00:23:47 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2019 00:23:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,543,1539673200"; d="scan'208";a="142991515" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 31 Jan 2019 00:23:46 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 31 Jan 2019 00:23:46 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 31 Jan 2019 00:23:46 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.174]) with mapi id 14.03.0415.000; Thu, 31 Jan 2019 16:23:44 +0800 From: "Gao, Liming" To: "Feng, Bob C" , Laszlo Ersek CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set Thread-Index: AQHUt3fKEzUl5vwzQ02/Ad2MmxoUb6XFshmAgAFbmiD//7WNAIACRw0w Date: Thu, 31 Jan 2019 08:23:44 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3D42A6@SHSMSX104.ccr.corp.intel.com> References: <20190129020610.14300-1-bob.c.feng@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3D21FD@SHSMSX104.ccr.corp.intel.com> <08650203BA1BD64D8AD9B6D5D74A85D16007B546@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D16007B546@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGVlMDk3MTUtMDYwMC00NzllLWJlZTMtYmYyY2U2OWFmM2MyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVVJUWFBBS3hLTlZyRnRFVXJhNGNTZUdzSXVrbTJSdHhHVzBPRW9GRlZIZlkxZ1ZDY25wUUEzS2ZCNFZQbUFUOCJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch v2 00/33] BaseTools python3 migration patch set X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 08:23:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Bob: I have no other comments on this patch set. Reviewed-by: Liming Gao Thanks Liming > -----Original Message----- > From: Feng, Bob C > Sent: Wednesday, January 30, 2019 1:25 PM > To: Gao, Liming ; Laszlo Ersek > Cc: edk2-devel@lists.01.org > Subject: RE: [edk2] [Patch v2 00/33] BaseTools python3 migration patch se= t >=20 > I agree this proposal. > I plan to push python3 patch set to edk2 master in this Friday morning, F= eb.1 PRC time if there is no more comments or no critical issues > found. >=20 > Thanks, > Bob >=20 > -----Original Message----- > From: Gao, Liming > Sent: Wednesday, January 30, 2019 9:53 AM > To: Laszlo Ersek ; Feng, Bob C > Cc: edk2-devel@lists.01.org > Subject: RE: [edk2] [Patch v2 00/33] BaseTools python3 migration patch se= t >=20 > Laszlo: > I agree your proposal. Push this patch set first if no other comments, t= hen continue to do minor bug fix. >=20 > Thanks > Liming > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Laszlo Ersek > > Sent: Tuesday, January 29, 2019 9:07 PM > > To: Feng, Bob C > > Cc: edk2-devel@lists.01.org > > Subject: Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch > > set > > > > Hi Bob, > > > > On 01/29/19 03:05, Feng, Bob C wrote: > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D55 > > > > > > V2: > > > The python files under CParser4 folder of ECC/Eot tool are generated > > > by antlr4 and forpython3 usage. > > > They have python3 specific syntax, for example the data type > > > declaration for the arguments of a function. That is not compitable > > > with python2. this patch is to remove these syntax. > > > > > > The version2 patch set is commit to > > > https://github.com/BobCF/edk2.git branch py3basetools_v2 > > > > (reusing the "test plan" from my email at > > > at.com>:) > > > > I ran the following tests, at commit 6edb6bd9f182 ("BaseTools: Eot > > tool > > Python3 adaption", 2019-01-29). Each test was performed in a clean > > tree (after running "git clean -ffdx") and clean environment (I > > re-sourced "edksetup.sh" for each test in separation). In addition, > > the base tools were rebuilt (again from a clean tree) for each test, > > with the following command [1]: > > > > nice make -C "$EDK_TOOLS_PATH" -j $(getconf _NPROCESSORS_ONLN) > > > > (a) On my RHEL7.5 Workstation laptop, I have both the system-level > > python packages installed (python-2.7.5-69.el7_5.x86_64), and the > > extra > > python-3.4 stuff from EPEL-7 (python34-3.4.9-1.el7.x86_64). > > > > (a1) Didn't set either PYTHON3_ENABLE or PYTHON_COMMAND. The build > > utility picked > > > > PYTHON_COMMAND =3D /usr/bin/python3.4 > > > > and I successfully built OvmfPkg for IA32, IA32X64, and X64; also > > ArmVirtQemu for AARCH64. The built firmware images passed a smoke test > > too. > > > > (a2) I removed all the python34 packages (and the dependent packages) > > from my laptop. Didn't set either of PYTHON3_ENABLE and PYTHON_COMMAND. > > (This is the configuration what a "normal" RHEL7 environment would > > provide.) The "build" utility didn't print any PYTHON_COMMAND setting, > > but the same fw platform builds as in (a1) completed fine. The smoke > > tests passed again as well. > > > > (b) RHEL-8 virtual machine, with "/usr/bin/python3.6" from > > python36-3.6.6-18.el8.x86_64, and "/usr/libexec/platform-python" from > > platform-python-3.6.8-1.el8.x86_64. > > > > (b1) Didn't set either PYTHON3_ENABLE or PYTHON_COMMAND. The build > > utility picked > > > > PYTHON_COMMAND =3D /usr/bin/python3.6 > > > > and I successfully built OvmfPkg for IA32, IA32X64, and X64. (I don't > > have a cross-compiler installed in this environment yet, nor a RHEL8 > > aarch64 KVM guest, so I couldn't test ArmVirtQemu for now). > > > > (b2) I set PYTHON_COMMAND to "/usr/libexec/platform-python". Didn't > > set PYTHON3_ENABLE. The same builds as in (b1) succeeded. > > > > > > For the series: > > > > Tested-by: Laszlo Ersek > > > > Given that the testing is quite time consuming, I suggest that we push > > v2 (assuming reviewers don't find critical issues), and address small > > issues incrementally. > > > > Thanks! > > Laszlo > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel