[PATCH] FatPkg/FatPei/Gpt.c: Fix uninitialized variable issue

[PATCH] FatPkg/FatPei/Gpt.c: Fix uninitialized variable issue

[Chen A Chen]

Uninitialized pointer variable may randomly point to a block of memory.
In This case, FreePool function will free a block of memory that is not
belongs to this function.

Cc: Ruiyu Ni <ray.ni@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
---
 FatPkg/FatPei/Gpt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/FatPkg/FatPei/Gpt.c b/FatPkg/FatPei/Gpt.c
index c3afb668d7..bba33c5bfd 100644
--- a/FatPkg/FatPei/Gpt.c
+++ b/FatPkg/FatPei/Gpt.c
@@ -244,6 +244,9 @@ PartitionCheckGptEntryArray (
   UINTN                           Index2;
   EFI_PARTITION_ENTRY             *Entry;
 
+  PartitionEntryBuffer = NULL;
+  PartitionEntryStatus = NULL;
+
   ParentBlockDev  = &(PrivateData->BlockDevice[ParentBlockDevNo]);
   Found           = FALSE;
 
-- 
2.16.2.windows.1

Re: [PATCH] FatPkg/FatPei/Gpt.c: Fix uninitialized variable issue

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Chen A Chen
> Sent: Friday, February 1, 2019 10:21 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>
> Subject: [edk2] [PATCH] FatPkg/FatPei/Gpt.c: Fix uninitialized variable issue
> 
> Uninitialized pointer variable may randomly point to a block of memory.
> In This case, FreePool function will free a block of memory that is not
> belongs to this function.
> 
> Cc: Ruiyu Ni <ray.ni@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
> ---
>  FatPkg/FatPei/Gpt.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/FatPkg/FatPei/Gpt.c b/FatPkg/FatPei/Gpt.c
> index c3afb668d7..bba33c5bfd 100644
> --- a/FatPkg/FatPei/Gpt.c
> +++ b/FatPkg/FatPei/Gpt.c
> @@ -244,6 +244,9 @@ PartitionCheckGptEntryArray (
>    UINTN                           Index2;
>    EFI_PARTITION_ENTRY             *Entry;
> 
> +  PartitionEntryBuffer = NULL;
> +  PartitionEntryStatus = NULL;
> +
>    ParentBlockDev  = &(PrivateData->BlockDevice[ParentBlockDevNo]);
>    Found           = FALSE;
> 
> --
> 2.16.2.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel