Re: [PATCH 1/3] MdePkg: Change structure parameter types

["Gao, Liming" <liming.gao@intel.com>]

The change is good. Please update header comments to describe the change in PI 1.7. 

With this change, Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zhang, Shenglei
>Sent: Wednesday, February 13, 2019 2:52 PM
>To: edk2-devel@lists.01.org
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>
>Subject: [PATCH 1/3] MdePkg: Change structure parameter types
>
>Change parameter Opcode from UINT16 to UINTN
>in EFI_S3_SAVE_STATE_WRITE and EFI_S3_SAVE_STATE_INSERT.
>https://bugzilla.tianocore.org/show_bug.cgi?id=1517
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> MdePkg/Include/Protocol/S3SaveState.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/MdePkg/Include/Protocol/S3SaveState.h
>b/MdePkg/Include/Protocol/S3SaveState.h
>index 9e7b4050f6..1563527148 100644
>--- a/MdePkg/Include/Protocol/S3SaveState.h
>+++ b/MdePkg/Include/Protocol/S3SaveState.h
>@@ -52,7 +52,7 @@ typedef
> EFI_STATUS
> (EFIAPI *EFI_S3_SAVE_STATE_WRITE)(
>    IN CONST EFI_S3_SAVE_STATE_PROTOCOL  *This,
>-   IN       UINT16                      OpCode,
>+   IN       UINTN                       OpCode,
>    ...
> );
>
>@@ -98,7 +98,7 @@ EFI_STATUS
>    IN CONST EFI_S3_SAVE_STATE_PROTOCOL  *This,
>    IN       BOOLEAN                     BeforeOrAfter,
>    IN OUT   EFI_S3_BOOT_SCRIPT_POSITION *Position       OPTIONAL,
>-   IN       UINT16                      OpCode,
>+   IN       UINTN                       OpCode,
>    ...
> );
>
>--
>2.18.0.windows.1