From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 017C6201B042E for ; Wed, 13 Feb 2019 16:06:28 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2019 16:06:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,367,1544515200"; d="scan'208";a="320202150" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 13 Feb 2019 16:06:28 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 13 Feb 2019 16:06:28 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 13 Feb 2019 16:06:27 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.109]) with mapi id 14.03.0415.000; Thu, 14 Feb 2019 08:06:26 +0800 From: "Gao, Liming" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" Thread-Topic: [PATCH 1/3] MdePkg: Change structure parameter types Thread-Index: AQHUw2ibwqtRP+FydkiBwvtixNnVz6Xeayvw Date: Thu, 14 Feb 2019 00:06:26 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3DDA68@SHSMSX104.ccr.corp.intel.com> References: <20190213065137.11296-1-shenglei.zhang@intel.com> <20190213065137.11296-2-shenglei.zhang@intel.com> In-Reply-To: <20190213065137.11296-2-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/3] MdePkg: Change structure parameter types X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 00:06:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The change is good. Please update header comments to describe the change in= PI 1.7.=20 With this change, Reviewed-by: Liming Gao >-----Original Message----- >From: Zhang, Shenglei >Sent: Wednesday, February 13, 2019 2:52 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [PATCH 1/3] MdePkg: Change structure parameter types > >Change parameter Opcode from UINT16 to UINTN >in EFI_S3_SAVE_STATE_WRITE and EFI_S3_SAVE_STATE_INSERT. >https://bugzilla.tianocore.org/show_bug.cgi?id=3D1517 > >Cc: Michael D Kinney >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Shenglei Zhang >--- > MdePkg/Include/Protocol/S3SaveState.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/MdePkg/Include/Protocol/S3SaveState.h >b/MdePkg/Include/Protocol/S3SaveState.h >index 9e7b4050f6..1563527148 100644 >--- a/MdePkg/Include/Protocol/S3SaveState.h >+++ b/MdePkg/Include/Protocol/S3SaveState.h >@@ -52,7 +52,7 @@ typedef > EFI_STATUS > (EFIAPI *EFI_S3_SAVE_STATE_WRITE)( > IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This, >- IN UINT16 OpCode, >+ IN UINTN OpCode, > ... > ); > >@@ -98,7 +98,7 @@ EFI_STATUS > IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This, > IN BOOLEAN BeforeOrAfter, > IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL, >- IN UINT16 OpCode, >+ IN UINTN OpCode, > ... > ); > >-- >2.18.0.windows.1