From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function parameter types
Date: Thu, 14 Feb 2019 00:06:36 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3DDA73@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190213065137.11296-3-shenglei.zhang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Shenglei Zhang
>Sent: Wednesday, February 13, 2019 2:52 PM
>To: edk2-devel@lists.01.org
>Cc: Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: [edk2] [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change
>function parameter types
>
>Change parameter Opcode from UINT16 to UINTN in
>BootScriptWrite and BootScriptInsert.
>https://bugzilla.tianocore.org/show_bug.cgi?id=1517
>
>Cc: Jian J Wang <jian.j.wang@intel.com>
>Cc: Hao Wu <hao.a.wu@intel.com>
>Cc: Ray Ni <ray.ni@intel.com>
>Cc: Star Zeng <star.zeng@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> .../Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h | 4 ++--
> MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git
>a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
>b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
>index 19600085f1..b710919881 100644
>--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
>+++
>b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
>@@ -75,7 +75,7 @@ EFI_STATUS
> EFIAPI
> BootScriptWrite (
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> );
> /**
>@@ -112,7 +112,7 @@ BootScriptInsert (
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
> IN BOOLEAN BeforeOrAfter,
> IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> );
> /**
>diff --git a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
>b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
>index 274f3be12c..5913078d69 100644
>--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
>+++ b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
>@@ -542,7 +542,7 @@ EFI_STATUS
> EFIAPI
> BootScriptWrite (
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> )
> {
>@@ -697,7 +697,7 @@ BootScriptInsert (
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
> IN BOOLEAN BeforeOrAfter,
> IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> )
> {
>--
>2.18.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2019-02-14 0:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 6:51 [PATCH 0/3] Change parameters' type in MdePkg and MdeModulePkg Shenglei Zhang
2019-02-13 6:51 ` [PATCH 1/3] MdePkg: Change structure parameter types Shenglei Zhang
2019-02-14 0:06 ` Gao, Liming
2019-02-13 6:51 ` [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function " Shenglei Zhang
2019-02-14 0:06 ` Gao, Liming [this message]
2019-02-13 6:51 ` [PATCH 3/3] MdeModulePkg/SmmS3SaveStateDxe: " Shenglei Zhang
2019-02-14 0:06 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3DDA73@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox