From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6E45C21959CB2 for ; Wed, 13 Feb 2019 16:06:39 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2019 16:06:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,367,1544515200"; d="scan'208";a="274889627" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 13 Feb 2019 16:06:38 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 13 Feb 2019 16:06:38 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.232]) with mapi id 14.03.0415.000; Thu, 14 Feb 2019 08:06:36 +0800 From: "Gao, Liming" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Wu, Hao A" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function parameter types Thread-Index: AQHUw2irkF6uGpyOO0q/pbMheR8IWKXea3jQ Date: Thu, 14 Feb 2019 00:06:36 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3DDA73@SHSMSX104.ccr.corp.intel.com> References: <20190213065137.11296-1-shenglei.zhang@intel.com> <20190213065137.11296-3-shenglei.zhang@intel.com> In-Reply-To: <20190213065137.11296-3-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function parameter types X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 00:06:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Shenglei Zhang >Sent: Wednesday, February 13, 2019 2:52 PM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Zeng, Star >Subject: [edk2] [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change >function parameter types > >Change parameter Opcode from UINT16 to UINTN in >BootScriptWrite and BootScriptInsert. >https://bugzilla.tianocore.org/show_bug.cgi?id=3D1517 > >Cc: Jian J Wang >Cc: Hao Wu >Cc: Ray Ni >Cc: Star Zeng >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Shenglei Zhang >--- > .../Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h | 4 ++-- > MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git >a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h >b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h >index 19600085f1..b710919881 100644 >--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h >+++ >b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h >@@ -75,7 +75,7 @@ EFI_STATUS > EFIAPI > BootScriptWrite ( > IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This, >- IN UINT16 OpCode, >+ IN UINTN OpCode, > ... > ); > /** >@@ -112,7 +112,7 @@ BootScriptInsert ( > IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This, > IN BOOLEAN BeforeOrAfter, > IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL, >- IN UINT16 OpCode, >+ IN UINTN OpCode, > ... > ); > /** >diff --git a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c >b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c >index 274f3be12c..5913078d69 100644 >--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c >+++ b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c >@@ -542,7 +542,7 @@ EFI_STATUS > EFIAPI > BootScriptWrite ( > IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This, >- IN UINT16 OpCode, >+ IN UINTN OpCode, > ... > ) > { >@@ -697,7 +697,7 @@ BootScriptInsert ( > IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This, > IN BOOLEAN BeforeOrAfter, > IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL, >- IN UINT16 OpCode, >+ IN UINTN OpCode, > ... > ) > { >-- >2.18.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel