From: "Gao, Liming" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix the build report issue about Structure PCD
Date: Thu, 14 Feb 2019 14:29:51 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3DEB9A@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190201090035.31252-1-bob.c.feng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Feng, Bob C
> Sent: Friday, February 1, 2019 5:01 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: Fix the build report issue about Structure PCD
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1472
> build report use incorrect method to parse DynamicDefault/DynamicExDefault
> and DynamicVpd/DynamicExVpd structure Pcd value.
>
> This patch is to fix this issue.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> BaseTools/Source/Python/build/BuildReport.py | 21 +++++++-------------
> 1 file changed, 7 insertions(+), 14 deletions(-)
>
> diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
> index 8d3b030151..64f8a68516 100644
> --- a/BaseTools/Source/Python/build/BuildReport.py
> +++ b/BaseTools/Source/Python/build/BuildReport.py
> @@ -1109,24 +1109,17 @@ class PcdReport(object):
> break
> else:
> SkuList = sorted(Pcd.SkuInfoList.keys())
> for Sku in SkuList:
> SkuInfo = Pcd.SkuInfoList[Sku]
> - if TypeName in ('DYNHII', 'DEXHII'):
> - if SkuInfo.DefaultStoreDict:
> - DefaultStoreList = sorted(SkuInfo.DefaultStoreDict.keys())
> - for DefaultStore in DefaultStoreList:
> - OverrideValues = Pcd.SkuOverrideValues[Sku]
> - DscOverride = self.ParseStruct(OverrideValues[DefaultStore])
> - if DscOverride:
> - break
> - else:
> - OverrideValues = Pcd.SkuOverrideValues[Sku]
> - if OverrideValues:
> - Keys = list(OverrideValues.keys())
> - OverrideFieldStruct = self.OverrideFieldValue(Pcd, OverrideValues[Keys[0]])
> - DscOverride = self.ParseStruct(OverrideFieldStruct)
> + if SkuInfo.DefaultStoreDict:
> + DefaultStoreList = sorted(SkuInfo.DefaultStoreDict.keys())
> + for DefaultStore in DefaultStoreList:
> + OverrideValues = Pcd.SkuOverrideValues[Sku]
> + DscOverride = self.ParseStruct(OverrideValues[DefaultStore])
> + if DscOverride:
> + break
> if DscOverride:
> break
> if DscOverride:
> DscDefaultValue = True
> DscMatch = True
> --
> 2.20.1.windows.1
prev parent reply other threads:[~2019-02-14 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 9:00 [Patch] BaseTools: Fix the build report issue about Structure PCD Feng, Bob C
2019-02-14 14:29 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3DEB9A@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox