public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function
Date: Tue, 19 Feb 2019 09:07:37 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3E16EE@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190216145446.8392-1-bob.c.feng@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Feng, Bob C
>Sent: Saturday, February 16, 2019 10:55 PM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function
>
>MaxSizeUserSet is missing in Pcd deepcopy function.
>This patch is to add it back to Pcd deepcopy function.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>---
> BaseTools/Source/Python/Workspace/BuildClassObject.py | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/BaseTools/Source/Python/Workspace/BuildClassObject.py
>b/BaseTools/Source/Python/Workspace/BuildClassObject.py
>index 1df042f41c..d7ca9e8cf1 100644
>--- a/BaseTools/Source/Python/Workspace/BuildClassObject.py
>+++ b/BaseTools/Source/Python/Workspace/BuildClassObject.py
>@@ -220,10 +220,11 @@ class PcdClassObject(object):
>         new_pcd.Type = self.Type
>         new_pcd.DatumType = self.DatumType
>         new_pcd.DefaultValue = self.DefaultValue
>         new_pcd.TokenValue = self.TokenValue
>         new_pcd.MaxDatumSize = self.MaxDatumSize
>+        new_pcd.MaxSizeUserSet = self.MaxSizeUserSet
>
>         new_pcd.Phase = self.Phase
>         new_pcd.Pending = self.Pending
>         new_pcd.IsOverrided = self.IsOverrided
>         new_pcd.IsFromBinaryInf = self.IsFromBinaryInf
>--
>2.18.0.windows.1



      reply	other threads:[~2019-02-19  9:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-16 14:54 [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function Feng, Bob C
2019-02-19  9:07 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3E16EE@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox