From: "Gao, Liming" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTool: Fixed incremental rebuild issue.
Date: Wed, 20 Feb 2019 13:34:16 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3E2967@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190220100925.40008-1-bob.c.feng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, February 20, 2019 6:09 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTool: Fixed incremental rebuild issue.
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1540
>
> This issue in introduced by commit
> d943b0c339fe3d35ffdf9f580ccb7a55915c6854
>
> To convert bytes to string, we need to use bytes.decode()
> instead of using str(bytes)
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> BaseTools/Source/Python/AutoGen/GenMake.py | 2 +-
> BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
> index 53c5b8577d..641ed8305f 100644
> --- a/BaseTools/Source/Python/AutoGen/GenMake.py
> +++ b/BaseTools/Source/Python/AutoGen/GenMake.py
> @@ -1048,11 +1048,11 @@ cleanlib:
>
> if FileContent[0] == 0xff or FileContent[0] == 0xfe:
> FileContent = FileContent.decode('utf-16')
> else:
> try:
> - FileContent = str(FileContent)
> + FileContent = FileContent.decode()
> except:
> pass
> IncludedFileList = gIncludePattern.findall(FileContent)
>
> for Inc in IncludedFileList:
> diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
> index 1ffefe6e7e..74bc333144 100644
> --- a/BaseTools/Source/Python/Workspace/DscBuildData.py
> +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
> @@ -158,11 +158,11 @@ def GetDependencyList(FileStack, SearchPathList):
> if FileContent[0] == 0xff or FileContent[0] == 0xfe:
> FileContent = FileContent.decode('utf-16')
> IncludedFileList = gIncludePattern.findall(FileContent)
> else:
> try:
> - FileContent = str(FileContent)
> + FileContent = FileContent.decode()
> IncludedFileList = gIncludePattern.findall(FileContent)
> except:
> pass
> IncludedFileList = gIncludePattern.findall(FileContent)
>
> --
> 2.20.1.windows.1
prev parent reply other threads:[~2019-02-20 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 10:09 [Patch] BaseTool: Fixed incremental rebuild issue Feng, Bob C
2019-02-20 13:34 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3E2967@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox