public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] BaseTool: Fixed incremental rebuild issue.
@ 2019-02-20 10:09 Feng, Bob C
  2019-02-20 13:34 ` Gao, Liming
  0 siblings, 1 reply; 2+ messages in thread
From: Feng, Bob C @ 2019-02-20 10:09 UTC (permalink / raw)
  To: edk2-devel; +Cc: Bob Feng, Liming Gao

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1540

This issue in introduced by commit
d943b0c339fe3d35ffdf9f580ccb7a55915c6854

To convert bytes to string, we need to use bytes.decode()
instead of using str(bytes)

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Source/Python/AutoGen/GenMake.py        | 2 +-
 BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
index 53c5b8577d..641ed8305f 100644
--- a/BaseTools/Source/Python/AutoGen/GenMake.py
+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
@@ -1048,11 +1048,11 @@ cleanlib:
 
                 if FileContent[0] == 0xff or FileContent[0] == 0xfe:
                     FileContent = FileContent.decode('utf-16')
                 else:
                     try:
-                        FileContent = str(FileContent)
+                        FileContent = FileContent.decode()
                     except:
                         pass
                 IncludedFileList = gIncludePattern.findall(FileContent)
 
                 for Inc in IncludedFileList:
diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index 1ffefe6e7e..74bc333144 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -158,11 +158,11 @@ def GetDependencyList(FileStack, SearchPathList):
             if FileContent[0] == 0xff or FileContent[0] == 0xfe:
                 FileContent = FileContent.decode('utf-16')
                 IncludedFileList = gIncludePattern.findall(FileContent)
             else:
                 try:
-                    FileContent = str(FileContent)
+                    FileContent = FileContent.decode()
                     IncludedFileList = gIncludePattern.findall(FileContent)
                 except:
                     pass
             IncludedFileList = gIncludePattern.findall(FileContent)
 
-- 
2.20.1.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] BaseTool: Fixed incremental rebuild issue.
  2019-02-20 10:09 [Patch] BaseTool: Fixed incremental rebuild issue Feng, Bob C
@ 2019-02-20 13:34 ` Gao, Liming
  0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2019-02-20 13:34 UTC (permalink / raw)
  To: Feng, Bob C, edk2-devel@lists.01.org

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, February 20, 2019 6:09 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTool: Fixed incremental rebuild issue.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1540
> 
> This issue in introduced by commit
> d943b0c339fe3d35ffdf9f580ccb7a55915c6854
> 
> To convert bytes to string, we need to use bytes.decode()
> instead of using str(bytes)
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  BaseTools/Source/Python/AutoGen/GenMake.py        | 2 +-
>  BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
> index 53c5b8577d..641ed8305f 100644
> --- a/BaseTools/Source/Python/AutoGen/GenMake.py
> +++ b/BaseTools/Source/Python/AutoGen/GenMake.py
> @@ -1048,11 +1048,11 @@ cleanlib:
> 
>                  if FileContent[0] == 0xff or FileContent[0] == 0xfe:
>                      FileContent = FileContent.decode('utf-16')
>                  else:
>                      try:
> -                        FileContent = str(FileContent)
> +                        FileContent = FileContent.decode()
>                      except:
>                          pass
>                  IncludedFileList = gIncludePattern.findall(FileContent)
> 
>                  for Inc in IncludedFileList:
> diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
> index 1ffefe6e7e..74bc333144 100644
> --- a/BaseTools/Source/Python/Workspace/DscBuildData.py
> +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
> @@ -158,11 +158,11 @@ def GetDependencyList(FileStack, SearchPathList):
>              if FileContent[0] == 0xff or FileContent[0] == 0xfe:
>                  FileContent = FileContent.decode('utf-16')
>                  IncludedFileList = gIncludePattern.findall(FileContent)
>              else:
>                  try:
> -                    FileContent = str(FileContent)
> +                    FileContent = FileContent.decode()
>                      IncludedFileList = gIncludePattern.findall(FileContent)
>                  except:
>                      pass
>              IncludedFileList = gIncludePattern.findall(FileContent)
> 
> --
> 2.20.1.windows.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-20 13:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-20 10:09 [Patch] BaseTool: Fixed incremental rebuild issue Feng, Bob C
2019-02-20 13:34 ` Gao, Liming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox