From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A3CE82194EB7A for ; Wed, 20 Feb 2019 06:30:51 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 06:30:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,391,1544515200"; d="scan'208";a="123888779" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 20 Feb 2019 06:30:50 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Feb 2019 06:30:50 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Feb 2019 06:30:50 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.162]) with mapi id 14.03.0415.000; Wed, 20 Feb 2019 22:30:48 +0800 From: "Gao, Liming" To: "Gao, Zhichao" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH v3 1/6] MdeModulePkg: change the function name ResetSystem Thread-Index: AQHUyPfvNa7dKjZXj0GI7L19Kg/DUKXov2zA Date: Wed, 20 Feb 2019 14:30:47 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3E2A8F@SHSMSX104.ccr.corp.intel.com> References: <20190220083908.2552-1-zhichao.gao@intel.com> <20190220083908.2552-2-zhichao.gao@intel.com> In-Reply-To: <20190220083908.2552-2-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWIyNmJjOWYtZDNmOS00M2FjLTk3MzItZGMxNmUzODU4YTMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieStmMDV6VGwyU0FDRWh5ZlhzUmlQOFl0SnJHb1pYRGNPR0NGUG41N0ZQemJ4N1B4Vnhya2h1R0ZnZlZIZUdSdCJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 1/6] MdeModulePkg: change the function name ResetSystem X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 14:30:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhichao: My comment is to change function name as RuntimeServiceResetSystem. This = is the similar name in RuntimeServiceSetVariable of Variable driver. I don'= t suggest to use Efi as function prefix.=20 Thanks Liming > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, February 20, 2019 4:39 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray ; Gao, Liming > Subject: [PATCH v3 1/6] MdeModulePkg: change the function name ResetSyste= m >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1460 >=20 > Change the function name form ResetSystem to EfiRuntimeResetSystem. > Because ResetSystem and EfiResetSystem would be used in ResetSystemLib > and RuntimeLib. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao > Cc: Ray Ni > Cc: Liming Gao > --- > MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 ++++---- > MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > index afc35587fc..e16b0cda7b 100644 > --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > @@ -1,7 +1,7 @@ > /** @file > Reset Architectural and Reset Notification protocols implementation. >=20 > - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
>=20 > This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD License > @@ -187,7 +187,7 @@ InitializeResetSystem ( > // > // Hook the runtime service table > // > - gRT->ResetSystem =3D ResetSystem; > + gRT->ResetSystem =3D EfiRuntimeResetSystem; >=20 > // > // Now install the Reset RT AP on a new handle > @@ -242,7 +242,7 @@ DoS3 ( > **/ > VOID > EFIAPI > -ResetSystem ( > +EfiRuntimeResetSystem ( > IN EFI_RESET_TYPE ResetType, > IN EFI_STATUS ResetStatus, > IN UINTN DataSize, > @@ -256,7 +256,7 @@ ResetSystem ( > RESET_NOTIFY_ENTRY *Entry; >=20 > // > - // Only do REPORT_STATUS_CODE() on first call to ResetSystem() > + // Only do REPORT_STATUS_CODE() on first call to EfiRuntimeResetSystem= () > // > if (mResetNotifyDepth =3D=3D 0) { > // > diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h > index 8529de675c..448e30f079 100644 > --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h > +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
>=20 > This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD License > @@ -97,7 +97,7 @@ InitializeResetSystem ( > **/ > VOID > EFIAPI > -ResetSystem ( > +EfiRuntimeResetSystem ( > IN EFI_RESET_TYPE ResetType, > IN EFI_STATUS ResetStatus, > IN UINTN DataSize, > -- > 2.16.2.windows.1