From: "Gao, Liming" <liming.gao@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v3 0/6] ResetSystemLib changings
Date: Wed, 20 Feb 2019 14:41:17 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3E2AB3@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190220083908.2552-1-zhichao.gao@intel.com>
Zhichao:
For patch2~5, my comment is to move patch 4 as patch 2. Normally, we add API definition in library class header file first, then update the library instance implementation. I have no comments for the code change. Reviewed-by: Liming Gao <liming.gao@intel.com>
Thanks
Liming
> -----Original Message-----
> From: Gao, Zhichao
> Sent: Wednesday, February 20, 2019 4:39 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH v3 0/6] ResetSystemLib changings
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
> Add a new API ResetSystem in ResetSystemLib.
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1461
> Implement a runtime library instance of ResetSystemLib base on the new changing.
>
> V2: Add some required data type header file
>
> V3: Resolve a case-typing error.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
>
> Zhichao Gao (6):
> MdeModulePkg: change the function name ResetSystem
> MdeModulePkg: Add a new API ResetSystem for DXE ResetSystemLib
> MdeModulePkg: Add a new API ResetSystem for Null version
> MdeModulePkg: Add the new API ResetSystem in the head file
> MdeModulePkg: Add a runtime library instance of ResetSystemLib
> MdeModulePkg: Add the runtime ResetSystemLib in MdeModulePkg.dsc
>
> MdeModulePkg/Include/Library/ResetSystemLib.h | 28 ++-
> .../BaseResetSystemLibNull.c | 27 +++
> .../Library/DxeResetSystemLib/DxeResetSystemLib.c | 28 ++-
> .../RuntimeResetSystemLib/RuntimeResetSystemLib.c | 216 +++++++++++++++++++++
> .../RuntimeResetSystemLib.inf | 50 +++++
> .../RuntimeResetSystemLib.uni | 21 ++
> MdeModulePkg/MdeModulePkg.dsc | 1 +
> .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 +-
> .../Universal/ResetSystemRuntimeDxe/ResetSystem.h | 4 +-
> 9 files changed, 375 insertions(+), 8 deletions(-)
> create mode 100644 MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c
> create mode 100644 MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.inf
> create mode 100644 MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.uni
>
> --
> 2.16.2.windows.1
prev parent reply other threads:[~2019-02-20 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 8:39 [PATCH v3 0/6] ResetSystemLib changings Zhichao Gao
2019-02-20 8:39 ` [PATCH v3 1/6] MdeModulePkg: change the function name ResetSystem Zhichao Gao
2019-02-20 14:30 ` Gao, Liming
2019-02-20 8:39 ` [PATCH v3 2/6] MdeModulePkg: Add a new API ResetSystem for DXE ResetSystemLib Zhichao Gao
2019-02-20 8:39 ` [PATCH v3 3/6] MdeModulePkg: Add a new API ResetSystem for Null version Zhichao Gao
2019-02-20 8:39 ` [PATCH v3 4/6] MdeModulePkg: Add the new API ResetSystem in the head file Zhichao Gao
2019-02-20 8:39 ` [PATCH v3 5/6] MdeModulePkg: Add a runtime library instance of ResetSystemLib Zhichao Gao
2019-02-20 8:39 ` [PATCH v3 6/6] MdeModulePkg: Add the runtime ResetSystemLib in MdeModulePkg.dsc Zhichao Gao
2019-02-20 14:41 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3E2AB3@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox