From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1CA262194EB7A for ; Wed, 20 Feb 2019 06:41:23 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 06:41:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,391,1544515200"; d="scan'208";a="276491609" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 20 Feb 2019 06:41:23 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Feb 2019 06:41:20 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Feb 2019 06:41:20 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.110]) with mapi id 14.03.0415.000; Wed, 20 Feb 2019 22:41:18 +0800 From: "Gao, Liming" To: "Gao, Zhichao" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH v3 0/6] ResetSystemLib changings Thread-Index: AQHUyPfvPDYu5XRZ00OI/WWhd1NFB6XowhEA Date: Wed, 20 Feb 2019 14:41:17 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3E2AB3@SHSMSX104.ccr.corp.intel.com> References: <20190220083908.2552-1-zhichao.gao@intel.com> In-Reply-To: <20190220083908.2552-1-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjNhZGZhY2YtMjYyMy00ZTVlLWJmMzctYzcwZDU0MmZkNjI5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZElWRTA3NHU1R2JCTlhIUjhaNHNmYWs3RGtDYzR2YllGSm14c1p4dE0xaGJvWUNyV1hxSnZMXC82OEJCSTRRblkifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 0/6] ResetSystemLib changings X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 14:41:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhichao: For patch2~5, my comment is to move patch 4 as patch 2. Normally, we add = API definition in library class header file first, then update the library = instance implementation. I have no comments for the code change. Reviewed-b= y: Liming Gao Thanks Liming > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, February 20, 2019 4:39 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray ; Gao, Liming > Subject: [PATCH v3 0/6] ResetSystemLib changings >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1460 > Add a new API ResetSystem in ResetSystemLib. > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1461 > Implement a runtime library instance of ResetSystemLib base on the new ch= anging. >=20 > V2: Add some required data type header file >=20 > V3: Resolve a case-typing error. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao > Cc: Ray Ni > Cc: Liming Gao >=20 > Zhichao Gao (6): > MdeModulePkg: change the function name ResetSystem > MdeModulePkg: Add a new API ResetSystem for DXE ResetSystemLib > MdeModulePkg: Add a new API ResetSystem for Null version > MdeModulePkg: Add the new API ResetSystem in the head file > MdeModulePkg: Add a runtime library instance of ResetSystemLib > MdeModulePkg: Add the runtime ResetSystemLib in MdeModulePkg.dsc >=20 > MdeModulePkg/Include/Library/ResetSystemLib.h | 28 ++- > .../BaseResetSystemLibNull.c | 27 +++ > .../Library/DxeResetSystemLib/DxeResetSystemLib.c | 28 ++- > .../RuntimeResetSystemLib/RuntimeResetSystemLib.c | 216 +++++++++++++++= ++++++ > .../RuntimeResetSystemLib.inf | 50 +++++ > .../RuntimeResetSystemLib.uni | 21 ++ > MdeModulePkg/MdeModulePkg.dsc | 1 + > .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 +- > .../Universal/ResetSystemRuntimeDxe/ResetSystem.h | 4 +- > 9 files changed, 375 insertions(+), 8 deletions(-) > create mode 100644 MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeRes= etSystemLib.c > create mode 100644 MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeRes= etSystemLib.inf > create mode 100644 MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeRes= etSystemLib.uni >=20 > -- > 2.16.2.windows.1