From: "Gao, Liming" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Add parameter check for the AsciiStringToUint64
Date: Fri, 22 Feb 2019 15:48:06 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3E6287@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190222100502.10332-1-bob.c.feng@intel.com>
Bob:
This function is used to convert string to UINT64. So, the string len should not be too long. I think UINT8 max value 255 is enough for its usage.
Thanks
Liming
> -----Original Message-----
> From: Feng, Bob C
> Sent: Friday, February 22, 2019 6:05 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: Add parameter check for the AsciiStringToUint64
>
> If the input parameter AsciiString length is greater
> than 255, the GenFv will hang.
>
> This patch is to fix this issue.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> BaseTools/Source/C/Common/ParseInf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/C/Common/ParseInf.c b/BaseTools/Source/C/Common/ParseInf.c
> index 3907f44331..b29f4c2f93 100644
> --- a/BaseTools/Source/C/Common/ParseInf.c
> +++ b/BaseTools/Source/C/Common/ParseInf.c
> @@ -493,11 +493,11 @@ Returns:
> EFI_SUCCESS Number successfully converted.
> EFI_ABORTED Invalid character encountered.
>
> --*/
> {
> - UINT8 Index;
> + UINT32 Index;
> UINT64 Value;
> CHAR8 CurrentChar;
>
> //
> // Initialize the result
> @@ -506,11 +506,11 @@ Returns:
> Index = 0;
>
> //
> // Check input parameter
> //
> - if (AsciiString == NULL || ReturnValue == NULL) {
> + if (AsciiString == NULL || ReturnValue == NULL || strlen(AsciiString) > 0xFFFFFFFF) {
> return EFI_INVALID_PARAMETER;
> }
> while (AsciiString[Index] == ' ') {
> Index ++;
> }
> --
> 2.20.1.windows.1
prev parent reply other threads:[~2019-02-22 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 10:05 [Patch] BaseTools: Add parameter check for the AsciiStringToUint64 Feng, Bob C
2019-02-22 15:48 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3E6287@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox