public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch 1/2] BaseTools: Eot failed when enable python3
Date: Mon, 25 Feb 2019 13:23:56 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3E741A@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190225092226.15828-1-bob.c.feng@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Feng, Bob C
> Sent: Monday, February 25, 2019 5:22 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch 1/2] BaseTools: Eot failed when enable python3
> 
> The Eot will report error when python3 enabled.
> We replaced sdict with collections.OrderedDict in python3
> patch set, but the sdict implement "append" method which is not
> implemented in collections.OrderedDict.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  BaseTools/Source/Python/Eot/EotMain.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/Eot/EotMain.py b/BaseTools/Source/Python/Eot/EotMain.py
> index 56aa48d2a1..3020f6525e 100644
> --- a/BaseTools/Source/Python/Eot/EotMain.py
> +++ b/BaseTools/Source/Python/Eot/EotMain.py
> @@ -1103,11 +1103,11 @@ class MultipleFv(FirmwareVolume):
> 
>              Fv = FirmwareVolume(FvName)
>              Fv.frombuffer(Buf, 0, len(Buf))
> 
>              self.BasicInfo.append([Fv.Name, Fv.FileSystemGuid, Fv.Size])
> -            self.FfsDict.append(Fv.FfsDict)
> +            self.FfsDict.update(Fv.FfsDict)
> 
>  ## Class Eot
>  #
>  # This class is used to define Eot main entrance
>  #
> --
> 2.20.1.windows.1



      reply	other threads:[~2019-02-25 13:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25  9:22 [Patch 1/2] BaseTools: Eot failed when enable python3 Feng, Bob C
2019-02-25 13:23 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E3E741A@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox