From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C4ABE2194EB75 for ; Wed, 27 Feb 2019 17:12:58 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2019 17:12:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,421,1544515200"; d="scan'208";a="147911982" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 27 Feb 2019 17:12:57 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 27 Feb 2019 17:12:56 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 27 Feb 2019 17:12:56 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.74]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.57]) with mapi id 14.03.0415.000; Thu, 28 Feb 2019 09:12:55 +0800 From: "Gao, Liming" To: Laszlo Ersek , edk2-devel-01 CC: "Kinney, Michael D" Thread-Topic: [edk2] [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities Thread-Index: AQHUzuKCjOjUVLFMMUOcqCxVvTfkuqX0Z62w Date: Thu, 28 Feb 2019 01:12:54 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3F4485@SHSMSX104.ccr.corp.intel.com> References: <20190227212157.20107-1-lersek@redhat.com> In-Reply-To: <20190227212157.20107-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 01:12:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Thursday, February 28, 2019 5:22 AM >To: edk2-devel-01 >Cc: Gao, Liming ; Kinney, Michael D > >Subject: [edk2] [PATCH] Maintainers.txt: clarify Reviewer requirements and >responsibilities > >The current language for "Package Reviewer" only vaguely hints that >Package Reviewers should be able to provide guidance and directions. >Make this more obvious. > >Cc: Andrew Fish >Cc: Ard Biesheuvel >Cc: Leif Lindholm >Cc: Liming Gao >Cc: Michael D Kinney >Cc: Philippe Mathieu-Daude >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Laszlo Ersek >--- > >Notes: > - this is clearly a political patch; feel free to disagree > - I'm proposing this for the next development cycle > > Maintainers.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/Maintainers.txt b/Maintainers.txt >index 7772926b2fb1..ed090aeb4bdb 100644 >--- a/Maintainers.txt >+++ b/Maintainers.txt >@@ -20,7 +20,10 @@ Descriptions of section entries: > M: Package Maintainer: Cc address for patches and questions. Responsibl= e > for reviewing and pushing package changes to source control. > R: Package Reviewer: Cc address for patches and questions. Reviewers he= lp >- maintainers review code, but don't have push access. >+ maintainers review code, but don't have push access. A designated >Package >+ Reviewer is reasonably familiar with the Package (or some modules >+ thereof), and/or provides testing or regression testing for the Pack= age >+ (or some modules thereof), in certain platforms and environments. > W: Web-page with status/info > T: SCM tree type and location. Type is one of: git, svn. > S: Status, one of the following: >-- >2.19.1.3.g30247aa5d201 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel