[edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[Gao, Liming]

Hi, all
  https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning lists edk2-stable201903 tag planning. Now, we enter into Soft Feature Freeze phase. In this phase, the feature without Reviewed-by or Acked-by tags will be delayed after the upcoming stable tag. The patch review can continue without break. Below is edk2-stable201903 tag planning.

2019-03-08 Beginning of development
2019-02-22 Soft Feature Freeze
2019-03-01 Hard Feature Freeze
2019-03-08 Release

Thanks
Liming

Re: [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[Laszlo Ersek]

Hi Liming,

On 02/22/19 15:25, Gao, Liming wrote:
> Hi, all
>   https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning lists edk2-stable201903 tag planning. Now, we enter into Soft Feature Freeze phase. In this phase, the feature without Reviewed-by or Acked-by tags will be delayed after the upcoming stable tag. The patch review can continue without break. Below is edk2-stable201903 tag planning.
> 
> 2019-03-08 Beginning of development
> 2019-02-22 Soft Feature Freeze
> 2019-03-01 Hard Feature Freeze
> 2019-03-08 Release

I got the last missing R-b from Ray for my patch set

[edk2] [PATCH v3 0/5] MdeModulePkg, OvmfPkg, ArmVirtPkg: more visible
boot progress reporting

today (2019-02-22) at 12:50 in my time zone (CET = UTC+01:00). Before
pushing the series, I asked Ray to confirm one last thing about his
review. I consider the series properly reviewed, but due to this last
question, I expect I should push it early next week.

IMO that satisfies the soft feature freeze definition:

https://github.com/tianocore/tianocore.github.io/wiki/SoftFeatureFreeze

"By the date of the soft feature freeze, developers must have sent their
patches to the mailing list and received positive maintainer reviews
(Reviewed-by or Acked-by tags). [...] Between the soft feature freeze
and the hard feature freeze, previously reviewed and unit-tested
features may be applied (or merged) to the master branch, for
integration testing."

Do you (and others) agree?

If not, I won't insist -- while I'd certainly prefer these patches to be
in the upcoming stable tag, if the community perceives it would mean
bending the rules, I wouldn't want to do that. (Right now I don't think
it would bend the rules).

Thanks,
Laszlo

Re: [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[Gao, Liming]

Lazlo:
  I agree. I don't think there is the rule break for the patch set of boot progress reporting. I also prefer to push them early next week. 

Thanks
Liming
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Saturday, February 23, 2019 4:20 AM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903
> 
> Hi Liming,
> 
> On 02/22/19 15:25, Gao, Liming wrote:
> > Hi, all
> >   https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning lists edk2-stable201903 tag planning. Now, we enter
> into Soft Feature Freeze phase. In this phase, the feature without Reviewed-by or Acked-by tags will be delayed after the upcoming stable
> tag. The patch review can continue without break. Below is edk2-stable201903 tag planning.
> >
> > 2019-03-08 Beginning of development
> > 2019-02-22 Soft Feature Freeze
> > 2019-03-01 Hard Feature Freeze
> > 2019-03-08 Release
> 
> I got the last missing R-b from Ray for my patch set
> 
> [edk2] [PATCH v3 0/5] MdeModulePkg, OvmfPkg, ArmVirtPkg: more visible
> boot progress reporting
> 
> today (2019-02-22) at 12:50 in my time zone (CET = UTC+01:00). Before
> pushing the series, I asked Ray to confirm one last thing about his
> review. I consider the series properly reviewed, but due to this last
> question, I expect I should push it early next week.
> 
> IMO that satisfies the soft feature freeze definition:
> 
> https://github.com/tianocore/tianocore.github.io/wiki/SoftFeatureFreeze
> 
> "By the date of the soft feature freeze, developers must have sent their
> patches to the mailing list and received positive maintainer reviews
> (Reviewed-by or Acked-by tags). [...] Between the soft feature freeze
> and the hard feature freeze, previously reviewed and unit-tested
> features may be applied (or merged) to the master branch, for
> integration testing."
> 
> Do you (and others) agree?
> 
> If not, I won't insist -- while I'd certainly prefer these patches to be
> in the upcoming stable tag, if the community perceives it would mean
> bending the rules, I wouldn't want to do that. (Right now I don't think
> it would bend the rules).
> 
> Thanks,
> Laszlo

Re: [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[Laszlo Ersek]

On 02/23/19 15:46, Gao, Liming wrote:
> Lazlo:
>   I agree. I don't think there is the rule break for the patch set of boot progress reporting. I also prefer to push them early next week. 

Thank you, I just pushed the series.

https://lists.01.org/pipermail/edk2-devel/2019-February/037212.html

Laszlo

Re: [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[Gao, Liming]

Hi, all
  Two features (Add SMM CET support and Add WiFi Connection Manager) get Acked-By or Reviewed-by near the soft feature freeze date. CET is X86 specific feature. WiFi connection manager is the standalone feature. Their impact should be small. So, I suggest to include them in this stable tag edk2-stable201903. If you have different opinion, please raise. If no objection, I will push them late this week. 

Add SMM CET support https://lists.01.org/pipermail/edk2-devel/2019-February/037128.html
NetworkPkg: Add WiFi Connection Manager to NetworkPkg https://lists.01.org/pipermail/edk2-devel/2019-February/037137.html

Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao, Liming
> Sent: Friday, February 22, 2019 10:26 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903
> 
> Hi, all
>   https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning lists edk2-stable201903 tag planning. Now, we enter
> into Soft Feature Freeze phase. In this phase, the feature without Reviewed-by or Acked-by tags will be delayed after the upcoming stable
> tag. The patch review can continue without break. Below is edk2-stable201903 tag planning.
> 
> 2019-03-08 Beginning of development
> 2019-02-22 Soft Feature Freeze
> 2019-03-01 Hard Feature Freeze
> 2019-03-08 Release
> 
> Thanks
> Liming
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[Laszlo Ersek]

On 02/26/19 04:30, Gao, Liming wrote:
> Hi, all
>   Two features (Add SMM CET support and Add WiFi Connection Manager) get Acked-By or Reviewed-by near the soft feature freeze date. CET is X86 specific feature. WiFi connection manager is the standalone feature. Their impact should be small. So, I suggest to include them in this stable tag edk2-stable201903. If you have different opinion, please raise. If no objection, I will push them late this week. 
> 
> Add SMM CET support https://lists.01.org/pipermail/edk2-devel/2019-February/037128.html
> NetworkPkg: Add WiFi Connection Manager to NetworkPkg https://lists.01.org/pipermail/edk2-devel/2019-February/037137.html

I think the required feedback tags arrived on time, but just barely. (At
least in my time zone, CET = UTC+01:00.)

- For Jiewen's "[edk2] [PATCH V3 0/4] Add SMM CET support":
  - Ray's R-b appeared at 02/22/19 15:29
  - My Regression-tested-by appeared at 02/22/19 22:41

- For Wang Fan's "[edk2] [Patch V2] NetworkPkg: Add WiFi Connection
  Manager to NetworkPkg":
  - Jiaxin's R-b appeared at 02/22/19 08:56.

I'm OK if both features are pushed.


However, I do have a suggestion for the announcement email, for the
future. Given that we've already encountered three cases in this cycle
where the feedback tags are on the boundary, I suggest to include an
exact timestamp (in the UTC zone) in each announcement. I never expected
that this accuracy would be necessary, but apparently it is.

Thanks!
Laszlo

Re: [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[Gao, Liming]

Laszlo:

Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
> Sent: Tuesday, February 26, 2019 7:55 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903
> 
> On 02/26/19 04:30, Gao, Liming wrote:
> > Hi, all
> >   Two features (Add SMM CET support and Add WiFi Connection Manager) get Acked-By or Reviewed-by near the soft feature freeze
> date. CET is X86 specific feature. WiFi connection manager is the standalone feature. Their impact should be small. So, I suggest to include
> them in this stable tag edk2-stable201903. If you have different opinion, please raise. If no objection, I will push them late this week.
> >
> > Add SMM CET support https://lists.01.org/pipermail/edk2-devel/2019-February/037128.html
> > NetworkPkg: Add WiFi Connection Manager to NetworkPkg https://lists.01.org/pipermail/edk2-devel/2019-February/037137.html
> 
> I think the required feedback tags arrived on time, but just barely. (At
> least in my time zone, CET = UTC+01:00.)
> 
> - For Jiewen's "[edk2] [PATCH V3 0/4] Add SMM CET support":
>   - Ray's R-b appeared at 02/22/19 15:29
>   - My Regression-tested-by appeared at 02/22/19 22:41
> 
> - For Wang Fan's "[edk2] [Patch V2] NetworkPkg: Add WiFi Connection
>   Manager to NetworkPkg":
>   - Jiaxin's R-b appeared at 02/22/19 08:56.
> 
> I'm OK if both features are pushed.
> 
Thanks.

> 
> However, I do have a suggestion for the announcement email, for the
> future. Given that we've already encountered three cases in this cycle
> where the feedback tags are on the boundary, I suggest to include an
> exact timestamp (in the UTC zone) in each announcement. I never expected
> that this accuracy would be necessary, but apparently it is.
> 
I suggest to list UTC zone in Proposed Schedule of EDK II Release Planning wiki page as below. I prefer to use PST (UST -8), because edk2-devel Archives (https://lists.01.org/pipermail/edk2-devel/) uses PST time. Then, we can base on the archive mail to check each patch. 

Date (UTC -8)	Description
2019-03-08 Beginning of development
2019-02-22 Soft Feature Freeze
2019-03-01 Hard Feature Freeze
2019-03-08 Release

> Thanks!
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[Laszlo Ersek]

On 02/27/19 14:16, Gao, Liming wrote:
> Laszlo:
> 
> Thanks
> Liming
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
>> Sent: Tuesday, February 26, 2019 7:55 PM
>> To: Gao, Liming <liming.gao@intel.com>
>> Cc: edk2-devel@lists.01.org
>> Subject: Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903
>>
>> On 02/26/19 04:30, Gao, Liming wrote:
>>> Hi, all
>>>   Two features (Add SMM CET support and Add WiFi Connection Manager) get Acked-By or Reviewed-by near the soft feature freeze
>> date. CET is X86 specific feature. WiFi connection manager is the standalone feature. Their impact should be small. So, I suggest to include
>> them in this stable tag edk2-stable201903. If you have different opinion, please raise. If no objection, I will push them late this week.
>>>
>>> Add SMM CET support https://lists.01.org/pipermail/edk2-devel/2019-February/037128.html
>>> NetworkPkg: Add WiFi Connection Manager to NetworkPkg https://lists.01.org/pipermail/edk2-devel/2019-February/037137.html
>>
>> I think the required feedback tags arrived on time, but just barely. (At
>> least in my time zone, CET = UTC+01:00.)
>>
>> - For Jiewen's "[edk2] [PATCH V3 0/4] Add SMM CET support":
>>   - Ray's R-b appeared at 02/22/19 15:29
>>   - My Regression-tested-by appeared at 02/22/19 22:41
>>
>> - For Wang Fan's "[edk2] [Patch V2] NetworkPkg: Add WiFi Connection
>>   Manager to NetworkPkg":
>>   - Jiaxin's R-b appeared at 02/22/19 08:56.
>>
>> I'm OK if both features are pushed.
>>
> Thanks.
> 
>>
>> However, I do have a suggestion for the announcement email, for the
>> future. Given that we've already encountered three cases in this cycle
>> where the feedback tags are on the boundary, I suggest to include an
>> exact timestamp (in the UTC zone) in each announcement. I never expected
>> that this accuracy would be necessary, but apparently it is.
>>
> I suggest to list UTC zone in Proposed Schedule of EDK II Release Planning wiki page as below. I prefer to use PST (UST -8), because edk2-devel Archives (https://lists.01.org/pipermail/edk2-devel/) uses PST time. Then, we can base on the archive mail to check each patch. 
> 
> Date (UTC -8)	Description
> 2019-03-08 Beginning of development
> 2019-02-22 Soft Feature Freeze
> 2019-03-01 Hard Feature Freeze
> 2019-03-08 Release

I think PST (UTC-8) works fine as well, as long as we state it clearly.
Given the time zone, the timestamp is unique, and can be translated to
other time zones.

I do recommend that we specify "midnight" or 00:00:00 as well, however,
if that is our intent. (I'm fine with other hours too, such as "noon"
etc, but it should be specific down to the second. We should be able to
look at any email on the list and determine if it was before or after.
"Equal" should still be accepted.)

Thanks
Laszlo

Re: [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[Gao, Liming]

Laszlo:

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Laszlo Ersek
>Sent: Thursday, February 28, 2019 3:54 AM
>To: Gao, Liming <liming.gao@intel.com>
>Cc: edk2-devel@lists.01.org
>Subject: Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for
>edk2-stable201903
>
>On 02/27/19 14:16, Gao, Liming wrote:
>> Laszlo:
>>
>> Thanks
>> Liming
>>> -----Original Message-----
>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Laszlo Ersek
>>> Sent: Tuesday, February 26, 2019 7:55 PM
>>> To: Gao, Liming <liming.gao@intel.com>
>>> Cc: edk2-devel@lists.01.org
>>> Subject: Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for
>edk2-stable201903
>>>
>>> On 02/26/19 04:30, Gao, Liming wrote:
>>>> Hi, all
>>>>   Two features (Add SMM CET support and Add WiFi Connection Manager)
>get Acked-By or Reviewed-by near the soft feature freeze
>>> date. CET is X86 specific feature. WiFi connection manager is the
>standalone feature. Their impact should be small. So, I suggest to include
>>> them in this stable tag edk2-stable201903. If you have different opinion,
>please raise. If no objection, I will push them late this week.
>>>>
>>>> Add SMM CET support https://lists.01.org/pipermail/edk2-devel/2019-
>February/037128.html
>>>> NetworkPkg: Add WiFi Connection Manager to NetworkPkg
>https://lists.01.org/pipermail/edk2-devel/2019-February/037137.html
>>>
>>> I think the required feedback tags arrived on time, but just barely. (At
>>> least in my time zone, CET = UTC+01:00.)
>>>
>>> - For Jiewen's "[edk2] [PATCH V3 0/4] Add SMM CET support":
>>>   - Ray's R-b appeared at 02/22/19 15:29
>>>   - My Regression-tested-by appeared at 02/22/19 22:41
>>>
>>> - For Wang Fan's "[edk2] [Patch V2] NetworkPkg: Add WiFi Connection
>>>   Manager to NetworkPkg":
>>>   - Jiaxin's R-b appeared at 02/22/19 08:56.
>>>
>>> I'm OK if both features are pushed.
>>>
>> Thanks.
I push these two features. 
CET feature: 84110bbe4bb3a346514b9bb12eadb7586bca7dfd..3eb69b081c683f9d825930d0c511e43c0485e5d2
Wifi Conncetion: 90b24889f9ced53c18b73266d507e45fbd94fab0

>>
>>>
>>> However, I do have a suggestion for the announcement email, for the
>>> future. Given that we've already encountered three cases in this cycle
>>> where the feedback tags are on the boundary, I suggest to include an
>>> exact timestamp (in the UTC zone) in each announcement. I never
>expected
>>> that this accuracy would be necessary, but apparently it is.
>>>
>> I suggest to list UTC zone in Proposed Schedule of EDK II Release Planning
>wiki page as below. I prefer to use PST (UST -8), because edk2-devel Archives
>(https://lists.01.org/pipermail/edk2-devel/) uses PST time. Then, we can base
>on the archive mail to check each patch.
>>
>> Date (UTC -8)	Description
>> 2019-03-08 Beginning of development
>> 2019-02-22 Soft Feature Freeze
>> 2019-03-01 Hard Feature Freeze
>> 2019-03-08 Release
>
>I think PST (UTC-8) works fine as well, as long as we state it clearly.
>Given the time zone, the timestamp is unique, and can be translated to
>other time zones.
>
>I do recommend that we specify "midnight" or 00:00:00 as well, however,
>if that is our intent. (I'm fine with other hours too, such as "noon"
>etc, but it should be specific down to the second. We should be able to
>look at any email on the list and determine if it was before or after.
>"Equal" should still be accepted.)
>
I update wiki page https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning with UTC zone. 
I think the nature time of day is the begin time of one day. 00:00:00 should be common sense. We may not highlight it. 

>Thanks
>Laszlo
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[Laszlo Ersek]

On 02/28/19 03:22, Gao, Liming wrote:

> I update wiki page https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning with UTC zone. 
> I think the nature time of day is the begin time of one day. 00:00:00 should be common sense. We may not highlight it. 

I disagree: many organizations use "start of business" (e.g. 9AM) or
"end of business" (e.g. 5PM) as "common sense" deadlines, on any given date.

I think it's a really simple update. Just replace, in the header,

  Date(UTC-8)

with

  Date (00:00:00 UTC-8)

That should suffice.

Thanks
Laszlo

Re: [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[Gao, Liming]

OK. To be clear, I take your suggestion. wiki page has been updated. 

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, February 28, 2019 7:58 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903
> 
> On 02/28/19 03:22, Gao, Liming wrote:
> 
> > I update wiki page https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning with UTC zone.
> > I think the nature time of day is the begin time of one day. 00:00:00 should be common sense. We may not highlight it.
> 
> I disagree: many organizations use "start of business" (e.g. 9AM) or
> "end of business" (e.g. 5PM) as "common sense" deadlines, on any given date.
> 
> I think it's a really simple update. Just replace, in the header,
> 
>   Date(UTC-8)
> 
> with
> 
>   Date (00:00:00 UTC-8)
> 
> That should suffice.
> 
> Thanks
> Laszlo

Re: [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

[Laszlo Ersek]

On 03/01/19 02:15, Gao, Liming wrote:
> OK. To be clear, I take your suggestion. wiki page has been updated. 

Looks great, thank you!
Laszlo

> 
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Thursday, February 28, 2019 7:58 PM
>> To: Gao, Liming <liming.gao@intel.com>
>> Cc: edk2-devel@lists.01.org
>> Subject: Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903
>>
>> On 02/28/19 03:22, Gao, Liming wrote:
>>
>>> I update wiki page https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning with UTC zone.
>>> I think the nature time of day is the begin time of one day. 00:00:00 should be common sense. We may not highlight it.
>>
>> I disagree: many organizations use "start of business" (e.g. 9AM) or
>> "end of business" (e.g. 5PM) as "common sense" deadlines, on any given date.
>>
>> I think it's a really simple update. Just replace, in the header,
>>
>>   Date(UTC-8)
>>
>> with
>>
>>   Date (00:00:00 UTC-8)
>>
>> That should suffice.
>>
>> Thanks
>> Laszlo