public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
	"Andrew J. Hutton" <andrew.john.hutton@gmail.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: F29 Build Issue.
Date: Thu, 14 Mar 2019 17:04:42 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4038FA@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <83767b8d-3e1c-f803-e3b2-7481655d2c4d@redhat.com>

This is seemly deprecated https://github.com/tianocore/buildtools-BaseTools. We should use BaseTools in https://github.com/tianocore/edk2.

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
> Sent: Thursday, March 14, 2019 2:34 AM
> To: Andrew J. Hutton <andrew.john.hutton@gmail.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] F29 Build Issue.
> 
> On 03/13/19 14:27, Andrew J. Hutton wrote:
> > Unsure if this is a missing build dependency (since there doesn't appear
> > to be a check for this) am I missing a make dep or configure step
> > somewhere?
> >
> > This is stock F29, following the website instructions; the make -C
> > BaseTools/Source/C results in the following errror:
> >
> > make[1]: Entering directory
> > '/home/ajh/KVM/Clover/edk2/BaseTools/Source/C/GenVtf'
> > cc  -c -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror
> > -Wno-deprecated-declarations -nostdlib -c -g  -I .. -I ../Include/Common
> > -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I .
> > -I ../Include/X64/  GenVtf.c -o GenVtf.o
> > GenVtf.c: In function ‘CreateFitTableAndInitialize’:
> > GenVtf.c:1473:3: error: ‘strncpy’ output truncated before terminating
> > nul copying 8 bytes from a string of the same length
> > [-Werror=stringop-truncation]
> >    strncpy ((CHAR8 *) &FitStartPtr->CompAddress, FIT_SIGNATURE, 8);  //
> > "_FIT_ "
> >    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> > make[1]: *** [../Makefiles/footer.makefile:27: GenVtf.o] Error 1
> > make[1]: Leaving directory
> > '/home/ajh/KVM/Clover/edk2/BaseTools/Source/C/GenVtf'
> > make: *** [GNUmakefile:73: GenVtf] Error 2
> > make: Leaving directory '/home/ajh/KVM/Clover/edk2/BaseTools/Source/C'
> 
> The edk2 codebase that you are consuming is too old. The above symptom
> should not be present since commit 1d212a83df0e
> ("BaseTools/header.makefile: add "-Wno-stringop-truncation"", 2018-03-05).
> 
> The command line you quoted also misses "-Wno-unused-result", so I think
> you must be missing commit 202726b3ceb3 ("BaseTools Makefile: Enable O2
> option for GCC tool chain", 2016-10-08) as well.
> 
> I assume clover still uses an edk2 checkout that's 2.5+ years old at
> this point.
> 
> Thanks,
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

      reply	other threads:[~2019-03-14 17:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 13:27 F29 Build Issue Andrew J. Hutton
2019-03-13 14:02 ` Ryszard Knop
2019-03-13 14:11 ` Andrew Fish
2019-03-14  9:34 ` Laszlo Ersek
2019-03-14 17:04   ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4038FA@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox