[PATCH] MdePkg/PciSegmentLibSegmentInfo: Change parameters type

[PATCH] MdePkg/PciSegmentLibSegmentInfo: Change parameters type

[Shenglei Zhang]

The current structure can lead to dependency on VC++ compiler support
functions when build for "IA32" with "/Od" switch, such as _aullshr().
So change the type of parameters in structure
PCI_SEGMENT_LIB_ADDRESS_STRUCTURE from UINT64 to UINT32.
https://bugzilla.tianocore.org/show_bug.cgi?id=1532

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .../PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
index e0bdb16911..1cac6488cc 100644
--- a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
+++ b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
@@ -17,13 +17,13 @@
 #include "PciSegmentLibCommon.h"
 
 typedef struct {
-  UINT64  Register : 12;
-  UINT64  Function : 3;
-  UINT64  Device : 5;
-  UINT64  Bus : 8;
-  UINT64  Reserved1 : 4;
-  UINT64  Segment : 16;
-  UINT64  Reserved2 : 16;
+  UINT32  Register : 12;
+  UINT32  Function : 3;
+  UINT32  Device : 5;
+  UINT32  Bus : 8;
+  UINT32  Reserved1 : 4;
+  UINT32  Segment : 16;
+  UINT32  Reserved2 : 16;
 } PCI_SEGMENT_LIB_ADDRESS_STRUCTURE;
 
 /**
-- 
2.18.0.windows.1

Re: [PATCH] MdePkg/PciSegmentLibSegmentInfo: Change parameters type

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Tuesday, March 12, 2019 8:45 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdePkg/PciSegmentLibSegmentInfo: Change parameters type
> 
> The current structure can lead to dependency on VC++ compiler support
> functions when build for "IA32" with "/Od" switch, such as _aullshr().
> So change the type of parameters in structure
> PCI_SEGMENT_LIB_ADDRESS_STRUCTURE from UINT64 to UINT32.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1532
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .../PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
> b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
> index e0bdb16911..1cac6488cc 100644
> --- a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
> +++ b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
> @@ -17,13 +17,13 @@
>  #include "PciSegmentLibCommon.h"
> 
>  typedef struct {
> -  UINT64  Register : 12;
> -  UINT64  Function : 3;
> -  UINT64  Device : 5;
> -  UINT64  Bus : 8;
> -  UINT64  Reserved1 : 4;
> -  UINT64  Segment : 16;
> -  UINT64  Reserved2 : 16;
> +  UINT32  Register : 12;
> +  UINT32  Function : 3;
> +  UINT32  Device : 5;
> +  UINT32  Bus : 8;
> +  UINT32  Reserved1 : 4;
> +  UINT32  Segment : 16;
> +  UINT32  Reserved2 : 16;
>  } PCI_SEGMENT_LIB_ADDRESS_STRUCTURE;
> 
>  /**
> --
> 2.18.0.windows.1