From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 89AF1211DDA21 for ; Thu, 14 Mar 2019 15:19:49 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 15:19:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,479,1544515200"; d="scan'208";a="282782079" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 14 Mar 2019 15:19:48 -0700 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 15:19:48 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 15:19:47 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.74]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.26]) with mapi id 14.03.0415.000; Fri, 15 Mar 2019 06:19:45 +0800 From: "Gao, Liming" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" Thread-Topic: [PATCH] MdePkg/PciSegmentLibSegmentInfo: Change parameters type Thread-Index: AQHU2U8X2xMjmYsOm0mwB4IxMUDIbqYLtStA Date: Thu, 14 Mar 2019 22:19:44 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E403C0B@SHSMSX104.ccr.corp.intel.com> References: <20190313034438.14404-1-shenglei.zhang@intel.com> In-Reply-To: <20190313034438.14404-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2Y4NDk0YTEtMzJmZC00ZTgxLTliMGYtOTcyNjc0MGRmMzExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoialZDVEhTeDdoRXgySk5KZUF2M0pkUlFTZldSNSt6eE5Xc1dDWUJHb1JFMU5qRjE2enpUVFlLQXRKQXdJbjBOYSJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg/PciSegmentLibSegmentInfo: Change parameters type X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 22:19:49 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Zhang, Shenglei > Sent: Tuesday, March 12, 2019 8:45 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > Subject: [PATCH] MdePkg/PciSegmentLibSegmentInfo: Change parameters type >=20 > The current structure can lead to dependency on VC++ compiler support > functions when build for "IA32" with "/Od" switch, such as _aullshr(). > So change the type of parameters in structure > PCI_SEGMENT_LIB_ADDRESS_STRUCTURE from UINT64 to UINT32. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1532 >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > .../PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.= c > b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c > index e0bdb16911..1cac6488cc 100644 > --- a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c > +++ b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c > @@ -17,13 +17,13 @@ > #include "PciSegmentLibCommon.h" >=20 > typedef struct { > - UINT64 Register : 12; > - UINT64 Function : 3; > - UINT64 Device : 5; > - UINT64 Bus : 8; > - UINT64 Reserved1 : 4; > - UINT64 Segment : 16; > - UINT64 Reserved2 : 16; > + UINT32 Register : 12; > + UINT32 Function : 3; > + UINT32 Device : 5; > + UINT32 Bus : 8; > + UINT32 Reserved1 : 4; > + UINT32 Segment : 16; > + UINT32 Reserved2 : 16; > } PCI_SEGMENT_LIB_ADDRESS_STRUCTURE; >=20 > /** > -- > 2.18.0.windows.1