From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3A56E211E2EE9 for ; Sun, 31 Mar 2019 18:17:04 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2019 18:17:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,294,1549958400"; d="scan'208";a="312014981" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 31 Mar 2019 18:17:03 -0700 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 31 Mar 2019 18:17:02 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 31 Mar 2019 18:17:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.139]) with mapi id 14.03.0415.000; Mon, 1 Apr 2019 09:17:00 +0800 From: "Gao, Liming" To: "Gao, Zhichao" , "edk2-devel@lists.01.org" CC: Bret Barkelew , "Wu, Hao A" , "Justen, Jordan L" , "Michael Turner" , "Kinney, Michael D" , Laszlo Ersek , "Zeng, Star" Thread-Topic: [edk2] [PATCH V7 00/17] Add new APIs DebugVPrint for DebugLib Thread-Index: AQHU6CeKPrNqhiN1s0CUUaxy2LJdLKYmgNsg Date: Mon, 1 Apr 2019 01:17:00 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E417680@SHSMSX104.ccr.corp.intel.com> References: <20190401010821.6244-1-zhichao.gao@intel.com> In-Reply-To: <20190401010821.6244-1-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH V7 00/17] Add new APIs DebugVPrint for DebugLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 01:17:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao for this serial. >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Zhichao Gao >Sent: Monday, April 01, 2019 9:08 AM >To: edk2-devel@lists.01.org >Cc: Bret Barkelew ; Wu, Hao A >; Justen, Jordan L ; >Michael Turner ; Gao, Liming >; Kinney, Michael D ; >Laszlo Ersek ; Zeng, Star >Subject: [edk2] [PATCH V7 00/17] Add new APIs DebugVPrint for DebugLib > >Add a new API DebugVPrint to all the instances of DebugLib. >This API is added to provide a function who want to implement >special debug function with '...' parameter. >Add a PEIM to install gEdkiiDebugPpiGuid, and implement a PEI >debug library instance base on it. All PEIMs except pei core >type can use the PeiDebugLibDebugPpi to reduce its image size. > >V2: >Remove redundant code in DebugPrint. >Fix some coding sytle issues. >Remove some unenforced descirption in the comments of DebugVPrint. > >V3: >Add the new API DebugBPrint, it is more useful for consumers which >are care of compatible issue. >Change the interface in gEdkiiDebugPpiGuid. VA_LIST is inappropriate >to appeared in protocol or ppi because different compilers compile >it to different type. It may be a pointer or a structure. > >V4: >Sync the implement on MdeModulePkg/PeiDxeDebugLibReportStatusCode >to >IntelFramworkModulePkg/PeiDxeDebugLibReportStatusCode. While the >format >string is too long just truncate it instead of return. >Fix and update some functions' comments. > >V5: >Correct some comments of inf file. >Put all implement into one C file for DebugServicePei. >Use the directly return instead of CpuDeadLoop in PeiDebugLibDebugPpi. >Rename the mDebugPpi to mEdkiiDebugPpi because it has a same name in >DeubServicePpi. > >V6: Changed patch 16/17 >Remove the global variable and use the local variable insteaded. >Because PEIM may run in the flash which is read only. The global variable >cannot >be changed at this situation. >Update the description of PeiDebugLibDebugPpi.inf. > >V7: Changed patch 16/17 >Generate a Breakpoint, DeadLoop, or NOP based on >PCD(PcdDebugPropertyMask) settings >while do not locate the gEdkiiDebugPpiGuid. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Zhichao Gao >Cc: Michael D Kinney >Cc: Leif Lindholm >Cc: Ard Biesheuvel >Cc: Jordan Justen >Cc: Laszlo Ersek >Cc: Chasel Chiu >Cc: Nate DeSimone >Cc: Star Zeng >Cc: Nate DeSimone >Cc: Jian J Wang >Cc: Hao Wu >Cc: Ray Ni >Cc: Liming Gao >Cc: Sean Brogan >Cc: Michael Turner >Cc: Bret Barkelew > >Bret Barkelew (13): > MdePkg/DebugLib.h: Add new APIs for DebugLib > MdePkg/BaseDebugLibNull: Add new APIs for DebugLib > MdePkg/BaseDebugLibSerialPort: Add new APIs > MdePkg/UefidebugLibConOut: Add new APIs > MdePkg/UefiDebugLibStdErr: Add new APIs > MdePkg/DxeRuntimeDebugLibSerialPort: Add new APIs > MdePkg/UefiDebuglibDebugPortProtocol: Add new APIs > ArmPkg/SemiHostingDebugLib: Add new APIs > OvmfPkg/PlatformDebugLibIoPort: Add new APIs > IntelFsp2Pkg/BaseFspDebugLibSerialPort: Add new APIs > IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs > IntelFramworkModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs > MdeModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs > >Liming Gao (1): > MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib > >Zhichao Gao (3): > MdeModulePkg: Add definitions for EDKII DEBUG PPI > MdeModulePkg: Add a PEIM to install Debug PPI > MdeModulePkg: Add PEIM and lib to dsc file > > ArmPkg/Library/SemiHostingDebugLib/DebugLib.c | 106 +++- > .../PeiDxeDebugLibReportStatusCode/DebugLib.c | 179 +++++-- > .../BaseFspDebugLibSerialPort/DebugLib.c | 103 +++- > .../BaseFspDebugLibSerialPort/DebugLib.c | 103 +++- > MdeModulePkg/Include/Ppi/Debug.h | 82 ++++ > .../Library/PeiDebugLibDebugPpi/DebugLib.c | 460 ++++++++++++++++++ > .../PeiDebugLibDebugPpi.inf | 64 +++ > .../PeiDxeDebugLibReportStatusCode/DebugLib.c | 177 +++++-- > MdeModulePkg/MdeModulePkg.dec | 3 + > MdeModulePkg/MdeModulePkg.dsc | 3 + > .../Universal/DebugServicePei/DebugService.h | 56 +++ > .../DebugServicePei/DebugServicePei.c | 100 ++++ > .../DebugServicePei/DebugServicePei.inf | 51 ++ > .../DebugServicePei/DebugServicePei.uni | 20 + > MdePkg/Include/Library/DebugLib.h | 52 +- > MdePkg/Library/BaseDebugLibNull/DebugLib.c | 56 ++- > .../Library/BaseDebugLibSerialPort/DebugLib.c | 106 +++- > .../DxeRuntimeDebugLibSerialPort/DebugLib.c | 106 +++- > MdePkg/Library/UefiDebugLibConOut/DebugLib.c | 106 +++- > .../UefiDebugLibDebugPortProtocol/DebugLib.c | 106 +++- > MdePkg/Library/UefiDebugLibStdErr/DebugLib.c | 107 +++- > .../Library/PlatformDebugLibIoPort/DebugLib.c | 106 +++- > 22 files changed, 2144 insertions(+), 108 deletions(-) > create mode 100644 MdeModulePkg/Include/Ppi/Debug.h > create mode 100644 >MdeModulePkg/Library/PeiDebugLibDebugPpi/DebugLib.c > create mode 100644 >MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf > create mode 100644 >MdeModulePkg/Universal/DebugServicePei/DebugService.h > create mode 100644 >MdeModulePkg/Universal/DebugServicePei/DebugServicePei.c > create mode 100644 >MdeModulePkg/Universal/DebugServicePei/DebugServicePei.inf > create mode 100644 >MdeModulePkg/Universal/DebugServicePei/DebugServicePei.uni > >-- >2.21.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel