From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2C6422194EB70 for ; Wed, 3 Apr 2019 04:41:15 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 04:41:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,304,1549958400"; d="scan'208";a="139629456" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 03 Apr 2019 04:41:14 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Apr 2019 04:41:14 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Apr 2019 04:41:14 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.139]) with mapi id 14.03.0415.000; Wed, 3 Apr 2019 19:41:11 +0800 From: "Gao, Liming" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" Thread-Topic: [PATCH 1/2] MdePkg/BaseIoLibIntrinsic: Remove IoLibIcc.c Thread-Index: AQHU6fdzzxO7TdI4AUCTs51lFwJWvKYqUClQ Date: Wed, 3 Apr 2019 11:41:11 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E41EA8A@SHSMSX104.ccr.corp.intel.com> References: <20190403082953.9780-1-shenglei.zhang@intel.com> <20190403082953.9780-2-shenglei.zhang@intel.com> In-Reply-To: <20190403082953.9780-2-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjY3NGRlMWItMDJiMS00YTc5LTg3NWYtMDc2YmU4ODYxNWQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYmRJZnpUbFROXC9OT25rNE9MSklXNEV5b3lMaEF0Y0E3RjhYb3VEaDNlYnpIeDNldzRoRFZsZjZRbyttQXBHQloifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/2] MdePkg/BaseIoLibIntrinsic: Remove IoLibIcc.c X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2019 11:41:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Can you also clean up BaseLib to remove the support of INTEL tool chain? > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, April 3, 2019 4:30 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > Subject: [PATCH 1/2] MdePkg/BaseIoLibIntrinsic: Remove IoLibIcc.c >=20 > As ICC tool chain will be removed, IoLibIcc.c should > also be removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1666 >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 2 - > .../BaseIoLibIntrinsicSev.inf | 2 - > MdePkg/Library/BaseIoLibIntrinsic/IoLibIcc.c | 214 ------------------ > 3 files changed, 218 deletions(-) > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibIcc.c >=20 > diff --git a/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf b/M= dePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > index eb81aab2d4..6020fe90da 100644 > --- a/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > +++ b/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > @@ -41,14 +41,12 @@ > [Sources.IA32] > IoLibGcc.c | GCC > IoLibMsc.c | MSFT > - IoLibIcc.c | INTEL > IoLib.c > Ia32/IoFifo.nasm >=20 > [Sources.X64] > IoLibGcc.c | GCC > IoLibMsc.c | MSFT > - IoLibIcc.c | INTEL > IoLib.c > X64/IoFifo.nasm >=20 > diff --git a/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf = b/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf > index da846704d5..e92b5ed94d 100644 > --- a/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf > +++ b/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf > @@ -39,14 +39,12 @@ > [Sources.IA32] > IoLibGcc.c | GCC > IoLibMsc.c | MSFT > - IoLibIcc.c | INTEL > IoLib.c > Ia32/IoFifoSev.nasm >=20 > [Sources.X64] > IoLibGcc.c | GCC > IoLibMsc.c | MSFT > - IoLibIcc.c | INTEL > IoLib.c > X64/IoFifoSev.nasm >=20 > diff --git a/MdePkg/Library/BaseIoLibIntrinsic/IoLibIcc.c b/MdePkg/Librar= y/BaseIoLibIntrinsic/IoLibIcc.c > deleted file mode 100644 > index 3036084f0c..0000000000 > --- a/MdePkg/Library/BaseIoLibIntrinsic/IoLibIcc.c > +++ /dev/null > @@ -1,214 +0,0 @@ > -/** @file > - I/O Library. This file has compiler specifics for ICC as there > - is no ANSI C standard for doing IO. > - > - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> - This program and the accompanying materials are > - licensed and made available under the terms and conditions of the BSD = License > - which accompanies this distribution. The full text of the license may= be found at > - http://opensource.org/licenses/bsd-license.php. > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR I= MPLIED. > - > -**/ > - > -#include "BaseIoLibIntrinsicInternal.h" > - > -/** > - Reads an 8-bit I/O port. > - > - Reads the 8-bit I/O port specified by Port. The 8-bit read value is re= turned. > - This function must guarantee that all I/O read and write operations ar= e > - serialized. > - > - If 8-bit I/O port operations are not supported, then ASSERT(). > - > - @param Port The I/O port to read. > - > - @return The value read. > - > -**/ > -UINT8 > -EFIAPI > -IoRead8 ( > - IN UINTN Port > - ) > -{ > - UINT8 Data; > - > - __asm { > - mov dx, word ptr [Port] > - in al, dx > - > - mov Data, al > - } > - return Data; > -} > - > -/** > - Writes an 8-bit I/O port. > - > - Writes the 8-bit I/O port specified by Port with the value specified b= y Value > - and returns Value. This function must guarantee that all I/O read and = write > - operations are serialized. > - > - If 8-bit I/O port operations are not supported, then ASSERT(). > - > - @param Port The I/O port to write. > - @param Value The value to write to the I/O port. > - > - @return The value written the I/O port. > - > -**/ > -UINT8 > -EFIAPI > -IoWrite8 ( > - IN UINTN Port, > - IN UINT8 Value > - ) > -{ > - __asm { > - mov al, byte ptr [Value] > - mov dx, word ptr [Port] > - out dx, al > - } > - return Value; > -} > - > -/** > - Reads a 16-bit I/O port. > - > - Reads the 16-bit I/O port specified by Port. The 16-bit read value is = returned. > - This function must guarantee that all I/O read and write operations ar= e > - serialized. > - > - If 16-bit I/O port operations are not supported, then ASSERT(). > - If Port is not aligned on a 16-bit boundary, then ASSERT(). > - > - @param Port The I/O port to read. > - > - @return The value read. > - > -**/ > -UINT16 > -EFIAPI > -IoRead16 ( > - IN UINTN Port > - ) > -{ > - UINT16 Data; > - > - ASSERT ((Port & 1) =3D=3D 0); > - > - __asm { > - mov dx, word ptr [Port] > - in ax, dx > - mov word ptr [Data], ax > - } > - > - return Data; > -} > - > -/** > - Writes a 16-bit I/O port. > - > - Writes the 16-bit I/O port specified by Port with the value specified = by Value > - and returns Value. This function must guarantee that all I/O read and = write > - operations are serialized. > - > - If 16-bit I/O port operations are not supported, then ASSERT(). > - If Port is not aligned on a 16-bit boundary, then ASSERT(). > - > - @param Port The I/O port to write. > - @param Value The value to write to the I/O port. > - > - @return The value written the I/O port. > - > -**/ > -UINT16 > -EFIAPI > -IoWrite16 ( > - IN UINTN Port, > - IN UINT16 Value > - ) > -{ > - ASSERT ((Port & 1) =3D=3D 0); > - > - __asm { > - mov ax, word ptr [Value] > - mov dx, word ptr [Port] > - out dx, ax > - } > - > - return Value; > -} > - > -/** > - Reads a 32-bit I/O port. > - > - Reads the 32-bit I/O port specified by Port. The 32-bit read value is = returned. > - This function must guarantee that all I/O read and write operations ar= e > - serialized. > - > - If 32-bit I/O port operations are not supported, then ASSERT(). > - If Port is not aligned on a 32-bit boundary, then ASSERT(). > - > - @param Port The I/O port to read. > - > - @return The value read. > - > -**/ > -UINT32 > -EFIAPI > -IoRead32 ( > - IN UINTN Port > - ) > -{ > - UINT32 Data; > - > - ASSERT ((Port & 3) =3D=3D 0); > - > - __asm { > - mov dx, word ptr [Port] > - in eax, dx > - mov dword ptr [Data], eax > - } > - > - return Data; > -} > - > -/** > - Writes a 32-bit I/O port. > - > - Writes the 32-bit I/O port specified by Port with the value specified = by Value > - and returns Value. This function must guarantee that all I/O read and = write > - operations are serialized. > - > - If 32-bit I/O port operations are not supported, then ASSERT(). > - If Port is not aligned on a 32-bit boundary, then ASSERT(). > - > - @param Port The I/O port to write. > - @param Value The value to write to the I/O port. > - > - @return The value written the I/O port. > - > -**/ > -UINT32 > -EFIAPI > -IoWrite32 ( > - IN UINTN Port, > - IN UINT32 Value > - ) > -{ > - ASSERT ((Port & 3) =3D=3D 0); > - > - __asm { > - mov eax, dword ptr [Value] > - mov dx, word ptr [Port] > - out dx, eax > - } > - > - return Value; > -} > - > -- > 2.18.0.windows.1