From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Mon, 08 Apr 2019 06:15:59 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 06:15:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,325,1549958400"; d="scan'208";a="334839749" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 08 Apr 2019 06:15:57 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 8 Apr 2019 06:15:57 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 8 Apr 2019 06:15:57 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.21]) with mapi id 14.03.0415.000; Mon, 8 Apr 2019 21:15:55 +0800 From: "Liming Gao" To: =?utf-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= , "rebecca@bluestop.org" CC: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output Thread-Topic: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output Thread-Index: AQHU6w+/HNubjUoiIUCLgltBqFkD6qYswR4AgAWDHwA= Date: Mon, 8 Apr 2019 13:15:54 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E42066A@SHSMSX104.ccr.corp.intel.com> References: <20190404175616.51393-1-rebecca@bluestop.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTEzN2Q2YWEtODY1ZS00NmVkLWFiMDEtMDU0NzMyNWYzZDMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYzZ1b2JkWEd3V1BMWjRqdEQ2d3BENmhVRGxuWnVUdXJXVEtnYlFhN05aYjQrWEVyUUsyUmJQOThsN3JMVmJCOSJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 UmV2aWV3ZWQtYnk6IExpbWluZyBHYW8gPGxpbWluZy5nYW9AaW50ZWwuY29tPg0KDQo+IC0tLS0t T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIFtt YWlsdG86cGhpbG1kQHJlZGhhdC5jb21dDQo+IFNlbnQ6IEZyaWRheSwgQXByaWwgNSwgMjAxOSA1 OjA1IFBNDQo+IFRvOiByZWJlY2NhQGJsdWVzdG9wLm9yZzsgR2FvLCBMaW1pbmcgPGxpbWluZy5n YW9AaW50ZWwuY29tPg0KPiBDYzogZGV2ZWxAZWRrMi5ncm91cHMuaW8NCj4gU3ViamVjdDogUmU6 IFtlZGsyLWRldmVsXSBbUEFUQ0hdIEludGVsRnJhbWV3b3JrTW9kdWxlUGtnOiBGaXggY29tbWVu dHMgYW5kIGltcHJvdmUgRTgyMCBkZWJ1ZyBvdXRwdXQNCj4gDQo+IE9uIDQvNC8xOSA3OjU2IFBN LCBSZWJlY2NhIENyYW4gdmlhIEdyb3Vwcy5JbyB3cm90ZToNCj4gPiBGaXggYSBmZXcgdHlwb3Mg aW4gTGVnYWN5Qmlvc0J1aWxkRTgyMCwgYW5kIGltcHJvdmUgdGhlIGRlYnVnIG91dHB1dCBvZg0K PiA+IHRoZSBFODIwIHRhYmxlIHRvIHBhZCB3aXRoIHplcm9zIGluc3RlYWQgb2Ygc3BhY2VzLCBy ZW1vdmUgZXh0cmEgaHlwaGVucw0KPiA+IGFuZCBkaXNwbGF5IHRoZSBtZW1vcnkgdHlwZSBpbiBk ZWNpbWFsLg0KPiA+DQo+ID4gQ29udHJpYnV0ZWQtdW5kZXI6IFRpYW5vQ29yZSBDb250cmlidXRp b24gQWdyZWVtZW50IDEuMQ0KPiA+IFNpZ25lZC1vZmYtYnk6IFJlYmVjY2EgQ3JhbiA8cmViZWNj YUBibHVlc3RvcC5vcmc+DQo+IA0KPiBSZXZpZXdlZC1ieTogUGhpbGlwcGUgTWF0aGlldS1EYXVk ZSA8cGhpbG1kQHJlZGhhdC5jb20+DQo+IA0KPiA+IC0tLQ0KPiA+ICAuLi4vQ3NtL0xlZ2FjeUJp b3NEeGUvTGVnYWN5Qm9vdFN1cHBvcnQuYyAgICAgICAgICAgICAgfCAxMCArKysrKy0tLS0tDQo+ ID4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pDQo+ID4N Cj4gPiBkaWZmIC0tZ2l0IGEvSW50ZWxGcmFtZXdvcmtNb2R1bGVQa2cvQ3NtL0xlZ2FjeUJpb3NE eGUvTGVnYWN5Qm9vdFN1cHBvcnQuYw0KPiBiL0ludGVsRnJhbWV3b3JrTW9kdWxlUGtnL0NzbS9M ZWdhY3lCaW9zRHhlL0xlZ2FjeUJvb3RTdXBwb3J0LmMNCj4gPiBpbmRleCBhN2I4ZTZhOWEwLi44 YzQxNWNkZmM2IDEwMDY0NA0KPiA+IC0tLSBhL0ludGVsRnJhbWV3b3JrTW9kdWxlUGtnL0NzbS9M ZWdhY3lCaW9zRHhlL0xlZ2FjeUJvb3RTdXBwb3J0LmMNCj4gPiArKysgYi9JbnRlbEZyYW1ld29y a01vZHVsZVBrZy9Dc20vTGVnYWN5Qmlvc0R4ZS9MZWdhY3lCb290U3VwcG9ydC5jDQo+ID4gQEAg LTE3MTEsOSArMTcxMSw5IEBAIExlZ2FjeUJpb3NCdWlsZEU4MjAgKA0KPiA+DQo+ID4gICAgZG8g ew0KPiA+ICAgICAgLy8NCj4gPiAtICAgIC8vIFVzZSBzaXplIHJldHVybmVkIGJhY2sgcGx1cyAx IGRlc2NyaXB0b3IgZm9yIHRoZSBBbGxvY2F0ZVBvb2wuDQo+ID4gKyAgICAvLyBVc2Ugc2l6ZSBy ZXR1cm5lZCBmb3IgdGhlIEFsbG9jYXRlUG9vbC4NCj4gPiAgICAgIC8vIFdlIGRvbid0IGp1c3Qg bXVsdGlwbHkgYnkgMiBzaW5jZSB0aGUgImZvciIgbG9vcCBiZWxvdyB0ZXJtaW5hdGVzIG9uDQo+ ID4gLSAgICAvLyBFZmlNZW1vcnlNYXBFbmQgd2hpY2ggaXMgZGVwZW5kZW50IHVwb24gRWZpTWVt b3J5TWFwU2l6ZS4gT3RoZXJ3aXplDQo+ID4gKyAgICAvLyBFZmlNZW1vcnlNYXBFbmQgd2hpY2gg aXMgZGVwZW5kZW50IHVwb24gRWZpTWVtb3J5TWFwU2l6ZS4gT3RoZXJ3aXNlDQo+ID4gICAgICAv LyB3ZSBwcm9jZXNzIGJvZ3VzIGVudHJpZXMgYW5kIGNyZWF0ZSBib2d1cyBFODIwIGVudHJpZXMu DQo+ID4gICAgICAvLw0KPiA+ICAgICAgRWZpTWVtb3J5TWFwID0gKEVGSV9NRU1PUllfREVTQ1JJ UFRPUiAqKSBBbGxvY2F0ZVBvb2wgKEVmaU1lbW9yeU1hcFNpemUpOw0KPiA+IEBAIC0xODAxLDcg KzE4MDEsNyBAQCBMZWdhY3lCaW9zQnVpbGRFODIwICgNCj4gPiAgICAgIE1lbW9yeUJsb2NrTGVu Z3RoID0gKFVJTlQ2NCkgKExTaGlmdFU2NCAoRWZpRW50cnktPk51bWJlck9mUGFnZXMsIDEyKSk7 DQo+ID4gICAgICBpZiAoKEVmaUVudHJ5LT5QaHlzaWNhbFN0YXJ0ICsgTWVtb3J5QmxvY2tMZW5n dGgpIDwgMHgxMDAwMDApIHsNCj4gPiAgICAgICAgLy8NCj4gPiAtICAgICAgLy8gU2tpcCB0aGUg bWVtb3J5IGJsb2NrIGlzIHVuZGVyIDFNQg0KPiA+ICsgICAgICAvLyBTa2lwIHRoZSBtZW1vcnkg YmxvY2sgaWYgdW5kZXIgMU1CDQo+ID4gICAgICAgIC8vDQo+ID4gICAgICB9IGVsc2Ugew0KPiA+ ICAgICAgICBpZiAoRWZpRW50cnktPlBoeXNpY2FsU3RhcnQgPCAweDEwMDAwMCkgew0KPiA+IEBA IC0xOTI2LDcgKzE5MjYsNyBAQCBMZWdhY3lCaW9zQnVpbGRFODIwICgNCj4gPiAgICAqU2l6ZSA9 IChVSU5UTikgKEluZGV4ICogc2l6ZW9mIChFRklfRTgyMF9FTlRSWTY0KSk7DQo+ID4NCj4gPiAg ICAvLw0KPiA+IC0gIC8vIERldGVybWluZSBPUyB1c2FibGUgbWVtb3J5IGFib3ZlIDFNYg0KPiA+ ICsgIC8vIERldGVybWluZSBPUyB1c2FibGUgbWVtb3J5IGFib3ZlIDFNQg0KPiA+ICAgIC8vDQo+ ID4gICAgUHJpdmF0ZS0+SW50VGh1bmstPkVmaVRvTGVnYWN5MTZCb290VGFibGUuT3NNZW1vcnlB Ym92ZTFNYiA9IDB4MDAwMDsNCj4gPiAgICBmb3IgKFRlbXBJbmRleCA9IEFib3ZlMU1JbmRleDsg VGVtcEluZGV4IDwgSW5kZXg7IFRlbXBJbmRleCsrKSB7DQo+ID4gQEAgLTE5NDgsNyArMTk0OCw3 IEBAIExlZ2FjeUJpb3NCdWlsZEU4MjAgKA0KPiA+ICAgIC8vIFByaW50IERFQlVHIGluZm9ybWF0 aW9uDQo+ID4gICAgLy8NCj4gPiAgICBmb3IgKFRlbXBJbmRleCA9IDA7IFRlbXBJbmRleCA8IElu ZGV4OyBUZW1wSW5kZXgrKykgew0KPiA+IC0gICAgREVCVUcoKEVGSV9EX0lORk8sICJFODIwWyUy ZF06IDB4JTE2bHggLS0tLSAweCUxNmx4LCBUeXBlID0gMHgleCBcbiIsDQo+ID4gKyAgICBERUJV RygoRUZJX0RfSU5GTywgIkU4MjBbJTJkXTogMHglMDE2bHggLSAweCUwMTZseCwgVHlwZSA9ICVk XG4iLA0KPiA+ICAgICAgICBUZW1wSW5kZXgsDQo+ID4gICAgICAgIEU4MjBUYWJsZVtUZW1wSW5k ZXhdLkJhc2VBZGRyLA0KPiA+ICAgICAgICAoRTgyMFRhYmxlW1RlbXBJbmRleF0uQmFzZUFkZHIg KyBFODIwVGFibGVbVGVtcEluZGV4XS5MZW5ndGgpLA0KPiA+DQo=