From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Wed, 10 Apr 2019 17:32:45 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 17:32:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,335,1549958400"; d="scan'208";a="149821419" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 10 Apr 2019 17:32:44 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 17:32:41 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 17:32:41 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.21]) with mapi id 14.03.0415.000; Thu, 11 Apr 2019 08:32:38 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Gao, Liming" , =?utf-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= , "rebecca@bluestop.org" Subject: Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output Thread-Topic: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output Thread-Index: AQHU6w+/HNubjUoiIUCLgltBqFkD6qYswR4AgAWDHwCAA+G7MA== Date: Thu, 11 Apr 2019 00:32:39 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E42222A@SHSMSX104.ccr.corp.intel.com> References: <20190404175616.51393-1-rebecca@bluestop.org> <1593821D7C44BA9C.31892@groups.io> In-Reply-To: <1593821D7C44BA9C.31892@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 UHVzaCBvbiBjb21taXQgZGRiOGNlZGNlN2UwN2I4N2MwYWM2Yjg0Y2Q3NTBhNmQzZGFjNDdjOA0K DQo+LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj5Gcm9tOiBkZXZlbEBlZGsyLmdyb3Vwcy5p byBbbWFpbHRvOmRldmVsQGVkazIuZ3JvdXBzLmlvXSBPbiBCZWhhbGYgT2YNCj5MaW1pbmcgR2Fv DQo+U2VudDogTW9uZGF5LCBBcHJpbCAwOCwgMjAxOSA5OjE2IFBNDQo+VG86IFBoaWxpcHBlIE1h dGhpZXUtRGF1ZMOpIDxwaGlsbWRAcmVkaGF0LmNvbT47IHJlYmVjY2FAYmx1ZXN0b3Aub3JnDQo+ Q2M6IGRldmVsQGVkazIuZ3JvdXBzLmlvDQo+U3ViamVjdDogUmU6IFtlZGsyLWRldmVsXSBbUEFU Q0hdIEludGVsRnJhbWV3b3JrTW9kdWxlUGtnOiBGaXggY29tbWVudHMNCj5hbmQgaW1wcm92ZSBF ODIwIGRlYnVnIG91dHB1dA0KPg0KPlJldmlld2VkLWJ5OiBMaW1pbmcgR2FvIDxsaW1pbmcuZ2Fv QGludGVsLmNvbT4NCj4NCj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+PiBGcm9tOiBQ aGlsaXBwZSBNYXRoaWV1LURhdWTDqSBbbWFpbHRvOnBoaWxtZEByZWRoYXQuY29tXQ0KPj4gU2Vu dDogRnJpZGF5LCBBcHJpbCA1LCAyMDE5IDU6MDUgUE0NCj4+IFRvOiByZWJlY2NhQGJsdWVzdG9w Lm9yZzsgR2FvLCBMaW1pbmcgPGxpbWluZy5nYW9AaW50ZWwuY29tPg0KPj4gQ2M6IGRldmVsQGVk azIuZ3JvdXBzLmlvDQo+PiBTdWJqZWN0OiBSZTogW2VkazItZGV2ZWxdIFtQQVRDSF0gSW50ZWxG cmFtZXdvcmtNb2R1bGVQa2c6IEZpeA0KPmNvbW1lbnRzIGFuZCBpbXByb3ZlIEU4MjAgZGVidWcg b3V0cHV0DQo+Pg0KPj4gT24gNC80LzE5IDc6NTYgUE0sIFJlYmVjY2EgQ3JhbiB2aWEgR3JvdXBz LklvIHdyb3RlOg0KPj4gPiBGaXggYSBmZXcgdHlwb3MgaW4gTGVnYWN5Qmlvc0J1aWxkRTgyMCwg YW5kIGltcHJvdmUgdGhlIGRlYnVnIG91dHB1dCBvZg0KPj4gPiB0aGUgRTgyMCB0YWJsZSB0byBw YWQgd2l0aCB6ZXJvcyBpbnN0ZWFkIG9mIHNwYWNlcywgcmVtb3ZlIGV4dHJhIGh5cGhlbnMNCj4+ ID4gYW5kIGRpc3BsYXkgdGhlIG1lbW9yeSB0eXBlIGluIGRlY2ltYWwuDQo+PiA+DQo+PiA+IENv bnRyaWJ1dGVkLXVuZGVyOiBUaWFub0NvcmUgQ29udHJpYnV0aW9uIEFncmVlbWVudCAxLjENCj4+ ID4gU2lnbmVkLW9mZi1ieTogUmViZWNjYSBDcmFuIDxyZWJlY2NhQGJsdWVzdG9wLm9yZz4NCj4+ DQo+PiBSZXZpZXdlZC1ieTogUGhpbGlwcGUgTWF0aGlldS1EYXVkZSA8cGhpbG1kQHJlZGhhdC5j b20+DQo+Pg0KPj4gPiAtLS0NCj4+ID4gIC4uLi9Dc20vTGVnYWN5Qmlvc0R4ZS9MZWdhY3lCb290 U3VwcG9ydC5jICAgICAgICAgICAgICB8IDEwICsrKysrLS0tLS0NCj4+ID4gIDEgZmlsZSBjaGFu Z2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pDQo+PiA+DQo+PiA+IGRpZmYgLS1n aXQNCj5hL0ludGVsRnJhbWV3b3JrTW9kdWxlUGtnL0NzbS9MZWdhY3lCaW9zRHhlL0xlZ2FjeUJv b3RTdXBwb3J0LmMNCj4+IGIvSW50ZWxGcmFtZXdvcmtNb2R1bGVQa2cvQ3NtL0xlZ2FjeUJpb3NE eGUvTGVnYWN5Qm9vdFN1cHBvcnQuYw0KPj4gPiBpbmRleCBhN2I4ZTZhOWEwLi44YzQxNWNkZmM2 IDEwMDY0NA0KPj4gPiAtLS0NCj5hL0ludGVsRnJhbWV3b3JrTW9kdWxlUGtnL0NzbS9MZWdhY3lC aW9zRHhlL0xlZ2FjeUJvb3RTdXBwb3J0LmMNCj4+ID4gKysrDQo+Yi9JbnRlbEZyYW1ld29ya01v ZHVsZVBrZy9Dc20vTGVnYWN5Qmlvc0R4ZS9MZWdhY3lCb290U3VwcG9ydC5jDQo+PiA+IEBAIC0x NzExLDkgKzE3MTEsOSBAQCBMZWdhY3lCaW9zQnVpbGRFODIwICgNCj4+ID4NCj4+ID4gICAgZG8g ew0KPj4gPiAgICAgIC8vDQo+PiA+IC0gICAgLy8gVXNlIHNpemUgcmV0dXJuZWQgYmFjayBwbHVz IDEgZGVzY3JpcHRvciBmb3IgdGhlIEFsbG9jYXRlUG9vbC4NCj4+ID4gKyAgICAvLyBVc2Ugc2l6 ZSByZXR1cm5lZCBmb3IgdGhlIEFsbG9jYXRlUG9vbC4NCj4+ID4gICAgICAvLyBXZSBkb24ndCBq dXN0IG11bHRpcGx5IGJ5IDIgc2luY2UgdGhlICJmb3IiIGxvb3AgYmVsb3cgdGVybWluYXRlcyBv bg0KPj4gPiAtICAgIC8vIEVmaU1lbW9yeU1hcEVuZCB3aGljaCBpcyBkZXBlbmRlbnQgdXBvbiBF ZmlNZW1vcnlNYXBTaXplLg0KPk90aGVyd2l6ZQ0KPj4gPiArICAgIC8vIEVmaU1lbW9yeU1hcEVu ZCB3aGljaCBpcyBkZXBlbmRlbnQgdXBvbiBFZmlNZW1vcnlNYXBTaXplLg0KPk90aGVyd2lzZQ0K Pj4gPiAgICAgIC8vIHdlIHByb2Nlc3MgYm9ndXMgZW50cmllcyBhbmQgY3JlYXRlIGJvZ3VzIEU4 MjAgZW50cmllcy4NCj4+ID4gICAgICAvLw0KPj4gPiAgICAgIEVmaU1lbW9yeU1hcCA9IChFRklf TUVNT1JZX0RFU0NSSVBUT1IgKikgQWxsb2NhdGVQb29sDQo+KEVmaU1lbW9yeU1hcFNpemUpOw0K Pj4gPiBAQCAtMTgwMSw3ICsxODAxLDcgQEAgTGVnYWN5Qmlvc0J1aWxkRTgyMCAoDQo+PiA+ICAg ICAgTWVtb3J5QmxvY2tMZW5ndGggPSAoVUlOVDY0KSAoTFNoaWZ0VTY0IChFZmlFbnRyeS0+TnVt YmVyT2ZQYWdlcywNCj4xMikpOw0KPj4gPiAgICAgIGlmICgoRWZpRW50cnktPlBoeXNpY2FsU3Rh cnQgKyBNZW1vcnlCbG9ja0xlbmd0aCkgPCAweDEwMDAwMCkgew0KPj4gPiAgICAgICAgLy8NCj4+ ID4gLSAgICAgIC8vIFNraXAgdGhlIG1lbW9yeSBibG9jayBpcyB1bmRlciAxTUINCj4+ID4gKyAg ICAgIC8vIFNraXAgdGhlIG1lbW9yeSBibG9jayBpZiB1bmRlciAxTUINCj4+ID4gICAgICAgIC8v DQo+PiA+ICAgICAgfSBlbHNlIHsNCj4+ID4gICAgICAgIGlmIChFZmlFbnRyeS0+UGh5c2ljYWxT dGFydCA8IDB4MTAwMDAwKSB7DQo+PiA+IEBAIC0xOTI2LDcgKzE5MjYsNyBAQCBMZWdhY3lCaW9z QnVpbGRFODIwICgNCj4+ID4gICAgKlNpemUgPSAoVUlOVE4pIChJbmRleCAqIHNpemVvZiAoRUZJ X0U4MjBfRU5UUlk2NCkpOw0KPj4gPg0KPj4gPiAgICAvLw0KPj4gPiAtICAvLyBEZXRlcm1pbmUg T1MgdXNhYmxlIG1lbW9yeSBhYm92ZSAxTWINCj4+ID4gKyAgLy8gRGV0ZXJtaW5lIE9TIHVzYWJs ZSBtZW1vcnkgYWJvdmUgMU1CDQo+PiA+ICAgIC8vDQo+PiA+ICAgIFByaXZhdGUtPkludFRodW5r LT5FZmlUb0xlZ2FjeTE2Qm9vdFRhYmxlLk9zTWVtb3J5QWJvdmUxTWIgPQ0KPjB4MDAwMDsNCj4+ ID4gICAgZm9yIChUZW1wSW5kZXggPSBBYm92ZTFNSW5kZXg7IFRlbXBJbmRleCA8IEluZGV4OyBU ZW1wSW5kZXgrKykgew0KPj4gPiBAQCAtMTk0OCw3ICsxOTQ4LDcgQEAgTGVnYWN5Qmlvc0J1aWxk RTgyMCAoDQo+PiA+ICAgIC8vIFByaW50IERFQlVHIGluZm9ybWF0aW9uDQo+PiA+ICAgIC8vDQo+ PiA+ICAgIGZvciAoVGVtcEluZGV4ID0gMDsgVGVtcEluZGV4IDwgSW5kZXg7IFRlbXBJbmRleCsr KSB7DQo+PiA+IC0gICAgREVCVUcoKEVGSV9EX0lORk8sICJFODIwWyUyZF06IDB4JTE2bHggLS0t LSAweCUxNmx4LCBUeXBlID0gMHgleA0KPlxuIiwNCj4+ID4gKyAgICBERUJVRygoRUZJX0RfSU5G TywgIkU4MjBbJTJkXTogMHglMDE2bHggLSAweCUwMTZseCwgVHlwZSA9ICVkXG4iLA0KPj4gPiAg ICAgICAgVGVtcEluZGV4LA0KPj4gPiAgICAgICAgRTgyMFRhYmxlW1RlbXBJbmRleF0uQmFzZUFk ZHIsDQo+PiA+ICAgICAgICAoRTgyMFRhYmxlW1RlbXBJbmRleF0uQmFzZUFkZHIgKyBFODIwVGFi bGVbVGVtcEluZGV4XS5MZW5ndGgpLA0KPj4gPg0KPg0KPg0KDQo=