From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Thu, 11 Apr 2019 06:52:05 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2019 06:52:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,337,1549958400"; d="scan'208";a="149978174" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 11 Apr 2019 06:52:04 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 06:52:04 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.21]) with mapi id 14.03.0415.000; Thu, 11 Apr 2019 21:52:02 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "philmd@redhat.com" , "Kinney, Michael D" , Laszlo Ersek , "Cetola, Stephano" CC: "rebecca@bluestop.org" , Stephano Cetola Subject: Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output Thread-Topic: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output Thread-Index: AQHU6w+/HNubjUoiIUCLgltBqFkD6qYswR4AgAWDHwCAA+G7MIAAKPuAgAC1cUA= Date: Thu, 11 Apr 2019 13:52:01 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E422AE8@SHSMSX104.ccr.corp.intel.com> References: <20190404175616.51393-1-rebecca@bluestop.org> <1593821D7C44BA9C.31892@groups.io> <4A89E2EF3DFEDB4C8BFDE51014F606A14E42222A@SHSMSX104.ccr.corp.intel.com> <334bc708-2250-d4e0-9ec5-5f1c6d92c3e2@redhat.com> In-Reply-To: <334bc708-2250-d4e0-9ec5-5f1c6d92c3e2@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDhjNzEzMjYtYmM2OS00NTFkLTg2ZWUtNGNiOTQyMjAzMDZmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWG1mWDlETG1iXC9qNzZFeWo0dENUM2tUM0t5V2ZHYWFkbytjZEZLazNyVmR2RHR1eVpXQm5VVUt3bDhlV1JKYmQifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 UGhpbDoNCiAgSSB1c2UgT3V0bG9vayB0byByZWNlaXZlIHRoZSBwYXRjaCBtYWlsLCBhbmQgc2F2 ZSBhcyBtYWlsIGZpbGUuIFRoaXMgZmlsZSBzaG93cyBGcm9tOiBSZWJlY2NhIENyYW4gdmlhIEdy b3Vwcy5JbyA8cmViZWNjYT1ibHVlc3RvcC5vcmdAZ3JvdXBzLmlvPi4gU28sIEkgdXNlIGl0IGFz IHBhdGNoIGF1dGhvci4gSSBhbHNvIGNoZWNrIG15IHBhdGNoIHdpdGggdGhlIHNhbWUgd2F5LiBJ dCBzaG93cyBGcm9tOiBMaW1pbmcgR2FvIDxsaW1pbmcuZ2FvQGludGVsLmNvbT4uIFRoaXMgaXMg Y29ycmVjdC4gU28sIEkgZG9uJ3Qga25vdyB0aGlzIGlzIHVzZXIgc2V0dGluZyBpc3N1ZSBvciBn cm91cC5pbyBpc3N1ZS4gDQoNClRoYW5rcw0KTGltaW5nDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn ZS0tLS0tDQo+IEZyb206IGRldmVsQGVkazIuZ3JvdXBzLmlvIFttYWlsdG86ZGV2ZWxAZWRrMi5n cm91cHMuaW9dIE9uIEJlaGFsZiBPZiBQaGlsaXBwZSBNYXRoaWV1LURhdWTDqQ0KPiBTZW50OiBU aHVyc2RheSwgQXByaWwgMTEsIDIwMTkgNjo1OSBQTQ0KPiBUbzogR2FvLCBMaW1pbmcgPGxpbWlu Zy5nYW9AaW50ZWwuY29tPjsgS2lubmV5LCBNaWNoYWVsIEQgPG1pY2hhZWwuZC5raW5uZXlAaW50 ZWwuY29tPjsgTGFzemxvIEVyc2VrIDxsZXJzZWtAcmVkaGF0LmNvbT4NCj4gQ2M6IGRldmVsQGVk azIuZ3JvdXBzLmlvOyByZWJlY2NhQGJsdWVzdG9wLm9yZzsgU3RlcGhhbm8gQ2V0b2xhIDxzdGVw aGFuby5jZXRvbGFAbGludXguaW50ZWwuY29tPg0KPiBTdWJqZWN0OiBSZTogW2VkazItZGV2ZWxd IFtQQVRDSF0gSW50ZWxGcmFtZXdvcmtNb2R1bGVQa2c6IEZpeCBjb21tZW50cyBhbmQgaW1wcm92 ZSBFODIwIGRlYnVnIG91dHB1dA0KPiANCj4gSGkgTGltaW5nLA0KPiANCj4gT24gNC8xMS8xOSAy OjMyIEFNLCBMaW1pbmcgR2FvIHdyb3RlOg0KPiA+IFB1c2ggb24gY29tbWl0IGRkYjhjZWRjZTdl MDdiODdjMGFjNmI4NGNkNzUwYTZkM2RhYzQ3YzgNCj4gDQo+IEkgc2VlIGluIHRoZSBnaXQgaGlz dG9yeSB0aGUgYXV0aG9yc2hpcCBwYXNzZWQNCj4gZnJvbTogcmViZWNjYUBibHVlc3RvcC5vcmcg PHJlYmVjY2FAYmx1ZXN0b3Aub3JnPg0KPiB0bzogUmViZWNjYSBDcmFuIHZpYSBHcm91cHMuSW8g PHJlYmVjY2E9Ymx1ZXN0b3Aub3JnQGdyb3Vwcy5pbz4NCj4gDQo+IEkgd29uZGVyIGlmIHdlIHNo b3VsZG4ndCBibG9jayBwdXNoZXMgdW50aWwgdGhlDQo+IEJhc2VUb29scy9TY3JpcHRzL1BhdGNo Q2hlY2sucHkgdG9vbCBnZXQgZml4ZWQgdG8gYXZvaWQgc3VjaCBtaXN0YWtlcw0KPiB3aGljaCBh cmUgbGlrZWx5IHRvIGdldCByZXByb2R1Y2VkIG5vdyB0aGF0IHdlIHN3aXRjaGVkIHRvIEdyb3Vw cy5Jby4NCj4gDQo+IFRob3VnaHRzPw0KPiANCj4gUmVnYXJkcywNCj4gDQo+IFBoaWwuDQo+IA0K PiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBkZXZlbEBlZGsyLmdy b3Vwcy5pbyBbbWFpbHRvOmRldmVsQGVkazIuZ3JvdXBzLmlvXSBPbiBCZWhhbGYgT2YNCj4gPj4g TGltaW5nIEdhbw0KPiA+PiBTZW50OiBNb25kYXksIEFwcmlsIDA4LCAyMDE5IDk6MTYgUE0NCj4g Pj4gVG86IFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIDxwaGlsbWRAcmVkaGF0LmNvbT47IHJlYmVj Y2FAYmx1ZXN0b3Aub3JnDQo+ID4+IENjOiBkZXZlbEBlZGsyLmdyb3Vwcy5pbw0KPiA+PiBTdWJq ZWN0OiBSZTogW2VkazItZGV2ZWxdIFtQQVRDSF0gSW50ZWxGcmFtZXdvcmtNb2R1bGVQa2c6IEZp eCBjb21tZW50cw0KPiA+PiBhbmQgaW1wcm92ZSBFODIwIGRlYnVnIG91dHB1dA0KPiA+Pg0KPiA+ PiBSZXZpZXdlZC1ieTogTGltaW5nIEdhbyA8bGltaW5nLmdhb0BpbnRlbC5jb20+DQo+ID4+DQo+ ID4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+Pj4gRnJvbTogUGhpbGlwcGUgTWF0 aGlldS1EYXVkw6kgW21haWx0bzpwaGlsbWRAcmVkaGF0LmNvbV0NCj4gPj4+IFNlbnQ6IEZyaWRh eSwgQXByaWwgNSwgMjAxOSA1OjA1IFBNDQo+ID4+PiBUbzogcmViZWNjYUBibHVlc3RvcC5vcmc7 IEdhbywgTGltaW5nIDxsaW1pbmcuZ2FvQGludGVsLmNvbT4NCj4gPj4+IENjOiBkZXZlbEBlZGsy Lmdyb3Vwcy5pbw0KPiA+Pj4gU3ViamVjdDogUmU6IFtlZGsyLWRldmVsXSBbUEFUQ0hdIEludGVs RnJhbWV3b3JrTW9kdWxlUGtnOiBGaXgNCj4gPj4gY29tbWVudHMgYW5kIGltcHJvdmUgRTgyMCBk ZWJ1ZyBvdXRwdXQNCj4gPj4+DQo+ID4+PiBPbiA0LzQvMTkgNzo1NiBQTSwgUmViZWNjYSBDcmFu IHZpYSBHcm91cHMuSW8gd3JvdGU6DQo+ID4+Pj4gRml4IGEgZmV3IHR5cG9zIGluIExlZ2FjeUJp b3NCdWlsZEU4MjAsIGFuZCBpbXByb3ZlIHRoZSBkZWJ1ZyBvdXRwdXQgb2YNCj4gPj4+PiB0aGUg RTgyMCB0YWJsZSB0byBwYWQgd2l0aCB6ZXJvcyBpbnN0ZWFkIG9mIHNwYWNlcywgcmVtb3ZlIGV4 dHJhIGh5cGhlbnMNCj4gPj4+PiBhbmQgZGlzcGxheSB0aGUgbWVtb3J5IHR5cGUgaW4gZGVjaW1h bC4NCj4gPj4+Pg0KPiA+Pj4+IENvbnRyaWJ1dGVkLXVuZGVyOiBUaWFub0NvcmUgQ29udHJpYnV0 aW9uIEFncmVlbWVudCAxLjENCj4gPj4+PiBTaWduZWQtb2ZmLWJ5OiBSZWJlY2NhIENyYW4gPHJl YmVjY2FAYmx1ZXN0b3Aub3JnPg0KPiA+Pj4NCj4gPj4+IFJldmlld2VkLWJ5OiBQaGlsaXBwZSBN YXRoaWV1LURhdWRlIDxwaGlsbWRAcmVkaGF0LmNvbT4NCj4gPj4+DQo+ID4+Pj4gLS0tDQo+ID4+ Pj4gIC4uLi9Dc20vTGVnYWN5Qmlvc0R4ZS9MZWdhY3lCb290U3VwcG9ydC5jICAgICAgICAgICAg ICB8IDEwICsrKysrLS0tLS0NCj4gPj4+PiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygr KSwgNSBkZWxldGlvbnMoLSkNCj4gPj4+Pg0KPiA+Pj4+IGRpZmYgLS1naXQNCj4gPj4gYS9JbnRl bEZyYW1ld29ya01vZHVsZVBrZy9Dc20vTGVnYWN5Qmlvc0R4ZS9MZWdhY3lCb290U3VwcG9ydC5j DQo+ID4+PiBiL0ludGVsRnJhbWV3b3JrTW9kdWxlUGtnL0NzbS9MZWdhY3lCaW9zRHhlL0xlZ2Fj eUJvb3RTdXBwb3J0LmMNCj4gPj4+PiBpbmRleCBhN2I4ZTZhOWEwLi44YzQxNWNkZmM2IDEwMDY0 NA0KPiA+Pj4+IC0tLQ0KPiA+PiBhL0ludGVsRnJhbWV3b3JrTW9kdWxlUGtnL0NzbS9MZWdhY3lC aW9zRHhlL0xlZ2FjeUJvb3RTdXBwb3J0LmMNCj4gPj4+PiArKysNCj4gPj4gYi9JbnRlbEZyYW1l d29ya01vZHVsZVBrZy9Dc20vTGVnYWN5Qmlvc0R4ZS9MZWdhY3lCb290U3VwcG9ydC5jDQo+ID4+ Pj4gQEAgLTE3MTEsOSArMTcxMSw5IEBAIExlZ2FjeUJpb3NCdWlsZEU4MjAgKA0KPiA+Pj4+DQo+ ID4+Pj4gICAgZG8gew0KPiA+Pj4+ICAgICAgLy8NCj4gPj4+PiAtICAgIC8vIFVzZSBzaXplIHJl dHVybmVkIGJhY2sgcGx1cyAxIGRlc2NyaXB0b3IgZm9yIHRoZSBBbGxvY2F0ZVBvb2wuDQo+ID4+ Pj4gKyAgICAvLyBVc2Ugc2l6ZSByZXR1cm5lZCBmb3IgdGhlIEFsbG9jYXRlUG9vbC4NCj4gPj4+ PiAgICAgIC8vIFdlIGRvbid0IGp1c3QgbXVsdGlwbHkgYnkgMiBzaW5jZSB0aGUgImZvciIgbG9v cCBiZWxvdyB0ZXJtaW5hdGVzIG9uDQo+ID4+Pj4gLSAgICAvLyBFZmlNZW1vcnlNYXBFbmQgd2hp Y2ggaXMgZGVwZW5kZW50IHVwb24gRWZpTWVtb3J5TWFwU2l6ZS4NCj4gPj4gT3RoZXJ3aXplDQo+ ID4+Pj4gKyAgICAvLyBFZmlNZW1vcnlNYXBFbmQgd2hpY2ggaXMgZGVwZW5kZW50IHVwb24gRWZp TWVtb3J5TWFwU2l6ZS4NCj4gPj4gT3RoZXJ3aXNlDQo+ID4+Pj4gICAgICAvLyB3ZSBwcm9jZXNz IGJvZ3VzIGVudHJpZXMgYW5kIGNyZWF0ZSBib2d1cyBFODIwIGVudHJpZXMuDQo+ID4+Pj4gICAg ICAvLw0KPiA+Pj4+ICAgICAgRWZpTWVtb3J5TWFwID0gKEVGSV9NRU1PUllfREVTQ1JJUFRPUiAq KSBBbGxvY2F0ZVBvb2wNCj4gPj4gKEVmaU1lbW9yeU1hcFNpemUpOw0KPiA+Pj4+IEBAIC0xODAx LDcgKzE4MDEsNyBAQCBMZWdhY3lCaW9zQnVpbGRFODIwICgNCj4gPj4+PiAgICAgIE1lbW9yeUJs b2NrTGVuZ3RoID0gKFVJTlQ2NCkgKExTaGlmdFU2NCAoRWZpRW50cnktPk51bWJlck9mUGFnZXMs DQo+ID4+IDEyKSk7DQo+ID4+Pj4gICAgICBpZiAoKEVmaUVudHJ5LT5QaHlzaWNhbFN0YXJ0ICsg TWVtb3J5QmxvY2tMZW5ndGgpIDwgMHgxMDAwMDApIHsNCj4gPj4+PiAgICAgICAgLy8NCj4gPj4+ PiAtICAgICAgLy8gU2tpcCB0aGUgbWVtb3J5IGJsb2NrIGlzIHVuZGVyIDFNQg0KPiA+Pj4+ICsg ICAgICAvLyBTa2lwIHRoZSBtZW1vcnkgYmxvY2sgaWYgdW5kZXIgMU1CDQo+ID4+Pj4gICAgICAg IC8vDQo+ID4+Pj4gICAgICB9IGVsc2Ugew0KPiA+Pj4+ICAgICAgICBpZiAoRWZpRW50cnktPlBo eXNpY2FsU3RhcnQgPCAweDEwMDAwMCkgew0KPiA+Pj4+IEBAIC0xOTI2LDcgKzE5MjYsNyBAQCBM ZWdhY3lCaW9zQnVpbGRFODIwICgNCj4gPj4+PiAgICAqU2l6ZSA9IChVSU5UTikgKEluZGV4ICog c2l6ZW9mIChFRklfRTgyMF9FTlRSWTY0KSk7DQo+ID4+Pj4NCj4gPj4+PiAgICAvLw0KPiA+Pj4+ IC0gIC8vIERldGVybWluZSBPUyB1c2FibGUgbWVtb3J5IGFib3ZlIDFNYg0KPiA+Pj4+ICsgIC8v IERldGVybWluZSBPUyB1c2FibGUgbWVtb3J5IGFib3ZlIDFNQg0KPiA+Pj4+ICAgIC8vDQo+ID4+ Pj4gICAgUHJpdmF0ZS0+SW50VGh1bmstPkVmaVRvTGVnYWN5MTZCb290VGFibGUuT3NNZW1vcnlB Ym92ZTFNYiA9DQo+ID4+IDB4MDAwMDsNCj4gPj4+PiAgICBmb3IgKFRlbXBJbmRleCA9IEFib3Zl MU1JbmRleDsgVGVtcEluZGV4IDwgSW5kZXg7IFRlbXBJbmRleCsrKSB7DQo+ID4+Pj4gQEAgLTE5 NDgsNyArMTk0OCw3IEBAIExlZ2FjeUJpb3NCdWlsZEU4MjAgKA0KPiA+Pj4+ICAgIC8vIFByaW50 IERFQlVHIGluZm9ybWF0aW9uDQo+ID4+Pj4gICAgLy8NCj4gPj4+PiAgICBmb3IgKFRlbXBJbmRl eCA9IDA7IFRlbXBJbmRleCA8IEluZGV4OyBUZW1wSW5kZXgrKykgew0KPiA+Pj4+IC0gICAgREVC VUcoKEVGSV9EX0lORk8sICJFODIwWyUyZF06IDB4JTE2bHggLS0tLSAweCUxNmx4LCBUeXBlID0g MHgleA0KPiA+PiBcbiIsDQo+ID4+Pj4gKyAgICBERUJVRygoRUZJX0RfSU5GTywgIkU4MjBbJTJk XTogMHglMDE2bHggLSAweCUwMTZseCwgVHlwZSA9ICVkXG4iLA0KPiA+Pj4+ICAgICAgICBUZW1w SW5kZXgsDQo+ID4+Pj4gICAgICAgIEU4MjBUYWJsZVtUZW1wSW5kZXhdLkJhc2VBZGRyLA0KPiA+ Pj4+ICAgICAgICAoRTgyMFRhYmxlW1RlbXBJbmRleF0uQmFzZUFkZHIgKyBFODIwVGFibGVbVGVt cEluZGV4XS5MZW5ndGgpLA0KPiA+Pj4+DQo+ID4+DQo+ID4+DQo+ID4NCj4gPg0KPiA+DQo+ID4N Cj4gDQo+IA0KDQo=