From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Mon, 15 Apr 2019 07:22:30 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 07:22:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,353,1549958400"; d="scan'208";a="151006509" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 15 Apr 2019 07:22:29 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 15 Apr 2019 07:22:28 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 15 Apr 2019 07:22:28 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.147]) with mapi id 14.03.0415.000; Mon, 15 Apr 2019 22:22:26 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" , "Wu, Hao A" CC: Ard Biesheuvel , "Kinney, Michael D" , Andrew Fish , "Zeng, Star" , "Dong, Eric" , "Ni, Ray" , "Carsey, Jaben" , "Shi, Steven" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v6 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol Thread-Topic: [edk2-devel] [PATCH v6 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol Thread-Index: AQHU8vupwOA9yQXj2UCDP2+6Jz8c4aY754CAgACAVICAAN9X4A== Date: Mon, 15 Apr 2019 14:22:25 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E427C39@SHSMSX104.ccr.corp.intel.com> References: <20190414195233.30045-1-ard.biesheuvel@linaro.org> <20190414195233.30045-2-ard.biesheuvel@linaro.org> <20190415090229.biz2hxcuvo35ieyr@bivouac.eciton.net> In-Reply-To: <20190415090229.biz2hxcuvo35ieyr@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzUyODdhNDQtNDFhZi00N2FmLWFjNTMtN2M5NmVlN2I5YTMxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN1V3VTd2NHdFVWFmWDViVXhPQlVVMzhcL3BsMVwvdlwvdnZIdzZCSFVtOGZIc3k1YVJvcjl1QjdtbzNYN3VXXC9OeVwvIn0= dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif: How about submit one BZ to catch it first? Then, revisit it later.=20 Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Le= if Lindholm > Sent: Monday, April 15, 2019 5:02 PM > To: Wu, Hao A > Cc: Ard Biesheuvel ; devel@edk2.groups.io; Ki= nney, Michael D ; Andrew Fish > ; Zeng, Star ; Dong, Eric ; Ni, Ray ; Gao, Liming > ; Carsey, Jaben ; Shi, Ste= ven ; Wang, Jian J > > Subject: Re: [edk2-devel] [PATCH v6 1/7] MdeModulePkg: introduce PE/COFF= image emulator protocol >=20 > On Mon, Apr 15, 2019 at 01:23:11AM +0000, Wu, Hao A wrote: > > > + This program and the accompanying materials are licensed and made > > > available > > > + under the terms and conditions of the BSD License which accompani= es this > > > + distribution. The full text of the license may be found at > > > + http://opensource.org/licenses/bsd-license.php > > > + > > > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > > BASIS, > > > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > > > EXPRESS OR IMPLIED. > > > + > > > +**/ > > > + > > > +#ifndef PECOFF_IMAGE_EMULATOR_PROTOCOL_GUID_H > > > +#define PECOFF_IMAGE_EMULATOR_PROTOCOL_GUID_H > > > > Hello Ard, > > > > Sorry for the delayed response. > > > > Could you help to use: > > _PECOFF_IMAGE_EMULATOR_PROTOCOL_GUID_H_ > > > > here to please the Ecc checker when you push the series? >=20 > Hmm... >=20 > Not a major issue, but I'll mention it anyway (which I mentioned to > Andrew/Mike at Linaro Connect in Vancouver last year): > clang has a warning, enabled by -Wreserved-id-macro, which complains > about this. >=20 > The Coding Style matches this, suggesting > MACROS_SHOULD_BE_WRITTEN_THUS_. So do we need to fix Ecc? >=20 > Regards, >=20 > Leif >=20 >=20