public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Fan, ZhijuX" <zhijux.fan@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [PATCH V2] BaseTools:update ConvertFceToStructurePcd.py with the char order PCD name.
Date: Tue, 16 Apr 2019 08:02:44 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E428750@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF4A706@SHSMSX101.ccr.corp.intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Fan, ZhijuX
>Sent: Monday, April 15, 2019 4:55 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [PATCH V2] BaseTools:update ConvertFceToStructurePcd.py with the
>char order PCD name.
>
>BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1718
>
>BaseTools\Scripts\ConvertFceToStructurePcd.py
>This script is for sorting the PCD order them
>base on PcdName, then base on Pcd field name.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>---
> BaseTools/Scripts/ConvertFceToStructurePcd.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/BaseTools/Scripts/ConvertFceToStructurePcd.py
>b/BaseTools/Scripts/ConvertFceToStructurePcd.py
>index c65cb555af..89e6a727a2 100644
>--- a/BaseTools/Scripts/ConvertFceToStructurePcd.py
>+++ b/BaseTools/Scripts/ConvertFceToStructurePcd.py
>@@ -506,6 +506,8 @@ class mainprocess(object):
>     for i in range(len(info_list)-1,-1,-1):
>       if len(info_list[i]) == 0:
>         info_list.remove(info_list[i])
>+    for i in (inf_list, title_all, header_list):
>+      i.sort()
>     return keys,title_all,info_list,header_list,inf_list
>
>   def remove_bracket(self,List):
>@@ -517,6 +519,9 @@ class mainprocess(object):
>           List[List.index(i)][i.index(j)] = "|".join(tmp)
>         else:
>           List[List.index(i)][i.index(j)] = j
>+    for i in List:
>+      if type(i) == type([0,0]):
>+        i.sort()
>     return List
>
>   def write_all(self):
>--
>2.14.1.windows.1


      reply	other threads:[~2019-04-16  8:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15  8:55 [PATCH V2] BaseTools:update ConvertFceToStructurePcd.py with the char order PCD name Fan, ZhijuX
2019-04-16  8:02 ` Liming Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E428750@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox