From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by groups.io with SMTP; Tue, 16 Apr 2019 01:02:48 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
  by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 01:02:47 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,357,1549958400"; 
   d="scan'208";a="141062964"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by fmsmga008.fm.intel.com with ESMTP; 16 Apr 2019 01:02:47 -0700
Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Tue, 16 Apr 2019 01:02:47 -0700
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Tue, 16 Apr 2019 01:02:47 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.25]) with mapi id 14.03.0415.000;
 Tue, 16 Apr 2019 16:02:45 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "Fan, ZhijuX" <zhijux.fan@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [PATCH V2] BaseTools:update ConvertFceToStructurePcd.py with the char order PCD name.
Thread-Topic: [PATCH V2] BaseTools:update ConvertFceToStructurePcd.py with
 the char order PCD name.
Thread-Index: AdTzaNXp9JAlNF3PRGaZLLazM1GnfgAwenOQ
Date: Tue, 16 Apr 2019 08:02:44 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E428750@SHSMSX104.ccr.corp.intel.com>
References: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF4A706@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF4A706@SHSMSX101.ccr.corp.intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Fan, ZhijuX
>Sent: Monday, April 15, 2019 4:55 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [PATCH V2] BaseTools:update ConvertFceToStructurePcd.py with the
>char order PCD name.
>
>BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1718
>
>BaseTools\Scripts\ConvertFceToStructurePcd.py
>This script is for sorting the PCD order them
>base on PcdName, then base on Pcd field name.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>---
> BaseTools/Scripts/ConvertFceToStructurePcd.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/BaseTools/Scripts/ConvertFceToStructurePcd.py
>b/BaseTools/Scripts/ConvertFceToStructurePcd.py
>index c65cb555af..89e6a727a2 100644
>--- a/BaseTools/Scripts/ConvertFceToStructurePcd.py
>+++ b/BaseTools/Scripts/ConvertFceToStructurePcd.py
>@@ -506,6 +506,8 @@ class mainprocess(object):
>     for i in range(len(info_list)-1,-1,-1):
>       if len(info_list[i]) =3D=3D 0:
>         info_list.remove(info_list[i])
>+    for i in (inf_list, title_all, header_list):
>+      i.sort()
>     return keys,title_all,info_list,header_list,inf_list
>
>   def remove_bracket(self,List):
>@@ -517,6 +519,9 @@ class mainprocess(object):
>           List[List.index(i)][i.index(j)] =3D "|".join(tmp)
>         else:
>           List[List.index(i)][i.index(j)] =3D j
>+    for i in List:
>+      if type(i) =3D=3D type([0,0]):
>+        i.sort()
>     return List
>
>   def write_all(self):
>--
>2.14.1.windows.1