From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Tue, 16 Apr 2019 01:28:44 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 01:28:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,357,1549958400"; d="scan'208";a="338020901" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 16 Apr 2019 01:28:32 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 01:28:32 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 01:28:32 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.39]) with mapi id 14.03.0415.000; Tue, 16 Apr 2019 16:28:30 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "Justen, Jordan L" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE Thread-Topic: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE Thread-Index: AQHU8Yfi5l5GY17WQEe6JuXdBpZ/vKY6u6gAgAIoEICAAZJ2kA== Date: Tue, 16 Apr 2019 08:28:30 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4287CB@SHSMSX104.ccr.corp.intel.com> References: <20190412233128.4756-1-lersek@redhat.com> <20190412233128.4756-3-lersek@redhat.com> <155522637661.21857.4743822681286277764@jljusten-skl> <3bbbb85e-5557-d99b-1c3b-50a844455d20@redhat.com> In-Reply-To: <3bbbb85e-5557-d99b-1c3b-50a844455d20@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 TGFzemxvOg0KICBJIHRoaW5rIGl0IGlzIE9LIHRvIGFkZCBVTklPTiB0eXBlLiBVTklPTiBpcyBu b3QgbmV3IGRhdGEgc3RydWN0dXJlLiBJdCBpcyBjb252ZW5pZW5jZSBmb3IgZGV2ZWxvcGVyIHRv IGNvbnN1bWUgdGhlIGRhdGEgc3RydWN0dXJlLiBUaGlzIGNoYW5nZSBpcyBnb29kIHRvIG1lLiBS ZXZpZXdlZC1ieTogTGltaW5nIEdhbyA8bGltaW5nLmdhb0BpbnRlbC5jb20+DQoNClRoYW5rcw0K TGltaW5nDQo+LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj5Gcm9tOiBkZXZlbEBlZGsyLmdy b3Vwcy5pbyBbbWFpbHRvOmRldmVsQGVkazIuZ3JvdXBzLmlvXSBPbiBCZWhhbGYgT2YNCj5MYXN6 bG8gRXJzZWsNCj5TZW50OiBUdWVzZGF5LCBBcHJpbCAxNiwgMjAxOSAxMjoxNiBBTQ0KPlRvOiBK dXN0ZW4sIEpvcmRhbiBMIDxqb3JkYW4ubC5qdXN0ZW5AaW50ZWwuY29tPjsgZWRrMi1kZXZlbC1n cm91cHMtaW8NCj48ZGV2ZWxAZWRrMi5ncm91cHMuaW8+OyBLaW5uZXksIE1pY2hhZWwgRCA8bWlj aGFlbC5kLmtpbm5leUBpbnRlbC5jb20+DQo+Q2M6IEdhbywgTGltaW5nIDxsaW1pbmcuZ2FvQGlu dGVsLmNvbT4NCj5TdWJqZWN0OiBSZTogW2VkazItZGV2ZWxdIFtQQVRDSCAwMi8xMF0gTWRlUGtn L1BpRmlybXdhcmVGaWxlOiBmaXgNCj51bmRlZmluZWQgYmVoYXZpb3IgaW4gU0VDVElPTl9TSVpF DQo+DQo+T24gMDQvMTQvMTkgMDk6MTksIEpvcmRhbiBKdXN0ZW4gd3JvdGU6DQo+PiBPbiAyMDE5 LTA0LTEyIDE2OjMxOjIwLCBMYXN6bG8gRXJzZWsgd3JvdGU6DQo+Pj4gUkggY292c2NhbiBqdXN0 aWZpZWRseSByZXBvcnRzIHRoYXQgYWNjZXNzaW5nDQo+Pj4gIkVGSV9DT01NT05fU0VDVElPTl9I RUFERVIuU2l6ZSIsIHdoaWNoIGlzIG9mIHR5cGUgVUlOVDhbM10sDQo+dGhyb3VnaCBhDQo+Pj4g KFVJTlQzMiopLCBpcyB1bmRlZmluZWQgYmVoYXZpb3I6DQo+Pj4NCj4+Pj4gRXJyb3I6IE9WRVJS VU4gKENXRS0xMTkpOg0KPj4+PiBlZGsyLTg5OTEwYTM5ZGNmZC9Pdm1mUGtnL1NlYy9TZWNNYWlu LmM6MTc4OiBvdmVycnVuLWxvY2FsOg0KPk92ZXJydW5uaW5nDQo+Pj4+IGFycmF5IG9mIDMgYnl0 ZXMgYXQgYnl0ZSBvZmZzZXQgMyBieSBkZXJlZmVyZW5jaW5nIHBvaW50ZXINCj4+Pj4gIihVSU5U MzIgKikoKEVGSV9DT01NT05fU0VDVElPTl9IRUFERVIgKikoVUlOVE4pU2VjdGlvbiktDQo+PlNp emUiLg0KPj4+PiAjICAxNzZ8ICAgICAgIFNlY3Rpb24gPSAoRUZJX0NPTU1PTl9TRUNUSU9OX0hF QURFUiopKFVJTlROKQ0KPkN1cnJlbnRBZGRyZXNzOw0KPj4+PiAjICAxNzd8DQo+Pj4+ICMgIDE3 OHwtPiAgICAgU2l6ZSA9IFNFQ1RJT05fU0laRSAoU2VjdGlvbik7DQo+Pj4+ICMgIDE3OXwgICAg ICAgaWYgKFNpemUgPCBzaXplb2YgKCpTZWN0aW9uKSkgew0KPj4+PiAjICAxODB8ICAgICAgICAg cmV0dXJuIEVGSV9WT0xVTUVfQ09SUlVQVEVEOw0KPj4+DQo+Pj4gRml4IHRoaXMgYnkgaW50cm9k dWNpbmcgRUZJX0NPTU1PTl9TRUNUSU9OX0hFQURFUl9VTklPTiwgYW5kDQo+ZXhwcmVzc2luZw0K Pj4+IFNFQ1RJT05fU0laRSgpIGluIHRlcm1zIG9mDQo+IkVGSV9DT01NT05fU0VDVElPTl9IRUFE RVJfVU5JT04uVWludDMyIi4NCj4+Pg0KPj4+IENjOiBMaW1pbmcgR2FvIDxsaW1pbmcuZ2FvQGlu dGVsLmNvbT4NCj4+PiBDYzogTWljaGFlbCBEIEtpbm5leSA8bWljaGFlbC5kLmtpbm5leUBpbnRl bC5jb20+DQo+Pj4gQnVnemlsbGE6IGh0dHBzOi8vYnVnemlsbGEudGlhbm9jb3JlLm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTcxMA0KPj4+IElzc3VlOiBzY2FuLTEwMDcudHh0DQo+Pj4gU2lnbmVkLW9m Zi1ieTogTGFzemxvIEVyc2VrIDxsZXJzZWtAcmVkaGF0LmNvbT4NCj4+PiAtLS0NCj4+PiAgTWRl UGtnL0luY2x1ZGUvUGkvUGlGaXJtd2FyZUZpbGUuaCB8IDEwICsrKysrKysrKy0NCj4+PiAgMSBm aWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPj4+DQo+Pj4gZGlm ZiAtLWdpdCBhL01kZVBrZy9JbmNsdWRlL1BpL1BpRmlybXdhcmVGaWxlLmgNCj5iL01kZVBrZy9J bmNsdWRlL1BpL1BpRmlybXdhcmVGaWxlLmgNCj4+PiBpbmRleCBhOWYzYmNjNGViOGUuLjRmY2U4 Mjk4ZDFjMCAxMDA2NDQNCj4+PiAtLS0gYS9NZGVQa2cvSW5jbHVkZS9QaS9QaUZpcm13YXJlRmls ZS5oDQo+Pj4gKysrIGIvTWRlUGtnL0luY2x1ZGUvUGkvUGlGaXJtd2FyZUZpbGUuaA0KPj4+IEBA IC0yMjksMTYgKzIyOSwyNCBAQCB0eXBlZGVmIHN0cnVjdCB7DQo+Pj4gICAgLy8vDQo+Pj4gICAg VUlOVDggICAgICAgICAgICAgU2l6ZVszXTsNCj4+PiAgICBFRklfU0VDVElPTl9UWVBFICBUeXBl Ow0KPj4+ICAgIC8vLw0KPj4+ICAgIC8vLyBEZWNsYXJlcyB0aGUgc2VjdGlvbiB0eXBlLg0KPj4+ ICAgIC8vLw0KPj4+ICB9IEVGSV9DT01NT05fU0VDVElPTl9IRUFERVI7DQo+Pj4NCj4+PiArLy8v DQo+Pj4gKy8vLyBVbmlvbiB0aGF0IHBlcm1pdHMgYWNjZXNzaW5nIEVGSV9DT01NT05fU0VDVElP Tl9IRUFERVIgYXMgYQ0KPlVJTlQzMiBvYmplY3QuDQo+Pj4gKy8vLw0KPj4+ICt0eXBlZGVmIHVu aW9uIHsNCj4+PiArICBFRklfQ09NTU9OX1NFQ1RJT05fSEVBREVSIEhkcjsNCj4+PiArICBVSU5U MzIgICAgICAgICAgICAgICAgICAgIFVpbnQzMjsNCj4+PiArfSBFRklfQ09NTU9OX1NFQ1RJT05f SEVBREVSX1VOSU9OOw0KPj4+ICsNCj4+PiAgdHlwZWRlZiBzdHJ1Y3Qgew0KPj4+ICAgIC8vLw0K Pj4+ICAgIC8vLyBBIDI0LWJpdCB1bnNpZ25lZCBpbnRlZ2VyIHRoYXQgY29udGFpbnMgdGhlIHRv dGFsIHNpemUgb2YgdGhlIHNlY3Rpb24gaW4NCj5ieXRlcywNCj4+PiAgICAvLy8gaW5jbHVkaW5n IHRoZSBFRklfQ09NTU9OX1NFQ1RJT05fSEVBREVSLg0KPj4+ICAgIC8vLw0KPj4+ICAgIFVJTlQ4 ICAgICAgICAgICAgIFNpemVbM107DQo+Pj4NCj4+PiAgICBFRklfU0VDVElPTl9UWVBFICBUeXBl Ow0KPj4+IEBAIC00NzYsMTcgKzQ4NCwxNyBAQCB0eXBlZGVmIHN0cnVjdCB7DQo+Pj4gICAgLy8v IEEgVUlOVDE2IHRoYXQgcmVwcmVzZW50cyBhIHBhcnRpY3VsYXIgYnVpbGQuIFN1YnNlcXVlbnQg YnVpbGRzIGhhdmUNCj5tb25vdG9uaWNhbGx5DQo+Pj4gICAgLy8vIGluY3JlYXNpbmcgYnVpbGQg bnVtYmVycyByZWxhdGl2ZSB0byBlYXJsaWVyIGJ1aWxkcy4NCj4+PiAgICAvLy8NCj4+PiAgICBV SU5UMTYgICAgICAgICAgICAgICAgICAgICAgICBCdWlsZE51bWJlcjsNCj4+PiAgICBDSEFSMTYg ICAgICAgICAgICAgICAgICAgICAgICBWZXJzaW9uU3RyaW5nWzFdOw0KPj4+ICB9IEVGSV9WRVJT SU9OX1NFQ1RJT04yOw0KPj4+DQo+Pj4gICNkZWZpbmUgU0VDVElPTl9TSVpFKFNlY3Rpb25IZWFk ZXJQdHIpIFwNCj4+PiAtICAgICgoVUlOVDMyKSAoKigoVUlOVDMyICopICgoRUZJX0NPTU1PTl9T RUNUSU9OX0hFQURFUiAqKSAoVUlOVE4pDQo+U2VjdGlvbkhlYWRlclB0ciktPlNpemUpICYgMHgw MGZmZmZmZikpDQo+Pj4gKyAgICAoKChFRklfQ09NTU9OX1NFQ1RJT05fSEVBREVSX1VOSU9OICop IChVSU5UTikNCj4oU2VjdGlvbkhlYWRlclB0cikpLT5VaW50MzIgJiAweDAwZmZmZmZmKQ0KPj4N Cj4+IE1pa2UsIGFsbCwNCj4+DQo+PiBDYW4gd2UgYWRkIGEgdHlwZWRlZiBmb3IgRUZJX0NPTU1P Tl9TRUNUSU9OX0hFQURFUl9VTklPTiBpZiBpdCdzDQo+bm90DQo+PiBpbiB0aGUgUEkgc3BlYz8N Cj4+DQo+PiBJZiBpdCdzIG5vdCBhbGxvd2VkLCBJIHRoaW5rIHNvbWV0aGluZyBsaWtlIHRoaXMg bWlnaHQgd29yayB0b286DQo+Pg0KPj4gI2RlZmluZSBTRUNUSU9OX1NJWkUoU2VjdGlvbkhlYWRl clB0cikgXA0KPj4gICAgICgqKChVSU5UMzIqKShVSU5UTikoU2VjdGlvbkhlYWRlclB0cikpICYg MHgwMGZmZmZmZikNCj4NCj4oTGVzcyBpbXBvcnRhbnRseTopDQo+DQo+SXQgbWlnaHQgc2h1dCB1 cCB0aGUgc3RhdGljIGFuYWx5emVyLCBidXQgcmVnYXJkaW5nIHRoZSBDIHN0YW5kYXJkLCBpdCdz DQo+ZXF1YWxseSB1bmRlZmluZWQgYmVoYXZpb3IuDQo+DQo+QW55d2F5IEkgZG9uJ3QgZmVlbCB0 b28gc3Ryb25nbHkgYWJvdXQgdGhpcywgZ2l2ZW4gdGhhdCB3ZSBkaXNhYmxlIHRoZQ0KPnN0cmlj dCBhbGlhc2luZyAvIGVmZmVjdGl2ZSB0eXBlIHJ1bGVzIGluICJ0b29sc19kZWYudGVtcGxhdGUi DQo+KCItZm5vLXN0cmljdC1hbGlhc2luZyIpLg0KPg0KPj4gVGhlbiBhZ2FpbiwgSSBzZWUgU0VD VElPTl9TSVpFIGlzIG5vdCBpbiB0aGUgc3BlYywgc28gbWF5YmUgaXQncyBvayB0bw0KPj4gYWRk IHRoZSB0eXBlZGVmLg0KPg0KPihNb3JlIGltcG9ydGFudGx5OikNCj4NCj5JbmRlZWQgdGhlIGRv dWJ0IHlvdSB2b2ljZSBhYm91dCAuLi5fVU5JT04gY3Jvc3NlZCBteSBtaW5kLCBidXQgdGhlbiBJ DQo+dG9vIHNlYXJjaGVkIHRoZSBQSSBzcGVjIGZvciBTRUNUSU9OX1NJWkUsIHdpdGggbm8gaGl0 cy4NCj4NCj5CZXlvbmQgdGhhdCwgSSBzZWFyY2hlZCBib3RoIHRoZSBQSSBhbmQgVUVGSSBzcGVj cywgZm9yICJfVU5JT04iIC0tDQo+YWdhaW4gbm8gaGl0cywgZGVzcGl0ZSBvdXIgZGVmaW5pdGlv bnMgb2Y6DQo+DQo+LSBFRklfSU1BR0VfT1BUSU9OQUxfSEVBREVSX1VOSU9ODQo+LSBFRklfR1JB UEhJQ1NfT1VUUFVUX0JMVF9QSVhFTF9VTklPTg0KPg0KPmluDQo+DQo+LSAiTWRlUGtnL0luY2x1 ZGUvSW5kdXN0cnlTdGFuZGFyZC9QZUltYWdlLmgiDQo+LSAiTWRlUGtnL0luY2x1ZGUvUHJvdG9j b2wvR3JhcGhpY3NPdXRwdXQuaCINCj4NCj5yZXNwZWN0aXZlbHkuDQo+DQo+VGhhbmtzLA0KPkxh c3psbw0KPg0KPj4NCj4+IC1Kb3JkYW4NCj4+DQo+DQo+DQo+DQoNCg==