Re: [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype

["Liming Gao" <liming.gao@intel.com>]

Zhichao:
  The change in MdePkg is good to me. Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Gao, Zhichao
>Sent: Monday, April 15, 2019 11:06 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao,
>Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu,
>Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Zeng, Star
><star.zeng@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Ard
>Biesheuvel <ard.biesheuvel@linaro.org>; Justen, Jordan L
><jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>; Steele,
>Kelly <kelly.steele@intel.com>; Sun, Zailiang <zailiang.sun@intel.com>; Qian,
>Yi <yi.qian@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Michael
>Turner <Michael.Turner@microsoft.com>; Bret Barkelew
><Bret.Barkelew@microsoft.com>
>Subject: [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and
>ResetSystemWithSubtype
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
>Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
>is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
>or not.
>Add a new API ResetSystem to ResetSystemLib instances. The new driver may
>consume this new API and then it may cause a link error. For these library
>instances, the new API only has a basic function. If the consumers want
>the full function of this API, they should use the instance in the
>MdeModulePkg
>and make sure the depex driver is dispatched.
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1458
>Add a new API ResetSystemWithSubtype to ResetUtilityLib
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Chao Zhang <chao.b.zhang@intel.com>
>Cc: Jiewen Yao <jiewen.yao@intel.com>
>Cc: Jian J Wang <jian.j.wang@intel.com>
>Cc: Hao Wu <hao.a.wu@intel.com>
>Cc: Ray Ni <ray.ni@intel.com>
>Cc: Star Zeng <star.zeng@intel.com>
>Cc: Leif Lindholm <leif.lindholm@linaro.org>
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>Cc: Jordan Justen <jordan.l.justen@intel.com>
>Cc: Laszlo Ersek <lersek@redhat.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Kelly Steele <kelly.steele@intel.com>
>Cc: Zailiang Sun <zailiang.sun@intel.com>
>Cc: Yi Qian <yi.qian@intel.com>
>Cc: Sean Brogan <sean.brogan@microsoft.com>
>Cc: Michael Turner <Michael.Turner@microsoft.com>
>Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
>Bret Barkelew (2):
>  MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
>  MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
>
>Zhichao Gao (23):
>  MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM
>  MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM
>  MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2
>  MdePkg/PeiServicesLib.c: Change comments of PeiServicesResetSystem2
>  SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset
>  MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem
>  MdeModulePkg/DxeResetSystemLib.c: Change comments of ResetSystem
>  MdeModulePkg/BaseResetSystemLibNull.c: Change comments of
>ResetSystem
>  MdeModulePkg/RuntimeResetSystemLib.c: Change comments
>  MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem
>  MdeModulePkg/ResetSystemRuntimeDxe: Change comments
>  MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2
>  MdeModulePkg/PeiMain: Change comments of PeiResetSystem2
>  MdeModulePkg/NvmExpressHci.c: Change comments
>  BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem
>  CorebootPayloadPkg/ResetSystemLib: Add new API ResetSystem
>  Nt32Pkg/ResetSystemLib: Add new API ResetSystem
>  OvmfPkg/ResetSystemLib: Add new API ResetSystem
>  PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem
>  QuarkSocPkg/ResetSystemLib: Add new API ResetSystem
>  Vlv2TbltdevicePkg/ResetSystemLib: Add new API ResetSystem
>  ArmPkg/ArmSmcPsciResetSystemLib: Add a new API ResetSystem
>  ArmVirtPkg/ArmVirtPsciResetSystemLib: Add a new API ResetSystem
>
> .../ArmSmcPsciResetSystemLib.c                | 43 +++++++++++++++++++
> .../ArmVirtPsciResetSystemLib.c               | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c   | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c   | 43 +++++++++++++++++++
> .../Bus/Pci/NvmExpressDxe/NvmExpressHci.c     |  5 +--
> MdeModulePkg/Core/Pei/PeiMain.h               |  4 +-
> MdeModulePkg/Core/Pei/Reset/Reset.c           |  4 +-
> MdeModulePkg/Include/Library/ResetSystemLib.h |  4 +-
> .../Include/Library/ResetUtilityLib.h         | 22 ++++++++++
> .../BaseResetSystemLibNull.c                  |  4 +-
> .../DxeResetSystemLib/DxeResetSystemLib.c     |  4 +-
> .../PeiResetSystemLib/PeiResetSystemLib.c     |  4 +-
> .../Library/ResetUtilityLib/ResetUtility.c    | 36 +++++++++++++---
> .../RuntimeResetSystemLib.c                   |  4 +-
> .../Universal/ResetSystemPei/ResetSystem.c    |  5 +--
> .../Universal/ResetSystemPei/ResetSystem.h    |  5 +--
> .../ResetSystemRuntimeDxe/ResetSystem.c       |  5 +--
> .../ResetSystemRuntimeDxe/ResetSystem.h       |  5 +--
> MdePkg/Include/Library/PeiServicesLib.h       |  4 +-
> MdePkg/Include/Pi/PiPeiCis.h                  |  4 +-
> MdePkg/Include/Uefi/UefiSpec.h                |  5 +--
> .../Library/PeiServicesLib/PeiServicesLib.c   |  4 +-
> .../Library/ResetSystemLib/ResetSystemLib.c   | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c   | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c   | 43 +++++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c   | 43 +++++++++++++++++++
> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c             |  5 +--
> .../Library/ResetSystemLib/ResetSystemLib.c   | 43 +++++++++++++++++++
> 28 files changed, 456 insertions(+), 64 deletions(-)
>
>--
>2.21.0.windows.1
>
>
>