From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Tue, 16 Apr 2019 18:24:56 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 18:24:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,360,1549958400"; d="scan'208";a="292176871" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 16 Apr 2019 18:24:55 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 18:24:54 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 18:24:54 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by shsmsx102.ccr.corp.intel.com ([169.254.2.206]) with mapi id 14.03.0415.000; Wed, 17 Apr 2019 09:24:52 +0800 From: "Liming Gao" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Zhang, Chao B" , "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , "Zeng, Star" , "Kinney, Michael D" , "Sean Brogan" , Michael Turner , Bret Barkelew Subject: Re: [PATCH V2 0/5] Make some DebugLib instance runtime safe Thread-Topic: [PATCH V2 0/5] Make some DebugLib instance runtime safe Thread-Index: AQHU8Mipwi7dtSNuUU6IQnypyXWl76Y/lyHg Date: Wed, 17 Apr 2019 01:24:52 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E429CA4@SHSMSX104.ccr.corp.intel.com> References: <20190412004231.17280-1-zhichao.gao@intel.com> In-Reply-To: <20190412004231.17280-1-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Gao, Zhichao >Sent: Friday, April 12, 2019 8:42 AM >To: devel@edk2.groups.io >Cc: Yao, Jiewen ; Zhang, Chao B >; Wang, Jian J ; Wu, Hao A >; Ni, Ray ; Zeng, Star >; Kinney, Michael D ; >Gao, Liming ; Sean Brogan >; Michael Turner >; Bret Barkelew > >Subject: [PATCH V2 0/5] Make some DebugLib instance runtime safe > >REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1416 > >Some pointer will be invalid after ExitBootServices, such as protocol poin= ter, >gST, gBS and so on. Disable the functions which used that pointer. > >Remove SMM support of UefiDebugLibDebugPortProtocol, >UefidebugLibConOut >and UefiDebugLibStdErr. >Before removing, should change the SMM instance in the dsc file which use >them as SMM instance. And null version is safe. > >V2: >Fix some typos. >Change the comment of function to meet the Doxygen rule. > >Cc: Jiewen Yao >Cc: Chao Zhang >Cc: Jian J Wang >Cc: Hao Wu >Cc: Ray Ni >Cc: Star Zeng >Cc: Michael D Kinney >Cc: Liming Gao >Cc: Sean Brogan >Cc: Michael Turner >Cc: Bret Barkelew > >Aaron Antone (3): > MdePkg/UefiDebugLibDebugPortProtocol: Make it runtime safe > MdePkg/UefidebugLibConOut: Make it runtime safe > MdePkg/UefiDebugLibStdErr: Make it runtime safe > >Zhichao Gao (2): > MdeModulePkg: Change the SMM debug lib instance > SignedCapsulePkg: Change the SMM debug lib instance > > MdeModulePkg/MdeModulePkg.dsc | 2 +- > MdePkg/Library/UefiDebugLibConOut/DebugLib.c | 116 +++++++------- > .../UefiDebugLibConOut/DebugLibConstructor.c | 77 +++++++++ > .../UefiDebugLibConOut/UefiDebugLibConOut.inf | 12 +- > .../UefiDebugLibDebugPortProtocol/DebugLib.c | 146 +++++++++--------- > .../DebugLibConstructor.c | 77 +++++++++ > .../UefiDebugLibDebugPortProtocol.inf | 12 +- > MdePkg/Library/UefiDebugLibStdErr/DebugLib.c | 113 +++++++------- > .../UefiDebugLibStdErr/DebugLibConstructor.c | 77 +++++++++ > .../UefiDebugLibStdErr/UefiDebugLibStdErr.inf | 12 +- > SignedCapsulePkg/SignedCapsulePkg.dsc | 4 +- > 11 files changed, 458 insertions(+), 190 deletions(-) > create mode 100644 >MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c > create mode 100644 >MdePkg/Library/UefiDebugLibDebugPortProtocol/DebugLibConstructor.c > create mode 100644 >MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c > >-- >2.21.0.windows.1