From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Mon, 22 Apr 2019 19:37:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Apr 2019 19:37:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,384,1549958400"; d="scan'208";a="164135055" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 22 Apr 2019 19:37:12 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 22 Apr 2019 19:37:12 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 22 Apr 2019 19:37:12 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.139]) with mapi id 14.03.0415.000; Tue, 23 Apr 2019 10:37:10 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: "Kinney, Michael D" , "Bi, Dandan" Subject: Re: [edk2-devel] [PATCH 0/3] MdePkg/DebugLib: Change the global variable name Thread-Topic: [edk2-devel] [PATCH 0/3] MdePkg/DebugLib: Change the global variable name Thread-Index: AQHU+X0w1OQeQCuqBUGxuOyzFqF3yaZJB9gQ Date: Tue, 23 Apr 2019 02:37:10 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E42C872@SHSMSX104.ccr.corp.intel.com> References: <20190423023507.16952-1-zhichao.gao@intel.com> In-Reply-To: <20190423023507.16952-1-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWIyZDQ3NzQtNTlkYS00NzljLThiZWEtYzU2ZDUyY2Q4OWY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUVVzRzhCQTZwUTdBUlV3aDJQbmxCMG5ISVJQdXdCS0N0SmE4Q3JwVXUxM3NVTVwvWkt2OUZKb1A5akNvZldtN2IifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ga= o, Zhichao > Sent: Tuesday, April 23, 2019 10:35 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming ; Bi, Dandan > Subject: [edk2-devel] [PATCH 0/3] MdePkg/DebugLib: Change the global var= iable name >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1740 >=20 > The DebugLib instances of DebugPortProtocol, ConOut and StdErr > use a global variable "mExitBootServicesEvent" which is in > conflict with the same variable in StatusCodeHandlerRuntimeDxe.inf. > That would cause a build error through GCC5. So change the > name to the "mDebugLibExitBootServicesEvent". >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Dandan Bi >=20 > Zhichao Gao (3): > MdePkg/UefiDebugLibConOut: Change the global variable name > MdePkg/UefiDebugLibStdErr: Change the global variable name > MdePkg/UefiDebugLibDebugPortProtocol: Change the global variable name >=20 > MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c | 4 ++-- > .../UefiDebugLibDebugPortProtocol/DebugLibConstructor.c | 4 ++-- > MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20