From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Zhang, Shenglei" <shenglei.zhang@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Zhu, Yonghong" <yonghong.zhu@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/3] Remove ICC tool chain
Date: Tue, 23 Apr 2019 07:18:42 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E42CCF8@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190409032114.13004-1-shenglei.zhang@intel.com>
The change is good. And, please update the patch based on the latest trunk.
Reviewed-by: Liming Gao <liming.gao@intel.com>
Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Zhang, Shenglei
> Sent: Tuesday, April 9, 2019 11:21 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Zhu,
> Yonghong <yonghong.zhu@intel.com>
> Subject: [edk2-devel] [PATCH 0/3] Remove ICC tool chain
>
> There is no Intel complier test. So suggest to remove ICC
> tool chain from tools_def.template and remove support of Intel
> tool chain in BaseLib. And also IoLibIcc.c
> in MdePkg should update to be removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1666
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> Shenglei Zhang (3):
> MdePkg/BaseIoLibIntrinsic: Remove IoLibIcc.c
> MdePkg/BaseLib: Remove support of INTEL tool chain
> BaseTools: Remove ICC tool chain in tools_def.template
>
> BaseTools/Conf/tools_def.template | 1092 -----------------
> .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 2 -
> .../BaseIoLibIntrinsicSev.inf | 2 -
> MdePkg/Library/BaseIoLibIntrinsic/IoLibIcc.c | 214 ----
> MdePkg/Library/BaseLib/BaseLib.inf | 196 +--
> 5 files changed, 7 insertions(+), 1499 deletions(-)
> delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibIcc.c
>
> --
> 2.18.0.windows.1
>
>
>
prev parent reply other threads:[~2019-04-23 7:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 3:21 [PATCH 0/3] Remove ICC tool chain Zhang, Shenglei
2019-04-09 3:21 ` [PATCH 1/3] MdePkg/BaseIoLibIntrinsic: Remove IoLibIcc.c Zhang, Shenglei
2019-04-09 3:21 ` [PATCH 2/3] MdePkg/BaseLib: Remove support of INTEL tool chain Zhang, Shenglei
2019-04-09 3:21 ` [PATCH 3/3] BaseTools: Remove ICC tool chain in tools_def.template Zhang, Shenglei
2019-04-23 6:21 ` [edk2-devel] " Liming Gao
2019-04-23 7:18 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E42CCF8@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox