From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Tue, 23 Apr 2019 00:21:45 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 00:21:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,384,1549958400"; d="scan'208";a="339935300" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 23 Apr 2019 00:21:44 -0700 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 23 Apr 2019 00:21:44 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 23 Apr 2019 00:21:44 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.139]) with mapi id 14.03.0415.000; Tue, 23 Apr 2019 15:18:42 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Zhang, Shenglei" CC: "Kinney, Michael D" , "Feng, Bob C" , "Zhu, Yonghong" Subject: Re: [edk2-devel] [PATCH 0/3] Remove ICC tool chain Thread-Topic: [edk2-devel] [PATCH 0/3] Remove ICC tool chain Thread-Index: AQHU7oNaNWWWDZXJvkWaS00TZfa26KZJa94Q Date: Tue, 23 Apr 2019 07:18:42 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E42CCF8@SHSMSX104.ccr.corp.intel.com> References: <20190409032114.13004-1-shenglei.zhang@intel.com> In-Reply-To: <20190409032114.13004-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2JiZGU3ZGItNmRjZC00NGVjLWJiNjMtN2JlM2FkNzA1OTFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoienVBdXZCSVo3VVlQR3ZvOTZLVml0dGt3ZlBsK0VsMm1rWVVwMHIzN0xiVzI4VUtWb2l1NWU0czJxMllOamlWQiJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The change is good. And, please update the patch based on the latest trunk.= = =20 Reviewed-by: Liming Gao Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Zh= ang, Shenglei > Sent: Tuesday, April 9, 2019 11:21 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Feng, Bob C ; Gao, Liming ; Zhu, > Yonghong > Subject: [edk2-devel] [PATCH 0/3] Remove ICC tool chain >=20 > There is no Intel complier test. So suggest to remove ICC > tool chain from tools_def.template and remove support of Intel > tool chain in BaseLib. And also IoLibIcc.c > in MdePkg should update to be removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1666 >=20 > Cc: Michael D Kinney > Cc: Bob Feng > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > Shenglei Zhang (3): > MdePkg/BaseIoLibIntrinsic: Remove IoLibIcc.c > MdePkg/BaseLib: Remove support of INTEL tool chain > BaseTools: Remove ICC tool chain in tools_def.template >=20 > BaseTools/Conf/tools_def.template | 1092 ----------------- > .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 2 - > .../BaseIoLibIntrinsicSev.inf | 2 - > MdePkg/Library/BaseIoLibIntrinsic/IoLibIcc.c | 214 ---- > MdePkg/Library/BaseLib/BaseLib.inf | 196 +-- > 5 files changed, 7 insertions(+), 1499 deletions(-) > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibIcc.c >=20 > -- > 2.18.0.windows.1 >=20 >=20 >=20