From: "Liming Gao" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [Patch] BaseTools: Support customized compiling command
Date: Fri, 26 Apr 2019 01:06:40 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E430ED4@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190423032122.29868-1-bob.c.feng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Feng, Bob C
>Sent: Tuesday, April 23, 2019 11:21 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: Support customized compiling command
>
>BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1737
>User may add other commands before CC command from build_rule.txt
>for specific purpose. It worked fine before commit 05217d210e.
>
>This patch is going to fix the bug in commit 05217d210e to
>support customized CC command.
>
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>---
> BaseTools/Source/Python/AutoGen/GenMake.py | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py
>b/BaseTools/Source/Python/AutoGen/GenMake.py
>index 7562dc68b3..0513807f4f 100644
>--- a/BaseTools/Source/Python/AutoGen/GenMake.py
>+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
>@@ -1022,11 +1022,11 @@ cleanlib:
> CmdCppDict[item.Target.SubDir].append(Path)
> if T.Commands:
> CommandList = T.Commands[:]
> for Item in CommandList[:]:
> SingleCommandList = Item.split()
>- if len(SingleCommandList) > 0 and '$(CC)' in SingleCommandList[0]:
>+ if len(SingleCommandList) > 0 and
>self.CheckCCCmd(SingleCommandList):
> for Temp in SingleCommandList:
> if Temp.startswith('/Fo'):
> CmdSign = '%s%s' % (Temp.rsplit(TAB_SLASH, 1)[0], TAB_SLASH)
> break
> else: continue
>@@ -1042,10 +1042,15 @@ cleanlib:
> T.Commands[Index] = '%s\n\t%s' % (' \\\n\t'.join(Cpplist),
>CmdTargetDict[CmdSign])
> else:
> T.Commands.pop(Index)
> return T, CmdSumDict, CmdTargetDict, CmdCppDict
>
>+ def CheckCCCmd(self, CommandList):
>+ for cmd in CommandList:
>+ if '$(CC)' in cmd:
>+ return True
>+ return False
> ## For creating makefile targets for dependent libraries
> def ProcessDependentLibrary(self):
> for LibraryAutoGen in self._AutoGenObject.LibraryAutoGenList:
> if not LibraryAutoGen.IsBinaryModule and not
>LibraryAutoGen.CanSkipbyHash():
>
>self.LibraryBuildDirectoryList.append(self.PlaceMacro(LibraryAutoGen.BuildDi
>r, self.Macros))
>--
>2.20.1.windows.1
prev parent reply other threads:[~2019-04-26 1:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 3:21 [Patch] BaseTools: Support customized compiling command Bob Feng
2019-04-26 1:06 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E430ED4@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox