public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"lersek@redhat.com" <lersek@redhat.com>
Subject: Re: [edk2-devel] [Patch v3 0/3] Add package level include DSC/FDF in NetworkPkg
Date: Mon, 29 Apr 2019 14:19:45 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E43F5D8@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <fe6b4c56-638b-fb91-47a4-bec8d6fcbb97@redhat.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek
> Sent: Monday, April 29, 2019 9:11 PM
> To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>
> Subject: Re: [edk2-devel] [Patch v3 0/3] Add package level include DSC/FDF in NetworkPkg
> 
> On 04/25/19 14:37, Liming Gao wrote:
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1293
> > BZ 1293 requests to move Network modules from MdeModulePkg to NetworkPkg.
> > To keep the backword compatiblity, Network package level include DSC/FDF
> > are introduced to be used in the platform DSC/FDF files. When Network
> > modules are moved from MdeModulePkg to NetworkPkg, Network package level
> > include DSC/FDF will be updated together. There is no impact on the platform
> > DSC/FDF file.
> >
> > This patch set is to introduce network package level include DSC/FDF files.
> > Bases on previous discussion and the existing usage case, build flag will be
> > used to enable/disable the network features. PCD control feature way can be
> > discussed later. And, to meet with the different usages, this patch set
> > introduces the separate DSC for Defines/Pcds/Libraries/Components (Patch 2)
> > , and also adds the package level combined DSC to include them all (Patch 3).
> > If platform wants to use the flexible way to enable Network feature, it can
> > use the separate DSCs. If the platform wants to directly enable Network
> > feature, it can use the combined package DSC file.
> >
> > This patch set is to update NetworkPkg only. If there is no objection on this
> > proposal, the following changes to platform DSC/FDF will be made and sent for
> > review. By default, the platform DSC/FDF will use the combined DSC/FDF file.
> > If the platform owner wants to use the flexible way to enable Network feature,
> > please reply this mail.
> 
> Yes, I'd like both OvmfPkg and ArmVirtPkg platforms to use the
> standalone include files from patch #2.
Thanks for your message. I will take it.
> 
> As I mentioned in my review of patch #2, the new flags should be
> appropriate replacements for OvmfPkg and ArmVirtPkg, out of the box,
> except for NETWORK_TLS_ENABLE.
OK. I will replace other except for NETWORK_TLS_ENABLE.
> 
> - For ArmVirt, we're going to address TLS_ENABLE separately (see
> <https://bugzilla.tianocore.org/show_bug.cgi?id=1009>).
> 
> - In OvmfPkg, we'll keep TLS_ENABLE, and set NETWORK_TLS_ENABLE to FALSE
> (see the explanation in my review).
> 
> Thanks!
> Laszlo
> 
> > Liming Gao (3):
> >   NetworkPkg DSC: Add the required ARM library to pass ARM build
> >   NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.
> >   NetworkPkg: Add package level include DSC file
> >
> >  NetworkPkg/Network.dsc.inc           |  30 +++++++++
> >  NetworkPkg/Network.fdf.inc           |  56 ++++++++++++++++
> >  NetworkPkg/NetworkComponents.dsc.inc |  61 +++++++++++++++++
> >  NetworkPkg/NetworkDefines.dsc.inc    | 126 +++++++++++++++++++++++++++++++++++
> >  NetworkPkg/NetworkLibs.dsc.inc       |  19 ++++++
> >  NetworkPkg/NetworkPcds.dsc.inc       |  16 +++++
> >  NetworkPkg/NetworkPkg.dsc            |  25 +------
> >  7 files changed, 311 insertions(+), 22 deletions(-)
> >  create mode 100644 NetworkPkg/Network.dsc.inc
> >  create mode 100644 NetworkPkg/Network.fdf.inc
> >  create mode 100644 NetworkPkg/NetworkComponents.dsc.inc
> >  create mode 100644 NetworkPkg/NetworkDefines.dsc.inc
> >  create mode 100644 NetworkPkg/NetworkLibs.dsc.inc
> >  create mode 100644 NetworkPkg/NetworkPcds.dsc.inc
> >
> 
> 
> 


  reply	other threads:[~2019-04-29 14:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-25 12:37 [Patch v3 0/3] Add package level include DSC/FDF in NetworkPkg Liming Gao
2019-04-25 12:37 ` [Patch v3 1/3] NetworkPkg DSC: Add the required ARM library to pass ARM build Liming Gao
2019-04-26 22:04   ` [edk2-devel] " Laszlo Ersek
2019-04-26 22:19     ` Ard Biesheuvel
2019-04-29  2:02       ` Liming Gao
2019-04-25 12:37 ` [Patch v3 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg Liming Gao
2019-04-29 13:05   ` [edk2-devel] " Laszlo Ersek
2019-04-29 14:18     ` Liming Gao
2019-05-05 15:21     ` Liming Gao
2019-05-06 18:23       ` Laszlo Ersek
2019-05-06 18:49         ` Andrew Fish
2019-05-07  4:23           ` Liming Gao
2019-05-07  1:22       ` Siyuan, Fu
2019-04-25 12:37 ` [Patch v3 3/3] NetworkPkg: Add package level include DSC file Liming Gao
2019-04-29 12:03   ` [edk2-devel] " Laszlo Ersek
2019-04-29 14:15     ` Liming Gao
2019-04-29 13:10 ` [edk2-devel] [Patch v3 0/3] Add package level include DSC/FDF in NetworkPkg Laszlo Ersek
2019-04-29 14:19   ` Liming Gao [this message]
     [not found] <1598B7EA854C3D9D.14569@groups.io>
2019-04-25 13:12 ` Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E43F5D8@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox