From: "Liming Gao" <liming.gao@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Steele, Kelly" <kelly.steele@intel.com>,
"Dong, Eric" <eric.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Patch V3 0/8] Resolve Quark build and boot issues
Date: Sun, 5 May 2019 05:23:57 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E441266@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190430193108.8544-1-michael.d.kinney@intel.com>
The change in MdePkg is good. Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Kinney, Michael D
>Sent: Wednesday, May 01, 2019 3:31 AM
>To: devel@edk2.groups.io
>Cc: Steele, Kelly <kelly.steele@intel.com>; Gao, Liming
><liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray
><ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>
>Subject: [Patch V3 0/8] Resolve Quark build and boot issues
>
>New in V3
>=========
>* Remove change to MpInitLib to avoid use of MSR_IA32_APIC_BASE. That
>change
> was not safe because an AP could call the PCD Protocol/PPI.
>* Add new MpInitLibUp for uni-processor platforms.
>* Update Quark DSC files to use MpInitLibUp for uni-processor platforms.
>* Add missing CpuLub library class to the CpuMpPei INF file
>
>New in V2
>=========
>* Add PcdSpeculationBarrierType to select between LFENCE, CPUID, and no
> operation in the x86 implementation of the BaseLib function
> SpeculationBarrier().
>* Set PcdSpeculationBarrierType to CPUID on Quark platforms.
>
>This series of patches resolves a few issues with building
>and booting Quark platforms.
>
>* Resolve name collision from API added to ResetSystemLib
>* Set SMRAM region to UC when SMRAM region is closed
>* Do no use LFENCE if CPU does not support SSE2
>* Avoid MSR_IA32_APIC_BASE if there is only one CPU
>
>Cc: Kelly Steele <kelly.steele@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Eric Dong <eric.dong@intel.com>
>Cc: Ray Ni <ray.ni@intel.com>
>Cc: Laszlo Ersek <lersek@redhat.com>
>Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>
>Michael D Kinney (8):
> MdePkg: Add PcdSpeculationBarrierType
> MdePkg/BaseLib: Use PcdSpeculationBarrierType
> QuarkPlatformPkg: Set PcdSpeculationBarrierType to CPUID
> UefiCpuPkg/MpInitLibUp: Add uniprocessor MpInitLib
> UefiCPuPkg/CpuMpPei: Add missing CpuLib class
> QuarkPlatformPkg: Use uniprocessor MpInitLibUp
> QuarkSocPkg/SmmAccessDxe: Set region to UC on SMRAM close
> QuarkPlatformPkg/PlatformInit: Resolve ResetSystemLib name collision
>
> MdePkg/Library/BaseLib/BaseLib.inf | 1 +
> .../Library/BaseLib/X86SpeculationBarrier.c | 8 +-
> MdePkg/MdePkg.dec | 9 +
> MdePkg/MdePkg.uni | 8 +
> .../Pei/PlatformInit/MemoryCallback.c | 6 +-
> .../Pei/PlatformInit/PlatformEarlyInit.h | 4 +-
> QuarkPlatformPkg/Quark.dsc | 10 +-
> QuarkPlatformPkg/QuarkMin.dsc | 8 +-
> .../Smm/Dxe/SmmAccessDxe/SmmAccess.inf | 3 +-
> .../Smm/Dxe/SmmAccessDxe/SmmAccessDriver.c | 18 +-
> .../Smm/Dxe/SmmAccessDxe/SmmAccessDriver.h | 3 +-
> UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 3 +-
> UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 407
>++++++++++++++++++
> .../Library/MpInitLibUp/MpInitLibUp.inf | 37 ++
> .../Library/MpInitLibUp/MpInitLibUp.uni | 14 +
> UefiCpuPkg/UefiCpuPkg.dsc | 3 +-
> 16 files changed, 525 insertions(+), 17 deletions(-)
> create mode 100644 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c
> create mode 100644 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf
> create mode 100644 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.uni
>
>--
>2.21.0.windows.1
next prev parent reply other threads:[~2019-05-05 5:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 19:31 [Patch V3 0/8] Resolve Quark build and boot issues Michael D Kinney
2019-04-30 19:31 ` [Patch V3 1/8] MdePkg: Add PcdSpeculationBarrierType Michael D Kinney
2019-04-30 19:31 ` [Patch V3 2/8] MdePkg/BaseLib: Use PcdSpeculationBarrierType Michael D Kinney
2019-04-30 19:31 ` [Patch V3 3/8] QuarkPlatformPkg: Set PcdSpeculationBarrierType to CPUID Michael D Kinney
2019-04-30 21:25 ` [edk2-devel] " Kubacki, Michael A
2019-04-30 19:31 ` [Patch V3 4/8] UefiCpuPkg/MpInitLibUp: Add uniprocessor MpInitLib Michael D Kinney
2019-04-30 20:25 ` [edk2-devel] " Laszlo Ersek
2019-05-05 2:36 ` Ni, Ray
2019-04-30 19:31 ` [Patch V3 5/8] UefiCPuPkg/CpuMpPei: Add missing CpuLib class Michael D Kinney
2019-04-30 20:31 ` [edk2-devel] " Laszlo Ersek
2019-04-30 19:31 ` [Patch V3 6/8] QuarkPlatformPkg: Use uniprocessor MpInitLibUp Michael D Kinney
2019-04-30 21:31 ` [edk2-devel] " Kubacki, Michael A
2019-04-30 19:31 ` [Patch V3 7/8] QuarkSocPkg/SmmAccessDxe: Set region to UC on SMRAM close Michael D Kinney
2019-04-30 19:31 ` [Patch V3 8/8] QuarkPlatformPkg/PlatformInit: Resolve ResetSystemLib name collision Michael D Kinney
2019-05-05 5:23 ` Liming Gao [this message]
2019-05-08 14:49 ` [Patch V3 0/8] Resolve Quark build and boot issues Steele, Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E441266@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox