From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Sat, 04 May 2019 22:24:02 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2019 22:24:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,431,1549958400"; d="scan'208";a="146365354" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 04 May 2019 22:24:00 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 4 May 2019 22:24:00 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 4 May 2019 22:24:00 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.150]) with mapi id 14.03.0415.000; Sun, 5 May 2019 13:23:58 +0800 From: "Liming Gao" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Steele, Kelly" , "Dong, Eric" , "Ni, Ray" , Laszlo Ersek Subject: Re: [Patch V3 0/8] Resolve Quark build and boot issues Thread-Topic: [Patch V3 0/8] Resolve Quark build and boot issues Thread-Index: AQHU/4tJaIkswMdnqkCuSBOXAs6G0qZcBkwg Date: Sun, 5 May 2019 05:23:57 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E441266@SHSMSX104.ccr.corp.intel.com> References: <20190430193108.8544-1-michael.d.kinney@intel.com> In-Reply-To: <20190430193108.8544-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The change in MdePkg is good. Reviewed-by: Liming Gao >-----Original Message----- >From: Kinney, Michael D >Sent: Wednesday, May 01, 2019 3:31 AM >To: devel@edk2.groups.io >Cc: Steele, Kelly ; Gao, Liming >; Dong, Eric ; Ni, Ray >; Laszlo Ersek >Subject: [Patch V3 0/8] Resolve Quark build and boot issues > >New in V3 >=3D=3D=3D=3D=3D=3D=3D=3D=3D >* Remove change to MpInitLib to avoid use of MSR_IA32_APIC_BASE. That >change > was not safe because an AP could call the PCD Protocol/PPI. >* Add new MpInitLibUp for uni-processor platforms. >* Update Quark DSC files to use MpInitLibUp for uni-processor platforms. >* Add missing CpuLub library class to the CpuMpPei INF file > >New in V2 >=3D=3D=3D=3D=3D=3D=3D=3D=3D >* Add PcdSpeculationBarrierType to select between LFENCE, CPUID, and no > operation in the x86 implementation of the BaseLib function > SpeculationBarrier(). >* Set PcdSpeculationBarrierType to CPUID on Quark platforms. > >This series of patches resolves a few issues with building >and booting Quark platforms. > >* Resolve name collision from API added to ResetSystemLib >* Set SMRAM region to UC when SMRAM region is closed >* Do no use LFENCE if CPU does not support SSE2 >* Avoid MSR_IA32_APIC_BASE if there is only one CPU > >Cc: Kelly Steele >Cc: Liming Gao >Cc: Eric Dong >Cc: Ray Ni >Cc: Laszlo Ersek >Signed-off-by: Michael D Kinney > >Michael D Kinney (8): > MdePkg: Add PcdSpeculationBarrierType > MdePkg/BaseLib: Use PcdSpeculationBarrierType > QuarkPlatformPkg: Set PcdSpeculationBarrierType to CPUID > UefiCpuPkg/MpInitLibUp: Add uniprocessor MpInitLib > UefiCPuPkg/CpuMpPei: Add missing CpuLib class > QuarkPlatformPkg: Use uniprocessor MpInitLibUp > QuarkSocPkg/SmmAccessDxe: Set region to UC on SMRAM close > QuarkPlatformPkg/PlatformInit: Resolve ResetSystemLib name collision > > MdePkg/Library/BaseLib/BaseLib.inf | 1 + > .../Library/BaseLib/X86SpeculationBarrier.c | 8 +- > MdePkg/MdePkg.dec | 9 + > MdePkg/MdePkg.uni | 8 + > .../Pei/PlatformInit/MemoryCallback.c | 6 +- > .../Pei/PlatformInit/PlatformEarlyInit.h | 4 +- > QuarkPlatformPkg/Quark.dsc | 10 +- > QuarkPlatformPkg/QuarkMin.dsc | 8 +- > .../Smm/Dxe/SmmAccessDxe/SmmAccess.inf | 3 +- > .../Smm/Dxe/SmmAccessDxe/SmmAccessDriver.c | 18 +- > .../Smm/Dxe/SmmAccessDxe/SmmAccessDriver.h | 3 +- > UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 3 +- > UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 407 >++++++++++++++++++ > .../Library/MpInitLibUp/MpInitLibUp.inf | 37 ++ > .../Library/MpInitLibUp/MpInitLibUp.uni | 14 + > UefiCpuPkg/UefiCpuPkg.dsc | 3 +- > 16 files changed, 525 insertions(+), 17 deletions(-) > create mode 100644 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c > create mode 100644 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf > create mode 100644 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.uni > >-- >2.21.0.windows.1