From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Mon, 06 May 2019 01:22:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 May 2019 01:22:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,437,1549958400"; d="scan'208";a="168263036" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 06 May 2019 01:22:12 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 6 May 2019 01:22:12 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 6 May 2019 01:22:12 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.136]) with mapi id 14.03.0415.000; Mon, 6 May 2019 16:22:10 +0800 From: "Liming Gao" To: "Kubacki, Michael A" , Leif Lindholm , "devel@edk2.groups.io" CC: Andrew Fish , Laszlo Ersek , "Kinney, Michael D" , Ard Biesheuvel Subject: Re: [edk2-devel] [edk2-platforms] [RFC] Migrate devel-MinPlatform branch to master branch Thread-Topic: [edk2-devel] [edk2-platforms] [RFC] Migrate devel-MinPlatform branch to master branch Thread-Index: AdT2KouLyR+4PxT0TviHqeHXbgAoHQKirwyAAAz44IAAvqRmoA== Date: Mon, 6 May 2019 08:22:10 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E441B4E@SHSMSX104.ccr.corp.intel.com> References: <49AB4ACB9627B8468F29D589A27B7455888CA32F@ORSMSX122.amr.corp.intel.com> <20190502150427.ihzom3w4fvjpxopk@bivouac.eciton.net> <49AB4ACB9627B8468F29D589A27B7455888E47BF@ORSMSX122.amr.corp.intel.com> In-Reply-To: <49AB4ACB9627B8468F29D589A27B7455888E47BF@ORSMSX122.amr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable >-----Original Message----- >From: Kubacki, Michael A >Sent: Friday, May 03, 2019 5:16 AM >To: Leif Lindholm ; devel@edk2.groups.io >Cc: Gao, Liming ; Andrew Fish ; >Laszlo Ersek ; Kinney, Michael D >; Ard Biesheuvel >Subject: RE: [edk2-devel] [edk2-platforms] [RFC] Migrate devel-MinPlatfor= m >branch to master branch > >Hi Leif, > >> -----Original Message----- >> From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >> Sent: Thursday, May 2, 2019 8:04 AM >> To: devel@edk2.groups.io; Kubacki, Michael A >> >> Cc: Gao, Liming ; Andrew Fish ; >> Laszlo Ersek ; Kinney, Michael D >> ; Ard Biesheuvel >> Subject: Re: [edk2-devel] [edk2-platforms] [RFC] Migrate devel- >MinPlatform >> branch to master branch >> >> Hi Michael, >> >> On Thu, Apr 18, 2019 at 09:11:38PM +0000, Kubacki, Michael A wrote: >> > Hello, >> > >> > This RFC proposes moving the content on the devel-MinPlatform branch >> > in the edk2-platforms repository to the master branch in the >> > edk2-platforms repository. >> > >> > The devel-MinPlatform branch has been used for the initial developmen= t >> > of an EDK II based platform design referred to as "Minimum Platform". >> > This design is intended to provide a structured approach to >> > introducing Intel platform code into open source in a consistent mann= er. >> > >> > For more information about the EDK II Minimum Platform, please refer >> > to the Readme.md in devel-MinPlatform. >> > https://github.com/tianocore/edk2-platforms/blob/devel- >> MinPlatform/Rea >> > dMe.md >> > >> > The following packages would be added in Platform/Intel: >> > * Generic packages: >> > * AdvancedFeaturePkg >> > * MinPlatformPkg >> >> First a generic comment with some examples: >> Both of these include non-architecture-specific components that could b= e >> useful to have more generally available. >> >> Certainly AdvancedFeaturePkg/Smbios/ and AcpiDebug look like something >> of a generic nature rather than Intel-platform specific. >> >The intention is for advanced features to be generic and architecture >agnostic when possible. We ultimately want to simplify the process to >enable open source edk2 platforms and cross-architecture compatibility >certainly aids in that goal. We're starting with the code in the Intel di= rectory >and we are open to moving features elsewhere based on interest and >usefulness. > >I suspect we'll also evolve some elements of how these features are >organized and designed based on feedback over time. For example, while >we're starting with one AdvancedFeaturePkg, it may be too monolithic. >More cohesive packages are likely easier to integrate and maintain. So >we may propose breaking this into something like DebugFeaturePkg, >IoFeaturePkg, PowerManagementFeaturePkg, or to some other degree. I >expect the definition to be a fluid process based on actual demand. > >> And Platform/Intel/MinPlatformPkg/Library/CompressLib/CompressLib.c >> appears to have nearly only whitespace differences compared to edk2 >> ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c. >> >> (With edk2 already having 3 additional quite similar files in >> BaseTools/Source/C/Common/EfiCompress.c >> BaseTools/Source/C/Common/TianoCompress.c >> BaseTools/Source/C/TianoCompress/TianoCompress.c) >> >> >That's a good point. In particular, it would be nice to consolidate the c= ode >usage >between ShellPkg and MinPlatformPkg. Perhaps the compression code could >be moved somewhere like MdePkg where it could be used by both packages. > Yes. I will submit BZ for UefiCompressLib usage. And, I will submit anothe= r BZ=20 to reduce the duplication compression code in BaseTools.=20 >> Secondly - edk2 has recently transitioned to bsd+patents license, and i= t >> would make sense if edk2-platforms did the same. Do we want to do that >> before or after this addition? >> >I will defer this to Mike Kinney. > >> >> Finally, what should we do for Maintainers.txt? >> >I believe we need to have per-package maintainers for the packages being >added. For >example, merge what is in >https://github.com/lgao4/edk2- >platforms/blob/master/Platform/Intel/Maintainers.txt > >I can update the following Maintainers.txt with a proposal. >https://github.com/lgao4/edk2-platforms/blob/master/Maintainers.txt > I think first step is to move the code from branch to master, then update = Maintainers.txt to align to edk2 Maintainers.txt.=20 =20 >Regards, >Michael > >> Best Regards, >> >> Leif >> >> > * Board-specific packages: >> > * ClevoOpenBoardPkg >> > * KabylakeOpenBoardPkg >> > * PurleyOpenBoardPkg >> > >> > The following packages would be added in Silicon/Intel: >> > * KabylakeSiliconPkg >> > * LewisburgPkg >> > * PurleyRcPkg >> > * PurleySktPkg >> > >> > The following growth is expected over time: >> > * Platform/Intel - Additional board packages for Intel reference boa= rds >> > including support for some pre-existing product releases >> > * AdvancedFeaturePkg - Additional modular features capable of being >> used >> > in board packages >> > * Silicon/Intel - Additional silicon packages roughly keeping 1:1 pa= rity >> > with board packages >> > >> > We hope the content will enable others to add new board packages and >> > advanced features over time. >> > >> > The result of the change is available here for reference: >> > https://github.com/lgao4/edk2-platforms >> > >> > Regards, >> > Michael >> > >> >=20 >> >