From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by groups.io with SMTP; Mon, 06 May 2019 22:59:22 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
  by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 May 2019 22:59:21 -0700
X-ExtLoop1: 1
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by fmsmga001.fm.intel.com with ESMTP; 06 May 2019 22:59:22 -0700
Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Mon, 6 May 2019 22:59:19 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Mon, 6 May 2019 22:59:18 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.129]) with mapi id 14.03.0415.000;
 Tue, 7 May 2019 13:59:16 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
Subject: Re: [patch 03/11] IntelFrameworkModulePkg: Remove PcdFrameworkCompatibilitySupport usage
Thread-Topic: [patch 03/11] IntelFrameworkModulePkg: Remove
 PcdFrameworkCompatibilitySupport usage
Thread-Index: AQHU/jGat765RDr3H0yXduaoU9akhqZfN5vQ
Date: Tue, 7 May 2019 05:59:16 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E443E83@SHSMSX104.ccr.corp.intel.com>
References: <20190429021607.11304-1-dandan.bi@intel.com>
 <20190429021607.11304-4-dandan.bi@intel.com>
In-Reply-To: <20190429021607.11304-4-dandan.bi@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Bi, Dandan
>Sent: Monday, April 29, 2019 10:16 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [patch 03/11] IntelFrameworkModulePkg: Remove
>PcdFrameworkCompatibilitySupport usage
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1464
>
>Currently Framework compatibility is not needed and
>PcdFrameworkCompatibilitySupport will be removed from edk2.
>So remove the usage of this PCD firstly.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>---
> .../Universal/Acpi/AcpiS3SaveDxe/AcpiS3Save.c          | 10 +---------
> .../Universal/Acpi/AcpiS3SaveDxe/AcpiS3SaveDxe.inf     |  3 +--
> 2 files changed, 2 insertions(+), 11 deletions(-)
>
>diff --git
>a/IntelFrameworkModulePkg/Universal/Acpi/AcpiS3SaveDxe/AcpiS3Save.c
>b/IntelFrameworkModulePkg/Universal/Acpi/AcpiS3SaveDxe/AcpiS3Save.c
>index b5f8131f98..366ada935d 100644
>---
>a/IntelFrameworkModulePkg/Universal/Acpi/AcpiS3SaveDxe/AcpiS3Save.c
>+++
>b/IntelFrameworkModulePkg/Universal/Acpi/AcpiS3SaveDxe/AcpiS3Save.c
>@@ -1,10 +1,10 @@
> /** @file
>   This is an implementation of the ACPI S3 Save protocol.  This is define=
d in
>   S3 boot path specification 0.9.
>
>-Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>+Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
>
>@@ -138,14 +138,10 @@ S3Ready (
>   if (AlreadyEntered) {
>     return EFI_SUCCESS;
>   }
>   AlreadyEntered =3D TRUE;
>
>-  if (FeaturePcdGet(PcdFrameworkCompatibilitySupport)) {
>-    S3ReadyThunkPlatform ();
>-  }
>-
>   return EFI_SUCCESS;
> }
>
> /**
>   The Driver Entry Point.
>@@ -180,14 +176,10 @@ InstallAcpiS3Save (
>     mLegacyRegionSize =3D 0x250;
>   } else {
>     mLegacyRegionSize =3D 0x100;
>   }
>
>-  if (FeaturePcdGet(PcdFrameworkCompatibilitySupport)) {
>-    InstallAcpiS3SaveThunk ();
>-  }
>-
>   Status =3D gBS->InstallProtocolInterface (
>                   &ImageHandle,
>                   &gEfiAcpiS3SaveProtocolGuid,
>                   EFI_NATIVE_INTERFACE,
>                   &mS3Save
>diff --git
>a/IntelFrameworkModulePkg/Universal/Acpi/AcpiS3SaveDxe/AcpiS3SaveDxe
>.inf
>b/IntelFrameworkModulePkg/Universal/Acpi/AcpiS3SaveDxe/AcpiS3SaveDxe
>.inf
>index 2e4f0868d2..0cfcb8ce53 100644
>---
>a/IntelFrameworkModulePkg/Universal/Acpi/AcpiS3SaveDxe/AcpiS3SaveDxe
>.inf
>+++
>b/IntelFrameworkModulePkg/Universal/Acpi/AcpiS3SaveDxe/AcpiS3SaveDxe
>.inf
>@@ -1,9 +1,9 @@
> ## @file
> # AcpiS3Save module installs ACPI S3 Save protocol to prepare S3 boot dat=
a.
> #
>-# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>+# Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> ##
>
>@@ -56,11 +56,10 @@
>   ## SOMETIMES_CONSUMES
>   gEdkiiVariableLockProtocolGuid
>
> [FeaturePcd]
>   gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdPlatformCsmSupport
>## CONSUMES
>-  gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport
>## CONSUMES
>
> [Pcd]
>
>gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdS3AcpiReservedMemory
>Size    ## SOMETIMES_CONSUMES
>   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable                         =
  ##
>CONSUMES
>
>--
>2.18.0.windows.1