From: "Liming Gao" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [Patch] BaseTools: Fix the issue that build report missing Module Size
Date: Thu, 9 May 2019 02:33:21 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E445424@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190508094630.21096-1-bob.c.feng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, May 8, 2019 5:47 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: Fix the issue that build report missing Module Size
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1786
>
> commit b1e27d changed GENFW output folder from DEBUG to OUTPUT,
> but that commit missed updating the buildreport.py for FwReportFileName.
>
> This patch is going to fix this issue.
>
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> BaseTools/Source/Python/build/BuildReport.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
> index 942631c879..a3eb3b2383 100644
> --- a/BaseTools/Source/Python/build/BuildReport.py
> +++ b/BaseTools/Source/Python/build/BuildReport.py
> @@ -618,11 +618,11 @@ class ModuleReport(object):
> # @param ReportType The kind of report items in the final report file
> #
> def GenerateReport(self, File, GlobalPcdReport, GlobalPredictionReport, GlobalDepexParser, ReportType):
> FileWrite(File, gSectionStart)
>
> - FwReportFileName = os.path.join(self._BuildDir, "DEBUG", self.ModuleName + ".txt")
> + FwReportFileName = os.path.join(self._BuildDir, "OUTPUT", self.ModuleName + ".txt")
> if os.path.isfile(FwReportFileName):
> try:
> FileContents = open(FwReportFileName).read()
> Match = gModuleSizePattern.search(FileContents)
> if Match:
> --
> 2.20.1.windows.1
prev parent reply other threads:[~2019-05-09 2:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 9:46 [Patch] BaseTools: Fix the issue that build report missing Module Size Bob Feng
2019-05-09 2:33 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E445424@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox