public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] BaseTools: Fix the issue that build report missing Module Size
@ 2019-05-08  9:46 Bob Feng
  2019-05-09  2:33 ` Liming Gao
  0 siblings, 1 reply; 2+ messages in thread
From: Bob Feng @ 2019-05-08  9:46 UTC (permalink / raw)
  To: devel; +Cc: Bob Feng, Liming Gao

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1786

commit b1e27d changed GENFW output folder from DEBUG to OUTPUT,
but that commit missed updating the buildreport.py for FwReportFileName.

This patch is going to fix this issue.

Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Source/Python/build/BuildReport.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
index 942631c879..a3eb3b2383 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -618,11 +618,11 @@ class ModuleReport(object):
     # @param ReportType             The kind of report items in the final report file
     #
     def GenerateReport(self, File, GlobalPcdReport, GlobalPredictionReport, GlobalDepexParser, ReportType):
         FileWrite(File, gSectionStart)
 
-        FwReportFileName = os.path.join(self._BuildDir, "DEBUG", self.ModuleName + ".txt")
+        FwReportFileName = os.path.join(self._BuildDir, "OUTPUT", self.ModuleName + ".txt")
         if os.path.isfile(FwReportFileName):
             try:
                 FileContents = open(FwReportFileName).read()
                 Match = gModuleSizePattern.search(FileContents)
                 if Match:
-- 
2.20.1.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] BaseTools: Fix the issue that build report missing Module Size
  2019-05-08  9:46 [Patch] BaseTools: Fix the issue that build report missing Module Size Bob Feng
@ 2019-05-09  2:33 ` Liming Gao
  0 siblings, 0 replies; 2+ messages in thread
From: Liming Gao @ 2019-05-09  2:33 UTC (permalink / raw)
  To: Feng, Bob C, devel@edk2.groups.io

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, May 8, 2019 5:47 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: Fix the issue that build report missing Module Size
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1786
> 
> commit b1e27d changed GENFW output folder from DEBUG to OUTPUT,
> but that commit missed updating the buildreport.py for FwReportFileName.
> 
> This patch is going to fix this issue.
> 
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  BaseTools/Source/Python/build/BuildReport.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
> index 942631c879..a3eb3b2383 100644
> --- a/BaseTools/Source/Python/build/BuildReport.py
> +++ b/BaseTools/Source/Python/build/BuildReport.py
> @@ -618,11 +618,11 @@ class ModuleReport(object):
>      # @param ReportType             The kind of report items in the final report file
>      #
>      def GenerateReport(self, File, GlobalPcdReport, GlobalPredictionReport, GlobalDepexParser, ReportType):
>          FileWrite(File, gSectionStart)
> 
> -        FwReportFileName = os.path.join(self._BuildDir, "DEBUG", self.ModuleName + ".txt")
> +        FwReportFileName = os.path.join(self._BuildDir, "OUTPUT", self.ModuleName + ".txt")
>          if os.path.isfile(FwReportFileName):
>              try:
>                  FileContents = open(FwReportFileName).read()
>                  Match = gModuleSizePattern.search(FileContents)
>                  if Match:
> --
> 2.20.1.windows.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-09  2:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-08  9:46 [Patch] BaseTools: Fix the issue that build report missing Module Size Bob Feng
2019-05-09  2:33 ` Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox