From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Wed, 08 May 2019 19:33:25 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2019 19:33:25 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 08 May 2019 19:33:24 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 8 May 2019 19:33:24 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 8 May 2019 19:33:24 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.7]) with mapi id 14.03.0415.000; Thu, 9 May 2019 10:33:22 +0800 From: "Liming Gao" To: "Feng, Bob C" , "devel@edk2.groups.io" Subject: Re: [Patch] BaseTools: Fix the issue that build report missing Module Size Thread-Topic: [Patch] BaseTools: Fix the issue that build report missing Module Size Thread-Index: AQHVBYLvxQuxr+4mkE+at4CkkShvGaZiFBSw Date: Thu, 9 May 2019 02:33:21 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E445424@SHSMSX104.ccr.corp.intel.com> References: <20190508094630.21096-1-bob.c.feng@intel.com> In-Reply-To: <20190508094630.21096-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWZlZTZkYjItOWE1Yi00MjI4LWEwMTktNjEwN2VhOWFkMzM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNlJJdmVSTTJRM0NvcDlPS0ZJajd3aEp6ZkhKK3hEcU54RzBndXdjd3ErSHo5dzNRbUdxOGtFdHdRS3hlNExUZiJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Feng, Bob C > Sent: Wednesday, May 8, 2019 5:47 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch] BaseTools: Fix the issue that build report missing Modul= e Size >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1786 >=20 > commit b1e27d changed GENFW output folder from DEBUG to OUTPUT, > but that commit missed updating the buildreport.py for FwReportFileName. >=20 > This patch is going to fix this issue. >=20 > Signed-off-by: Bob Feng > Cc: Liming Gao > --- > BaseTools/Source/Python/build/BuildReport.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Sou= rce/Python/build/BuildReport.py > index 942631c879..a3eb3b2383 100644 > --- a/BaseTools/Source/Python/build/BuildReport.py > +++ b/BaseTools/Source/Python/build/BuildReport.py > @@ -618,11 +618,11 @@ class ModuleReport(object): > # @param ReportType The kind of report items in the fina= l report file > # > def GenerateReport(self, File, GlobalPcdReport, GlobalPredictionRepo= rt, GlobalDepexParser, ReportType): > FileWrite(File, gSectionStart) >=20 > - FwReportFileName =3D os.path.join(self._BuildDir, "DEBUG", self.= ModuleName + ".txt") > + FwReportFileName =3D os.path.join(self._BuildDir, "OUTPUT", self= .ModuleName + ".txt") > if os.path.isfile(FwReportFileName): > try: > FileContents =3D open(FwReportFileName).read() > Match =3D gModuleSizePattern.search(FileContents) > if Match: > -- > 2.20.1.windows.1