From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by groups.io with SMTP; Fri, 10 May 2019 00:25:47 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga001.jf.intel.com ([10.7.209.18])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 00:25:47 -0700
X-ExtLoop1: 1
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by orsmga001.jf.intel.com with ESMTP; 10 May 2019 00:25:46 -0700
Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Fri, 10 May 2019 00:25:46 -0700
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Fri, 10 May 2019 00:25:46 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.10]) with mapi id 14.03.0415.000;
 Fri, 10 May 2019 15:25:44 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [Patch] BaseTools: Remove './SecMain' from 'run' target
Thread-Topic: [Patch] BaseTools: Remove './SecMain' from 'run' target
Thread-Index: AQHVBvpVwXHrtNL2AEeAxttYUtD21aZj9R3w
Date: Fri, 10 May 2019 07:25:43 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4466B8@SHSMSX104.ccr.corp.intel.com>
References: <20190510063336.27928-1-bob.c.feng@intel.com>
In-Reply-To: <20190510063336.27928-1-bob.c.feng@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Bob:
  Please make sure run command still works on NT32 platform.=20

>-----Original Message-----
>From: Feng, Bob C
>Sent: Friday, May 10, 2019 2:34 PM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
><liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: [Patch] BaseTools: Remove './SecMain' from 'run' target
>
>BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1561
>
>When a target of 'run' is passed into build.py,
>BaseTools unconditionally attempts to execute the
>application called './SecMain' in the build output directory.
>
>This behavior applies to the Nt32Pkg which is being
>replaced with features in the EmulatorPkg.
>
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>---
> BaseTools/Source/Python/build/build.py | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 7271570d29..04f266abf5 100644
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -1225,14 +1225,10 @@ class Build():
>
>         makefile =3D
>GenMake.BuildFile(AutoGenObject)._FILE_NAME_[GenMake.gMakeType]
>
>         # run
>         if Target =3D=3D 'run':
>-            RunDir =3D os.path.normpath(os.path.join(AutoGenObject.BuildD=
ir,
>GlobalData.gGlobalDefines['ARCH']))
>-            Command =3D '.\SecMain'
>-            os.chdir(RunDir)
>-            LaunchCommand(Command, RunDir)
>             return True
>
>         # build modules
>         if BuildModule:
>             BuildCommand =3D BuildCommand + [Target]
>--
>2.20.1.windows.1