From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Thu, 16 May 2019 18:12:08 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2019 18:12:07 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 16 May 2019 18:12:07 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 18:12:07 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 18:12:06 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.213]) with mapi id 14.03.0415.000; Fri, 17 May 2019 09:12:04 +0800 From: "Liming Gao" To: "Wang, Jian J" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Ye, Ting" Subject: Re: [PATCH] CryptoPkg/BaseCryptLib: remove unused code for IPF Thread-Topic: [PATCH] CryptoPkg/BaseCryptLib: remove unused code for IPF Thread-Index: AQHVCmGYmTl99I+Vwk+naOSCLkzYVKZuhizA Date: Fri, 17 May 2019 01:12:04 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E44C21E@SHSMSX104.ccr.corp.intel.com> References: <20190514143000.486176-1-jian.j.wang@intel.com> In-Reply-To: <20190514143000.486176-1-jian.j.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I see no module consumes this source file.=20 The change is good. Reviewed-by: Liming Gao >-----Original Message----- >From: Wang, Jian J >Sent: Tuesday, May 14, 2019 10:30 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Kinney, Michael D >; Ye, Ting >Subject: [PATCH] CryptoPkg/BaseCryptLib: remove unused code for IPF > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1805 > >CryptRandItc.c is only for IPF arch, which has not been supported any >more in edk2. And no module actually reference this file. This patch >just removes it from tree. > >Cc: Liming Gao >Cc: Michael D Kinney >Cc: Ting Ye >Signed-off-by: Jian J Wang >--- > .../Library/BaseCryptLib/Rand/CryptRandItc.c | 112 ------------------ > 1 file changed, 112 deletions(-) > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Rand/CryptRandItc.c > >diff --git a/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandItc.c >b/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandItc.c >deleted file mode 100644 >index 8699cfeb71..0000000000 >--- a/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandItc.c >+++ /dev/null >@@ -1,112 +0,0 @@ >-/** @file >- Pseudorandom Number Generator Wrapper Implementation over OpenSSL. >- >-Copyright (c) 2012 - 2018, Intel Corporation. All rights reserved.
>-SPDX-License-Identifier: BSD-2-Clause-Patent >- >-**/ >- >-#include "InternalCryptLib.h" >-#include >-#include >-#include >- >-/** >- Sets up the seed value for the pseudorandom number generator. >- >- This function sets up the seed value for the pseudorandom number >generator. >- If Seed is not NULL, then the seed passed in is used. >- If Seed is NULL, then default seed is used. >- >- @param[in] Seed Pointer to seed value. >- If NULL, default seed is used. >- @param[in] SeedSize Size of seed value. >- If Seed is NULL, this parameter is ignored. >- >- @retval TRUE Pseudorandom number generator has enough entropy for >random generation. >- @retval FALSE Pseudorandom number generator does not have enough >entropy for random generation. >- >-**/ >-BOOLEAN >-EFIAPI >-RandomSeed ( >- IN CONST UINT8 *Seed OPTIONAL, >- IN UINTN SeedSize >- ) >-{ >- CHAR8 DefaultSeed[128]; >- >- if (SeedSize > INT_MAX) { >- return FALSE; >- } >- >- // >- // The software PRNG implementation built in OpenSSL depends on >message digest algorithm. >- // Make sure SHA-1 digest algorithm is available here. >- // >- if (EVP_add_digest (EVP_sha1 ()) =3D=3D 0) { >- return FALSE; >- } >- >- // >- // Seed the pseudorandom number generator with user-supplied value. >- // NOTE: A cryptographic PRNG must be seeded with unpredictable data. >- // >- if (Seed !=3D NULL) { >- RAND_seed (Seed, (UINT32) SeedSize); >- } else { >- // >- // Retrieve current time. >- // >- AsciiSPrint ( >- DefaultSeed, >- sizeof (DefaultSeed), >- "UEFI Crypto Library default seed (%ld)", >- AsmReadItc () >- ); >- >- RAND_seed (DefaultSeed, sizeof (DefaultSeed)); >- } >- >- if (RAND_status () =3D=3D 1) { >- return TRUE; >- } >- >- return FALSE; >-} >- >-/** >- Generates a pseudorandom byte stream of the specified size. >- >- If Output is NULL, then return FALSE. >- >- @param[out] Output Pointer to buffer to receive random value. >- @param[in] Size Size of random bytes to generate. >- >- @retval TRUE Pseudorandom byte stream generated successfully. >- @retval FALSE Pseudorandom number generator fails to generate due to >lack of entropy. >- >-**/ >-BOOLEAN >-EFIAPI >-RandomBytes ( >- OUT UINT8 *Output, >- IN UINTN Size >- ) >-{ >- // >- // Check input parameters. >- // >- if (Output =3D=3D NULL || Size > INT_MAX) { >- return FALSE; >- } >- >- // >- // Generate random data. >- // >- if (RAND_bytes (Output, (UINT32) Size) !=3D 1) { >- return FALSE; >- } >- >- return TRUE; >-} >-- >2.17.1.windows.2