From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kubacki, Michael A" <michael.a.kubacki@intel.com>,
"Zhang, Shenglei" <shenglei.zhang@intel.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Lu, Shifei A" <shifei.a.lu@intel.com>,
"Zhou, Bowen" <bowen.zhou@intel.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms V2 16/16] Platform/PurleyOpenBoardPkg: Update DSC/FDF to use NetworkPkg's fragment file.
Date: Sun, 19 May 2019 12:59:59 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E44D228@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <49AB4ACB9627B8468F29D589A27B7455889458BB@ORSMSX121.amr.corp.intel.com>
For the change in Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc,
Need !include NetworkPkg/NetworkDefines.dsc.inc
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Kubacki, Michael A
> Sent: Friday, May 17, 2019 3:26 PM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Lu, Shifei A <shifei.a.lu@intel.com>; Zhou, Bowen <bowen.zhou@intel.com>
> Subject: Re: [edk2-devel] [PATCH edk2-platforms V2 16/16] Platform/PurleyOpenBoardPkg: Update DSC/FDF to use NetworkPkg's
> fragment file.
>
> This looks like a good improvement.
> ---
> * This is touching three packages though the patch only calls out PurleyOpenBoardPkg.
> * AdvancedFeaturePkg
> * MinPlatformPkg
> * Purley OpenBoardPkg
> ---
> * Copyright years in files modified are not updated.
> ---
> There's some PatchCheck.py errors, please check and fix those.
>
> Thanks,
> Michael
>
> > -----Original Message-----
> > From: Zhang, Shenglei
> > Sent: Friday, May 17, 2019 12:10 AM
> > To: devel@edk2.groups.io
> > Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Yao, Jiewen
> > <jiewen.yao@intel.com>; Lu, Shifei A <shifei.a.lu@intel.com>; Zhou, Bowen
> > <bowen.zhou@intel.com>
> > Subject: [PATCH edk2-platforms V2 16/16] Platform/PurleyOpenBoardPkg:
> > Update DSC/FDF to use NetworkPkg's fragment file.
> >
> > This patch updates the platform DSC/FDF files to use the include fragment
> > files provided by NetworkPkg.And add network related definition in Purley
> > PlatformPkg.dsc.
> >
> > Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > cc: Shifei A Lu <shifei.a.lu@intel.com>
> > cc: Xiaohu Zhou <bowen.zhou@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> > .../Include/Dsc/CoreAdvancedDxeInclude.dsc | 26 +------------------
> > .../Include/Fdf/CoreAdvancedLateInclude.fdf | 26 +------------------
> > .../Include/Dsc/CoreCommonLib.dsc | 11 ++++----
> > .../BoardMtOlympus/PlatformPkg.dsc | 6 +++++
> > 4 files changed, 14 insertions(+), 55 deletions(-)
> >
> > diff --git
> > a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud
> > e.dsc
> > b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud
> > e.dsc
> > index 6764d46131..0c44c52582 100644
> > ---
> > a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud
> > e.dsc
> > +++
> > b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclu
> > +++ de.dsc
> > @@ -17,31 +17,7 @@
> > #
> > # UEFI network modules
> > #
> > -!if gAdvancedFeaturePkgTokenSpaceGuid.PcdNetworkEnable == TRUE
> > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
> > - MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf
> > - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
> > - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
> > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
> > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> > -
> > - NetworkPkg/Ip6Dxe/Ip6Dxe.inf
> > - NetworkPkg/TcpDxe/TcpDxe.inf
> > - NetworkPkg/Udp6Dxe/Udp6Dxe.inf
> > - NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf
> > - NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf
> > -
> > - NetworkPkg/DnsDxe/DnsDxe.inf
> > - NetworkPkg/HttpDxe/HttpDxe.inf
> > - NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
> > - NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> > -
> > - NetworkPkg/IScsiDxe/IScsiDxe.inf
> > - NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > -!endif
> > + !include NetworkPkg/NetworkComponents.dsc.inc
> >
> > !if gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosEnable == TRUE
> > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
> > diff --git
> > a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud
> > e.fdf
> > b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud
> > e.fdf
> > index 64f1dd5872..97706f7805 100644
> > ---
> > a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud
> > e.fdf
> > +++
> > b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateIncl
> > +++ ude.fdf
> > @@ -17,31 +17,7 @@
> > #
> > # UEFI network modules
> > #
> > -!if gAdvancedFeaturePkgTokenSpaceGuid.PcdNetworkEnable == TRUE -INF
> > MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
> > -INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf
> > -INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
> > -INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
> > -INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
> > -INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> > -INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> > -INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> > -INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> > -
> > -INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf
> > -INF NetworkPkg/TcpDxe/TcpDxe.inf
> > -INF NetworkPkg/Udp6Dxe/Udp6Dxe.inf
> > -INF NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf
> > -INF NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf
> > -
> > -INF NetworkPkg/DnsDxe/DnsDxe.inf
> > -INF NetworkPkg/HttpDxe/HttpDxe.inf
> > -INF NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
> > -INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> > -
> > -INF NetworkPkg/IScsiDxe/IScsiDxe.inf
> > -INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > -!endif
> > +!include NetworkPkg/Network.fdf.inc
> >
> > !if gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosEnable == TRUE INF
> > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
> > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > index dd0173a1af..e8f4760395 100644
> > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > @@ -78,11 +78,12 @@
> > #
> > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
> > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf
> > - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
> > - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf
> > - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
> > - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf
> > - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
> > +
> > + #
> > + # Network libraries
> > + #
> > +!include NetworkPkg/NetworkLibs.dsc.inc
> > +
> >
> > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN
> > ull/OemHookStatusCodeLibNull.inf
> >
> > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in
> > f
> >
> > diff --git
> > a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc
> > b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc
> > index ded1201a86..c549936299 100644
> > ---
> > a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc
> > +++
> > b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc
> > @@ -36,6 +36,12 @@
> > BUILD_TARGETS = DEBUG|RELEASE
> > SKUID_IDENTIFIER = DEFAULT
> >
> > + !if gAdvancedFeaturePkgTokenSpaceGuid.PcdNetworkEnable == TRUE
> > + DEFINE NETWORK_TLS_ENABLE = FALSE
> > + !else
> > + DEFINE NETWORK_ENABLE = FALSE
> > + !endif
> > +
> > #
> > # Set the global variables
> > #
> > --
> > 2.18.0.windows.1
>
>
>
prev parent reply other threads:[~2019-05-19 13:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 7:10 [PATCH edk2-platforms V2 00/16] Add Network's include segment files in DSC/FDF Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 01/16] Platform/OverdriveBoard: Update DSC/FDF to use NetworkPkg's fragment file Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 02/16] Platform/VExpressPkg: Update DSC/FDF to use NetworkPkg's include " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 03/16] Hisilicon/D03: " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 04/16] Hisilicon/D05: " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 05/16] Hisilicon/D06: " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 06/16] Hisilicon/HiKey: " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 07/16] Hisilicon/HiKey960: " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 08/16] Platform/CelloBoard: " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 09/16] Platform/DeveloperBox: Update DSC/FDF to use NetworkPkg's " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 10/16] Platform/SynQuacerEvalBoard: " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 11/16] Platform/Overdrive1000Board: " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 12/16] Silicon/Armada7k8k: Update DSC/FDF to use NetworkPkg's include " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 13/16] Platform/SgiPkg: Update FDF " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 14/16] Platform/RDKQemu: Update DSC " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 15/16] Platform/Vlv2TbltDevicePkg: Update DSC/FDF to use NetworkPkg's " Zhang, Shenglei
2019-05-17 7:10 ` [PATCH edk2-platforms V2 16/16] Platform/PurleyOpenBoardPkg: " Zhang, Shenglei
2019-05-17 7:26 ` Kubacki, Michael A
2019-05-19 12:59 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E44D228@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox