From: "Liming Gao" <liming.gao@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [Patch edk2-platform 1/3] Platform/ARM: Add NetworkPkg/NetworkPkg.dec as the package dependency
Date: Mon, 20 May 2019 14:54:41 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E44DD67@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190520145126.uxuxpplf2eaaei6n@bivouac.eciton.net>
Thanks for your quick review. I will update and push.
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Monday, May 20, 2019 10:51 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [Patch edk2-platform 1/3] Platform/ARM: Add NetworkPkg/NetworkPkg.dec as the package dependency
>
> On Mon, May 20, 2019 at 09:09:47PM +0800, Liming Gao wrote:
> > NetLib will be moved from MdeModulePkg and NetworkPkg.
> > So, the module that consumes NetLib need to depend on NetworkPkg.dec.
> >
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> > Platform/ARM/Library/BdsLib/BdsLib.inf | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Platform/ARM/Library/BdsLib/BdsLib.inf b/Platform/ARM/Library/BdsLib/BdsLib.inf
> > index 12995cf174..6b95ec943b 100644
> > --- a/Platform/ARM/Library/BdsLib/BdsLib.inf
> > +++ b/Platform/ARM/Library/BdsLib/BdsLib.inf
> > @@ -23,6 +23,7 @@
> > MdeModulePkg/MdeModulePkg.dec
> > MdePkg/MdePkg.dec
> > Platform/ARM/ARM.dec
> > + NetworkPkg/NetworkPkg.dec
>
> If you move that insertion up one line to get it alphabetically
> sorted:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> >
> > [LibraryClasses]
> > ArmLib
> > --
> > 2.13.0.windows.1
> >
next prev parent reply other threads:[~2019-05-20 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 13:09 [Patch edk2-platform 0/3] Add NetworkPkg/NetworkPkg.dec as the package dependency Liming Gao
2019-05-20 13:09 ` [Patch edk2-platform 1/3] Platform/ARM: " Liming Gao
2019-05-20 14:51 ` Leif Lindholm
2019-05-20 14:54 ` Liming Gao [this message]
2019-05-20 13:09 ` [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec " Liming Gao
2019-05-20 15:05 ` Sun, Zailiang
2019-05-21 1:00 ` Qian, Yi
2019-05-22 3:42 ` Sun, Zailiang
2019-05-20 13:09 ` [Patch edk2-platform 3/3] Silicon/Marvell: Add NetworkPkg/NetworkPkg.dec " Liming Gao
2019-05-20 14:52 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E44DD67@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox