From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Mon, 20 May 2019 07:54:46 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 May 2019 07:54:45 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 20 May 2019 07:54:44 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 20 May 2019 07:54:43 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.18]) with mapi id 14.03.0415.000; Mon, 20 May 2019 22:54:42 +0800 From: "Liming Gao" To: Leif Lindholm CC: "devel@edk2.groups.io" , Ard Biesheuvel , "Kinney, Michael D" Subject: Re: [Patch edk2-platform 1/3] Platform/ARM: Add NetworkPkg/NetworkPkg.dec as the package dependency Thread-Topic: [Patch edk2-platform 1/3] Platform/ARM: Add NetworkPkg/NetworkPkg.dec as the package dependency Thread-Index: AQHVDxuFWJ6eGg5Mlki+bd1WQBWyyqZ0GY/Q Date: Mon, 20 May 2019 14:54:41 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E44DD67@SHSMSX104.ccr.corp.intel.com> References: <20190520130949.20412-1-liming.gao@intel.com> <20190520130949.20412-2-liming.gao@intel.com> <20190520145126.uxuxpplf2eaaei6n@bivouac.eciton.net> In-Reply-To: <20190520145126.uxuxpplf2eaaei6n@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDRiMjRkNTQtZTgzYy00OWEwLWJiMDMtZmFlNGE0ZGIwMTVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibXk5c2p0QmxqSXNMZHVcL0R0c1plaXpnMmhCa0RLYzFQcFNVc0haOTRGbWhLTVhzMzNPS0VweURlS3JhN3hpT1kifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for your quick review. I will update and push.=20 > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Monday, May 20, 2019 10:51 PM > To: Gao, Liming > Cc: devel@edk2.groups.io; Ard Biesheuvel ; Kin= ney, Michael D > Subject: Re: [Patch edk2-platform 1/3] Platform/ARM: Add NetworkPkg/Netwo= rkPkg.dec as the package dependency >=20 > On Mon, May 20, 2019 at 09:09:47PM +0800, Liming Gao wrote: > > NetLib will be moved from MdeModulePkg and NetworkPkg. > > So, the module that consumes NetLib need to depend on NetworkPkg.dec. > > > > Signed-off-by: Liming Gao > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > --- > > Platform/ARM/Library/BdsLib/BdsLib.inf | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Platform/ARM/Library/BdsLib/BdsLib.inf b/Platform/ARM/Libr= ary/BdsLib/BdsLib.inf > > index 12995cf174..6b95ec943b 100644 > > --- a/Platform/ARM/Library/BdsLib/BdsLib.inf > > +++ b/Platform/ARM/Library/BdsLib/BdsLib.inf > > @@ -23,6 +23,7 @@ > > MdeModulePkg/MdeModulePkg.dec > > MdePkg/MdePkg.dec > > Platform/ARM/ARM.dec > > + NetworkPkg/NetworkPkg.dec >=20 > If you move that insertion up one line to get it alphabetically > sorted: > Reviewed-by: Leif Lindholm >=20 > > > > [LibraryClasses] > > ArmLib > > -- > > 2.13.0.windows.1 > >