From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Tue, 21 May 2019 06:17:12 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2019 06:17:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,495,1549958400"; d="scan'208";a="174018807" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 21 May 2019 06:17:11 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 21 May 2019 06:17:11 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by shsmsx102.ccr.corp.intel.com ([169.254.2.249]) with mapi id 14.03.0415.000; Tue, 21 May 2019 21:17:08 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" , "Zhang, Shenglei" Subject: Re: [edk2-devel] [PATCH edk2-platforms V3 10/18] Platform/SynQuacerEvalBoard: Update DSC/FDF to use NetworkPkg DSC/FDF Thread-Topic: [edk2-devel] [PATCH edk2-platforms V3 10/18] Platform/SynQuacerEvalBoard: Update DSC/FDF to use NetworkPkg DSC/FDF Thread-Index: AQHVDtrJbk0WUnM1MUWutDBUbaxZXqZ09W8AgACbqLA= Date: Tue, 21 May 2019 13:17:08 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E44ED4A@SHSMSX104.ccr.corp.intel.com> References: <20190520070729.30812-1-shenglei.zhang@intel.com> <20190520070729.30812-11-shenglei.zhang@intel.com> <20190521115922.i5ljs43ske7told6@bivouac.eciton.net> In-Reply-To: <20190521115922.i5ljs43ske7told6@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2RiYzZlNDAtZDUwNC00M2Q0LThiYzQtZTUwNmUxZTc5Yzk2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUGJ4cGFjOGhOaUNaY1MySlwvR2k2Q2hiVlRRTGxhSUxEWkEyeStCbFN4aEFqbUd0WlFCVitPM3FpRXlLTjV0Qk0ifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif: > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Le= if Lindholm > Sent: Tuesday, May 21, 2019 7:59 PM > To: Zhang, Shenglei > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH edk2-platforms V3 10/18] Platform/SynQu= acerEvalBoard: Update DSC/FDF to use NetworkPkg DSC/FDF >=20 > On Mon, May 20, 2019 at 03:07:21PM +0800, Shenglei Zhang wrote: > > This patch updates the platform DSC/FDF files to use the include fragm= ent > > files provided by NetworkPkg. > > > > v2: Change Network.dsc.inc to Network.fdf.inc in SynQuacerEvalBoard.fd= f. >=20 > Any notes on changes go under the "---" line below. > If you delete this revision comment before committing: > Reviewed-by: Leif Lindholm >=20 I will remove the version in the commit message.=20 Thanks for your review. > > Cc: Leif Lindholm > > Signed-off-by: Shenglei Zhang > > --- > > .../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 35 +++++-------------= - > > .../SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 21 ++--------- > > 2 files changed, 10 insertions(+), 46 deletions(-) > > > > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.= dsc > b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > > index 189baa8659..ab1ab6f2de 100644 > > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > > @@ -22,6 +22,12 @@ > > FLASH_DEFINITION =3D Platform/Socionext/SynQuacerEval= Board/SynQuacerEvalBoard.fdf > > BUILD_NUMBER =3D 1 > > > > + # > > + # Network definition > > + # > > + DEFINE NETWORK_SNP_ENABLE =3D FALSE > > + DEFINE NETWORK_TLS_ENABLE =3D FALSE > > + > > [BuildOptions] > > RELEASE_*_*_CC_FLAGS =3D -DMDEPKG_NDEBUG -U_FORTIFY_SOURCE -D_FORT= IFY_SOURCE=3D0 > > > > @@ -49,11 +55,6 @@ > > > > BaseMemoryLib|MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDx= e.inf > > > > - # Networking Requirements > > - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > > - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > > - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > > - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > > > > # ARM Architectural Libraries > > CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheM= aintenanceLib.inf > > @@ -113,9 +114,6 @@ > > SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011Serial= PortLib.inf > > PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf > > > > - HttpLib|MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.inf > > - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > > - > > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > > > > @@ -594,25 +592,8 @@ > > # > > # Networking stack > > # > > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > > - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > > - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > > - NetworkPkg/Ip6Dxe/Ip6Dxe.inf > > - NetworkPkg/TcpDxe/TcpDxe.inf > > - NetworkPkg/Udp6Dxe/Udp6Dxe.inf > > - NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf > > - NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > > - NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > - NetworkPkg/IScsiDxe/IScsiDxe.inf > > - NetworkPkg/DnsDxe/DnsDxe.inf > > - NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > > - NetworkPkg/HttpDxe/HttpDxe.inf > > - NetworkPkg/HttpBootDxe/HttpBootDxe.inf > > +!include NetworkPkg/Network.dsc.inc > > + > > Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf { > > > > DmaLib|EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.inf > > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.= fdf > b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > > index 1c9795df3b..b1e0a53e61 100644 > > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > > @@ -186,25 +186,8 @@ READ_LOCK_STATUS =3D TRUE > > # > > # Networking stack > > # > > - INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > > - INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > > - INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > > - INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > > - INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > > - INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > > - INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > - INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > > - INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf > > - INF NetworkPkg/TcpDxe/TcpDxe.inf > > - INF NetworkPkg/Udp6Dxe/Udp6Dxe.inf > > - INF NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf > > - INF NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > > - INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > - INF NetworkPkg/IScsiDxe/IScsiDxe.inf > > - INF NetworkPkg/DnsDxe/DnsDxe.inf > > - INF NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > > - INF NetworkPkg/HttpDxe/HttpDxe.inf > > - INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf > > +!include NetworkPkg/Network.fdf.inc > > + > > INF Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf > > > > # > > -- > > 2.18.0.windows.1 > > >=20 >=20