From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Tue, 21 May 2019 08:06:17 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2019 08:06:16 -0700 X-ExtLoop1: 1 Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 21 May 2019 08:06:16 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 21 May 2019 08:06:16 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 21 May 2019 08:06:15 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.126]) with mapi id 14.03.0415.000; Tue, 21 May 2019 23:06:14 +0800 From: "Liming Gao" To: "Feng, Bob C" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [Patch] BaseTools: Remove './SecMain' from 'run' target Thread-Topic: [Patch] BaseTools: Remove './SecMain' from 'run' target Thread-Index: AQHVBvpVwXHrtNL2AEeAxttYUtD21aZj9R3w//98W4CAEkyfcA== Date: Tue, 21 May 2019 15:06:14 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E44EF2C@SHSMSX104.ccr.corp.intel.com> References: <20190510063336.27928-1-bob.c.feng@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4466B8@SHSMSX104.ccr.corp.intel.com> <08650203BA1BD64D8AD9B6D5D74A85D16010A5F3@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D16010A5F3@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2MzOWJmZDUtMzhlYi00MDRkLTg5ZjQtMDRmYzJlODg4OWJlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiV0RjcGk5UG83Tk9zSUs0VHEzUXE4ZFwvTnphRVRGOWFRQUJWUUkrYjRjU1I3Zk84UGVrN3AwV2JhTlZJQUN2ZEEifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Bob: Because NT32 has been removed, this change should be OK. Reviewed-by: Lim= ing Gao Thanks Liming > -----Original Message----- > From: Feng, Bob C > Sent: Friday, May 10, 2019 3:34 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [Patch] BaseTools: Remove './SecMain' from 'run' target >=20 > I think NT32Pkg need a POSTBUILD scripts to execute its run command. >=20 >=20 > -----Original Message----- > From: Gao, Liming > Sent: Friday, May 10, 2019 3:26 PM > To: Feng, Bob C ; devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [Patch] BaseTools: Remove './SecMain' from 'run' target >=20 > Bob: > Please make sure run command still works on NT32 platform. >=20 > >-----Original Message----- > >From: Feng, Bob C > >Sent: Friday, May 10, 2019 2:34 PM > >To: devel@edk2.groups.io > >Cc: Feng, Bob C ; Gao, Liming > >; Kinney, Michael D > >Subject: [Patch] BaseTools: Remove './SecMain' from 'run' target > > > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1561 > > > >When a target of 'run' is passed into build.py, BaseTools > >unconditionally attempts to execute the application called './SecMain' > >in the build output directory. > > > >This behavior applies to the Nt32Pkg which is being replaced with > >features in the EmulatorPkg. > > > >Signed-off-by: Bob Feng > >Cc: Liming Gao > >Cc: Michael D Kinney > >--- > > BaseTools/Source/Python/build/build.py | 4 ---- > > 1 file changed, 4 deletions(-) > > > >diff --git a/BaseTools/Source/Python/build/build.py > >b/BaseTools/Source/Python/build/build.py > >index 7271570d29..04f266abf5 100644 > >--- a/BaseTools/Source/Python/build/build.py > >+++ b/BaseTools/Source/Python/build/build.py > >@@ -1225,14 +1225,10 @@ class Build(): > > > > makefile =3D > >GenMake.BuildFile(AutoGenObject)._FILE_NAME_[GenMake.gMakeType] > > > > # run > > if Target =3D=3D 'run': > >- RunDir =3D os.path.normpath(os.path.join(AutoGenObject.Buil= dDir, > >GlobalData.gGlobalDefines['ARCH'])) > >- Command =3D '.\SecMain' > >- os.chdir(RunDir) > >- LaunchCommand(Command, RunDir) > > return True > > > > # build modules > > if BuildModule: > > BuildCommand =3D BuildCommand + [Target] > >-- > >2.20.1.windows.1